[go] runtime/pprof: sum fast+slow paths in heap test
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Aug 14, 2026, 11:16:14 PM (2 days ago) Aug 14
to Rhys Hiltner, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Dmitri Shuralyov, Michael Matloob, Michael Matloob, Richard Miller, golang...@luci-project-accounts.iam.gserviceaccount.com, golang-co...@googlegroups.com
Gopher Robot submitted the change![]( "Open in Gerrit")
Change information
Commit message:
runtime/pprof: sum fast+slow paths in heap test
Size-specialized malloc has different function call stacks for its fast
and slow paths, and these can appear in the resulting heap profile. When
testing the text format runtime/pprof output, allow for that possibility
by summing all matching allocations.
Continue to ignore allocations that are a different size than the ones
we're looking for. That include slice headers of course, but also sudog
values from inside gcMarkDone's calls to semacquire1.
Fixes #79528
Change-Id: I7f1f8b29e1074e06dca4f0ec7a11dc7067e63292
Reviewed-on: https://go-review.googlesource.com/c/go/+/814280
Auto-Submit: Rhys Hiltner <rhys.h...@gmail.com>
LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>
Reviewed-by: Michael Matloob <mat...@google.com>
Reviewed-by: Michael Matloob <mat...@golang.org>
Reviewed-by: Richard Miller <millerr...@gmail.com>
Reviewed-by: Dmitri Shuralyov <dmit...@google.com>
Files:
- M src/runtime/pprof/mprof_test.go
Change size: M
Delta: 1 file changed, 84 insertions(+), 23 deletions(-)
Branch: refs/heads/master
Submit Requirements:
Code-Review: +2 by Michael Matloob, +1 by Richard Miller, +1 by Dmitri Shuralyov, +1 by Michael Matloob
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com
| Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. |
Reply all
Reply to author
Forward
0 new messages