[tools] gopls/internal/filewatcher: add watcher interface

0 views

Skip to first unread message

Gopher Robot (Gerrit)

unread,

Mar 17, 2026, 2:16:27 PM (yesterday) Mar 17

to Hongxiang Jiang, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Go LUCI, Alan Donovan, golang-co...@googlegroups.com

Gopher Robot submitted the change with unreviewed changes

Unreviewed changes

1 is the latest approved patch-set.
The change was submitted with unreviewed changes in the following files:

```
The name of the file: gopls/internal/filewatcher/filewatcher.go
Insertions: 2, Deletions: 0.

@@ -31,6 +31,8 @@
 // The provided event handler is called sequentially with a batch of file events,
 // but the error handler is called concurrently. The watcher blocks until the
 // handler returns, so the handlers should be fast and non-blocking.
+//
+// TODO(hxjiang): replace mode string to enum.
 func New(mode string, interval time.Duration, logger *slog.Logger, onEvents func([]protocol.FileEvent), onError func(error)) (Watcher, error) {
 	switch mode {
 	// TODO (hxjiang): support poll watcher.
```
```
The name of the file: gopls/internal/filewatcher/fsnotify_watcher.go
Insertions: 2, Deletions: 0.

@@ -7,6 +7,7 @@
 import (
 	"errors"
 	"io/fs"
+	"log"
 	"log/slog"
 	"os"
 	"path/filepath"
@@ -292,6 +293,7 @@
 // WatchDir walks through the directory and all its subdirectories, adding
 // them to the watcher.
 func (w *fsnotifyWatcher) WatchDir(path string) error {
+	log.Printf("Watching %s", path)
 	return filepath.WalkDir(filepath.Clean(path), func(path string, d fs.DirEntry, err error) error {
 		if d.IsDir() {
 			if skipDir(d.Name()) {
```

Change information

Commit message:

gopls/internal/filewatcher: add watcher interface

This change introduces a Watcher interface to allow for alternative
file-watching implementations (e.g., a git status-like scanner).
The existing fsnotify-based implementation is renamed to fsnotifyWatcher.

For golang/go#77814 golang/go#76291

Change-Id: I73e2c2526bb8accec18caef17c051211b026830b

Reviewed-on: https://go-review.googlesource.com/c/tools/+/756020

Auto-Submit: Hongxiang Jiang <hxj...@golang.org>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Alan Donovan <adon...@google.com>

Files: