[time] x/time/rate: use time.Time.Equal instead of ==

0 views
Skip to first unread message

Sean Liao (Gerrit)

unread,
Sep 16, 2025, 7:29:59 PM (7 days ago) Sep 16
to 叶万标, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Mark Freeman, Michael Knyszek, Go LUCI, golang-co...@googlegroups.com

Sean Liao submitted the change

Unreviewed changes

4 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.

Change information

Commit message:
rate: use time.Time.Equal instead of ==

According to the Time Type documentation, in most cases, it is better
to use Equal instead of ==


Change-Id: I201de68ee163a06cf9ed49f7b77a2de031dbdd95
Reviewed-on: https://go-review.googlesource.com/c/time/+/703175
Reviewed-by: Michael Knyszek <mkny...@google.com>
Reviewed-by: Florian Lehner <lehner.f...@gmail.com>
Reviewed-by: Sean Liao <se...@liao.dev>
Reviewed-by: Mark Freeman <markf...@google.com>
LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>
Files:
  • M rate/rate.go
Change size: XS
Delta: 1 file changed, 1 insertion(+), 1 deletion(-)
Branch: refs/heads/master
Submit Requirements:
  • requirement satisfiedCode-Review: +1 by Florian Lehner, +2 by Sean Liao, +1 by Michael Knyszek, +1 by Mark Freeman
  • requirement satisfiedTryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI
Open in Gerrit
Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings. DiffyGerrit
Gerrit-MessageType: merged
Gerrit-Project: time
Gerrit-Branch: master
Gerrit-Change-Id: I201de68ee163a06cf9ed49f7b77a2de031dbdd95
Gerrit-Change-Number: 703175
Gerrit-PatchSet: 6
Gerrit-Owner: 叶万标 <lacew...@gmail.com>
Gerrit-Reviewer: Florian Lehner <lehner.f...@gmail.com>
Gerrit-Reviewer: Mark Freeman <markf...@google.com>
Gerrit-Reviewer: Michael Knyszek <mkny...@google.com>
Gerrit-Reviewer: Sean Liao <se...@liao.dev>
open
diffy
satisfied_requirement
Reply all
Reply to author
Forward
0 new messages