[tools] gopls: improve doc link matching to support links followed by a colon

[Gopher Robot (Gerrit)]

Gopher Robot submitted the change

Change information

Commit message:

gopls: improve doc link matching to support links followed by a colon

The existing `docLinkRegex` fails to handle cases like `[Demo]: demo`,
which are valid. This change introduces a new helper function,
`findDocLinkIndices`, to correctly locate doc link indices. In the mean
time, changing the `docLinkRegex` to find out all the matched positions.

Fixes golang/go#75925

Change-Id: I359990d9c71c73bad5869c280af74dd301f96338

Reviewed-on: https://go-review.googlesource.com/c/tools/+/715240

Reviewed-by: Madeline Kalil <mka...@google.com>

Reviewed-by: Alan Donovan <adon...@google.com>

Auto-Submit: Alan Donovan <adon...@google.com>

LUCI-TryBot-Result: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Files:

• M gopls/internal/golang/comment.go
• M gopls/internal/golang/semtok.go
• A gopls/internal/test/marker/testdata/token/issue75925.txt

Change size: M

Delta: 3 files changed, 60 insertions(+), 4 deletions(-)

Branch: refs/heads/master

Submit Requirements:

• Code-Review: +2 by Alan Donovan, +2 by Madeline Kalil
• TryBots-Pass: LUCI-TryBot-Result+1 by Go LUCI

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

Gerrit-MessageType: merged

Gerrit-Project: tools

Gerrit-Branch: master

Gerrit-Change-Id: I359990d9c71c73bad5869c280af74dd301f96338

Gerrit-Change-Number: 715240

Gerrit-PatchSet: 4

Gerrit-Owner: Runqian Chen <runqian...@gmail.com>

Gerrit-Reviewer: Alan Donovan <adon...@google.com>

Gerrit-Reviewer: Go LUCI <golang...@luci-project-accounts.iam.gserviceaccount.com>

Gerrit-Reviewer: Gopher Robot <go...@golang.org>

Gerrit-Reviewer: Madeline Kalil <mka...@google.com>