[go] runtime: remove unnecessary writes to gp.sched.g on loong64
0 views
Skip to first unread message
Gopher Robot (Gerrit)
Mar 28, 2023, 10:23:26 PM3/28/23
to abner chenc, goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Wayne Zuo, Cherry Mui, Austin Clements, Keith Randall, Michael Knyszek, golang-co...@googlegroups.com
Gopher Robot submitted this change.
3 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted one.
Approvals:
Cherry Mui: Looks good to me, approved
Wayne Zuo: Run TryBots; Automatically submit change
WANG Xuerui: Looks good to me, but someone else must approve
Ian Lance Taylor: Looks good to me, but someone else must approve
Gopher Robot: TryBots succeeded
runtime: remove unnecessary writes to gp.sched.g on loong64
Same as CL 292109, A g's sched.g is set in newproc1, After that, it never changes.
Yet lots of assembly code does "g.sched.g = g" unnecessarily. Remove it to avoid
confusion about whether it ever changes.
Change-Id: I3d3b18267a80bdd9ef5487c1d1d29de4c5a2d5cc
Reviewed-on: https://go-review.googlesource.com/c/go/+/476375
Reviewed-by: Ian Lance Taylor <ia...@google.com>
Auto-Submit: Wayne Zuo <wdv...@golangcn.org>
Reviewed-by: WANG Xuerui <g...@xen0n.name>
Run-TryBot: Wayne Zuo <wdv...@golangcn.org>
TryBot-Result: Gopher Robot <go...@golang.org>
Reviewed-by: Cherry Mui <cher...@google.com>
---
M src/runtime/asm_loong64.s
1 file changed, 0 insertions(+), 1 deletion(-)
diff --git a/src/runtime/asm_loong64.s b/src/runtime/asm_loong64.s
index d2b1514..b2aa5ef 100644
--- a/src/runtime/asm_loong64.s
+++ b/src/runtime/asm_loong64.s
@@ -128,7 +128,6 @@
MOVV R3, (g_sched+gobuf_sp)(g)
MOVV R1, (g_sched+gobuf_pc)(g)
MOVV R0, (g_sched+gobuf_lr)(g)
- MOVV g, (g_sched+gobuf_g)(g)
// Switch to m->g0 & its stack, call fn.
MOVV g, R19
To view, visit change 476375. To unsubscribe, or for help writing mail filters, visit settings.
Reply all
Reply to author
Forward
0 new messages