[go] crypto/internal/fips140/subtle: fix unalignment access and panic on mipsx

0 views

Skip to first unread message

Julian Zhu (Gerrit)

unread,

Jul 16, 2026, 1:34:40 PM (yesterday) Jul 16

to goph...@pubsubhelper.golang.org, golang-...@googlegroups.com, Dmitri Shuralyov, Dmitri Shuralyov, Keith Randall, Joel Sing, golang...@luci-project-accounts.iam.gserviceaccount.com, Keith Randall, Filippo Valsorda, golang-co...@googlegroups.com

Julian Zhu submitted the change

Change information

Commit message:

crypto/internal/fips140/subtle: re-add assembly implementation of xorBytes for mipsx

This CL reapplies CL 666275 , and fixes the previous implementation's unaligned access and panic on mipsx.

Updates #74998

Change-Id: I26cd3fdeb54419407bdc0a2f9616924e2e825bc3

Reviewed-on: https://go-review.googlesource.com/c/go/+/696076

Reviewed-by: Keith Randall <k...@google.com>

LUCI-TryBot-Result: golang...@luci-project-accounts.iam.gserviceaccount.com <golang...@luci-project-accounts.iam.gserviceaccount.com>

Reviewed-by: Keith Randall <k...@golang.org>

Reviewed-by: Dmitri Shuralyov <dmit...@google.com>

Files:

M src/crypto/internal/fips140/subtle/xor_generic.go
A src/crypto/internal/fips140/subtle/xor_mipsx.go
A src/crypto/internal/fips140/subtle/xor_mipsx.s

Change size: L

Delta: 3 files changed, 250 insertions(+), 1 deletion(-)

Branch: refs/heads/master

Submit Requirements:

Code-Review: +2 by Keith Randall, +1 by Dmitri Shuralyov, +1 by Keith Randall
TryBots-Pass: LUCI-TryBot-Result+1 by golang...@luci-project-accounts.iam.gserviceaccount.com

Open in Gerrit

Inspect html for hidden footers to help with email filtering. To unsubscribe visit settings.

Gerrit

open

diffy

satisfied_requirement

Reply all

Reply to author

Forward

0 new messages