[gunzemulator] r355 committed - Removed uses of pass-by-value std::string.

0 views
Skip to first unread message

gunzem...@googlecode.com

unread,
Jun 28, 2010, 12:08:25 PM6/28/10
to gogo-dev...@googlegroups.com
Revision: 355
Author: cg.wowus.cg
Date: Mon Jun 28 09:05:58 2010
Log: Removed uses of pass-by-value std::string.
http://code.google.com/p/gunzemulator/source/detail?r=355

Modified:
/trunk/database/src/MySQL/modules/CreateCharacter.cpp
/trunk/include/database/GunzDB.h
/trunk/include/database/MySQLGunzDB.h
/trunk/include/database/oopsies.h

=======================================
--- /trunk/database/src/MySQL/modules/CreateCharacter.cpp Sun Jun 27
16:05:47 2010
+++ /trunk/database/src/MySQL/modules/CreateCharacter.cpp Mon Jun 28
09:05:58 2010
@@ -26,7 +26,7 @@
return q;
}

-void MySQLGunzDB::CreateCharacter(const AccountInfo& accountInfo, string
name, uint32_t marker, uint32_t sex, uint32_t hair, uint32_t face, uint32_t
costume)
+void MySQLGunzDB::CreateCharacter(const AccountInfo& accountInfo, const
string& name, uint32_t marker, uint32_t sex, uint32_t hair, uint32_t face,
uint32_t costume)
{
if(!accountInfo.isValid)
throw InvalidAccountInfo();
=======================================
--- /trunk/include/database/GunzDB.h Mon Jun 28 09:02:44 2010
+++ /trunk/include/database/GunzDB.h Mon Jun 28 09:05:58 2010
@@ -69,7 +69,7 @@
*/
virtual void CreateCharacter(
const AccountInfo& accountInfo,
- std::string name,
+ const std::string& name,
boost::uint32_t marker,
boost::uint32_t sex,
boost::uint32_t hair,
=======================================
--- /trunk/include/database/MySQLGunzDB.h Mon Jun 28 09:02:44 2010
+++ /trunk/include/database/MySQLGunzDB.h Mon Jun 28 09:05:58 2010
@@ -99,7 +99,7 @@
public:
SmallVector<CharacterEntry, 4> GetCharacterList(const AccountInfo&
account);
bool NameExists(std::string name);
- void CreateCharacter(const AccountInfo& account, std::string name,
boost::uint32_t marker, boost::uint32_t sex, boost::uint32_t hair,
boost::uint32_t face, boost::uint32_t costume);
+ void CreateCharacter(const AccountInfo& account, const std::string& name,
boost::uint32_t marker, boost::uint32_t sex, boost::uint32_t hair,
boost::uint32_t face, boost::uint32_t costume);
CharacterInfo GetCharacterInfo(const AccountInfo& acc, boost::uint8_t
slot);

boost::uint32_t GetCID(uint32_t aid, uint32_t marker);
=======================================
--- /trunk/include/database/oopsies.h Thu Jun 24 17:29:09 2010
+++ /trunk/include/database/oopsies.h Mon Jun 28 09:05:58 2010
@@ -16,7 +16,7 @@
public:
std::string error;

- BannedUser(std::string account)
+ BannedUser(const std::string& account)
{
error = std::string("Account is banned: ") + account + "!";
}

Reply all
Reply to author
Forward
0 new messages