Enforced rate limits?

[Mark McDonald]

Hi,

I've had a quick look around the code for this (fantastic) library and have seen this comment, which leads me to believe that there is rate limit enforcement within the client library in some form:

https://github.com/google/go-github/blob/af17a5fa8537e159dfa73f1dd1d3f08e34dea200/github/github.go#L537

	// Client returns an *http.Client that makes requests which are subject to the // rate limit of your OAuth application.
	func (t *UnauthenticatedRateLimitedTransport) Client() *http.Client {
	return &http.Client{Transport: t}
	}

Except that I can't find any code that seems to actually enforce it.

Is this a real, implemented feature? Or is the comment incorrect/ambiguous?

To clarify, by rate limit enforcement, I mean that the library itself honours the rate limit in some way that enables me to fire off loads of requests with reckless abandon.

Thanks

Mark

[Will Norris]

No, it doesn't do any sort of automated throttling of requests.  In hindsight, perhaps that wasn't named as well as it could have been.

Jason Hall tried implementing this a few months back, but we both agreed that the library itself probably shouldn't be doing this, rather the application should.  See discussion on google/go-github#152 and google/go-github#153.

--
You received this message because you are subscribed to the Google Groups "go-github" group.
To unsubscribe from this group and stop receiving emails from it, send an email to go-github+...@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.

[Mark McDonald]

That makes sense, thanks Will.