diffutils & Solaris 10

[Mark Geary]

Machine is:
srv45> uname -a
SunOS srv45 5.10 Generic_144488-06 sun4u sparc SUNW,Sun-Fire

After "./configure" I had to make the changes below before make
completed without errors. Just an FYI. I'm not requesting any fixes
you don't think are necessary

srv45> diff src/dir.c~ src/dir.c
251a252,253
> int v1;
>
292c294
< int v1 = (*handle_file) (cmp,
---
> v1 = (*handle_file) (cmp,
345c347,348
< for (char const **p = dirdata.names; *p; p++)
---
> char const **p;
> for (p = dirdata.names; *p; p++)
srv45> diff src/io.c~ src/io.c
262a263,264
> size_t repetitions;
>
277c279
< size_t repetitions = 1;
---
> repetitions = 1;

Mark Geary

[Paul Eggert]

On 10/11/2012 09:10 AM, Mark Geary wrote:

> After "./configure" I had to make the changes below

Which compiler were you using, what compiler flags
did you pass it, and what diagnostics did you get
without your patch?

[Mark Geary]

On Thu, 11 Oct 2012, Paul Eggert wrote:

> On 10/11/2012 09:10 AM, Mark Geary wrote:
>
>> After "./configure" I had to make the changes below
>
> Which compiler were you using, what compiler flags did you pass it,

The top-level makefile has this:

CC = gcc
CCDEPMODE = depmode=gcc
CFLAGS = -g -O2

and

srv45 0 2 69 4:24pm> gcc --version
2.95.3

Is this what you're looking for?

> and what diagnostics did you get without your patch?

make[2]: Entering directory `/home/mag23/src/diffutils-3.2/src'
CC dir.o
dir.c: In function `diff_dirs':
dir.c:292: parse error before `int'
dir.c:295: `v1' undeclared (first use in this function)
dir.c:295: (Each undeclared identifier is reported only once
dir.c:295: for each function it appears in.)
dir.c: In function `find_dir_file_pathname':
dir.c:345: parse error before `char'
dir.c:345: `p' undeclared (first use in this function)
dir.c:345: parse error before `)'
dir.c:351: break statement not within loop or switch
dir.c: At top level:
dir.c:358: parse error before `}'
dir.c:360: `dir' undeclared here (not in a function)
dir.c:360: `match' undeclared here (not in a function)
dir.c:360: warning: initialization makes integer from pointer without a cast
dir.c:360: initializer element is not constant
dir.c:360: warning: data definition has no type or storage class
dir.c:361: parse error before `.'
dir.c:361: conflicting types for `free'
/usr/include/iso/stdlib_iso.h:125: previous declaration of `free'
dir.c:361: warning: data definition has no type or storage class
dir.c:362: parse error before `.'
dir.c:362: warning: data definition has no type or storage class

and

CC io.o
io.c: In function `find_and_hash_each_line':
io.c:277: parse error before `repetitions'
io.c:288: `repetitions' undeclared (first use in this function)
io.c:288: (Each undeclared identifier is reported only once
io.c:288: for each function it appears in.)
make[2]: *** [io.o] Error 1


Mark Geary
--
Don't forget to stop and eat the roses.

[Paul Eggert]

On 10/26/2012 01:31 PM, Mark Geary wrote:
> srv45 0 2 69 4:24pm> gcc --version
> 2.95.3

Eeeuuww. Don't do that. 2.95.3 is more than
ten years old, and I'd be surprised if it works
on Solaris 10, to compile anything nontrivial.

Please try the GCC that comes with Solaris 10,
or download a more-recent version and use that.
On Solaris 10 you can find it in /usr/sfw/bin
so you can prepend that directory to your PATH.
You may have to install the optional freeware
package.

[Mark Geary]

On Fri, 26 Oct 2012, Paul Eggert wrote:

> On 10/26/2012 01:31 PM, Mark Geary wrote:
>> srv45 0 2 69 4:24pm> gcc --version
>> 2.95.3
>
> Eeeuuww. Don't do that. 2.95.3 is more than
> ten years old, and I'd be surprised if it works
> on Solaris 10, to compile anything nontrivial.
>
> Please try the GCC that comes with Solaris 10,
> or download a more-recent version and use that.
> On Solaris 10 you can find it in /usr/sfw/bin
> so you can prepend that directory to your PATH.

It works. I wasn't aware of /usr/sfw/bin before this. Thanks.