bug#32676: [PATCH] Add option to highlight the 'next-error' error message

1 view
Skip to first unread message

Stefan Kangas

unread,
Feb 29, 2020, 10:41:09 AM2/29/20
to Eli Zaretskii, erjo...@gmail.com, rpl...@gmail.com, 32...@debbugs.gnu.org, Juri Linkov
Hi Ernesto,

To accept your contribution to Emacs, we need to you to assign
copyright to the FSF. You can read more about the reasons why here:
https://www.gnu.org/licenses/why-assign.html

Before we can make any progress with this patch, I think we need to
clarify that point. Would you be willing to sign such paperwork?

Thanks in advance.

Best regards,
Stefan Kangas

Eli Zaretskii <el...@gnu.org> writes:

>> From: Juri Linkov <ju...@linkov.net>
>> Cc: Eli Zaretskii <el...@gnu.org>, Robert Pluim <rpl...@gmail.com>, 32...@debbugs.gnu.org
>> Date: Mon, 08 Apr 2019 22:36:38 +0300
>>
>> > I'd like to know if this patch is still being considered?
>>
>> Why not? Your patch provides a helpful feature. I see only 2 problems
>> with its latest version:
>>
>> 1. compilation-current-error should be generalized not to be too
>> compilation-specific;
>>
>> 2. next-error-hook should not be used for core features,
>> you could call next-error-message-highlight directly
>> from next-error-found.
>
> 3. A contribution this size needs legal paperwork for us to be able to
> accept it. Ernesto, would you like to start the paperwork now?
>
> Thanks.



Lars Ingebrigtsen

unread,
Aug 10, 2020, 8:39:04 AM8/10/20
to Stefan Kangas, erjo...@gmail.com, Eli Zaretskii, Juri Linkov, rpl...@gmail.com, 32...@debbugs.gnu.org
Stefan Kangas <ste...@marxist.se> writes:

> To accept your contribution to Emacs, we need to you to assign
> copyright to the FSF. You can read more about the reasons why here:
> https://www.gnu.org/licenses/why-assign.html
>
> Before we can make any progress with this patch, I think we need to
> clarify that point. Would you be willing to sign such paperwork?

This was half a year ago, and I can't see Ernesto in the copyright
assignment file.

Ernesto?

--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no



Ernesto Alfonso

unread,
Aug 10, 2020, 10:02:04 AM8/10/20
to Lars Ingebrigtsen, Eli Zaretskii, Juri Linkov, Stefan Kangas, Robert Pluim, 32...@debbugs.gnu.org
Sorry about the delay, I will get back to this soon.

Ernesto

Ernesto Alfonso

unread,
Sep 3, 2020, 1:01:06 AM9/3/20
to Lars Ingebrigtsen, Eli Zaretskii, Juri Linkov, Stefan Kangas, Robert Pluim, 32...@debbugs.gnu.org
I currently work for Google, and my understanding is that Google has a special agreement with the FSF. Please let me know if this is correct or if I still need to provide a copyright assignment.

Also, I am not sure if this patch is still applicable.

Thanks,

Ernesto

Stefan Kangas

unread,
Sep 3, 2020, 6:41:07 AM9/3/20
to Ernesto Alfonso, Lars Ingebrigtsen, Robert Pluim, 32...@debbugs.gnu.org, Eli Zaretskii, Juri Linkov
Hi Ernesto,

Thanks for following up on this.

Ernesto Alfonso <erjo...@gmail.com> writes:

> I currently work for Google, and my understanding is that Google has a
> special agreement with the FSF. Please let me know if this is correct
> or if I still need to provide a copyright assignment.

Someone else will have to answer this.

> Also, I am not sure if this patch is still applicable.

In what way? From reading the discussion, it seems like the feature was
considered useful, but there were some additional comments before it was
ready. I copied in those comments below. Could you have a look at
them?

Thanks in advance.

Juri Linkov <ju...@linkov.net> writes:

>> I'd like to know if this patch is still being considered?
>
> Why not? Your patch provides a helpful feature. I see only 2 problems
> with its latest version:
>
> 1. compilation-current-error should be generalized not to be too
> compilation-specific;
>
> 2. next-error-hook should not be used for core features,
> you could call next-error-message-highlight directly
> from next-error-found.
>
> PS: maybe a better name for defcustom would be next-error-message-highlight,
> not next-error-message-highlight-p, to be more future-proof,
> for the case when someone might want to add more choices later
> (e.g. fringe, timers, etc.)

Best regards,
Stefan Kangas



Reply all
Reply to author
Forward
0 new messages