[patch] ui and i18n fixes

[Ananas]

patch with some ui and i18n fixes. and updated russian translation

--
wbr,

Victor "Ananas" Ananjevsky

[Shahar Evron]

Thanks Victor - I'll add it to my next commit!

Shahar.

[Ananas]

i'm sorry, in this patch, in glista.glade two extra lines - signal handlers for key press event. they don't need in this patch, i try to add some key-driven ability and forgot to cleanup snv tree before diff

2009/2/23 Shahar Evron <shahar...@gmail.com>

[Shahar Evron]

Ok, I'll clean it up before committing.

Thanks,

Shahar.

[Shahar Evron]

Hi,

Sorry, I was busy for a while.. I tried building with this patch but I get:

main.c: In function ‘main’:
main.c:1716: warning: implicit declaration of function ‘setlocale’
main.c:1716: error: ‘LC_ALL’ undeclared (first use in this function)
main.c:1716: error: (Each undeclared identifier is reported only once
main.c:1716: error: for each function it appears in.)
make[3]: *** [main.o] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Why are you calling setlocale to LC_ALL? (I don't have much experience with i18n...) in any case even if it is necessary I seem to be missing some header file?

Thanks,

Shahar.

[Ananas]

2009/3/3 Shahar Evron <shahar...@gmail.com>

Hi,

Sorry, I was busy for a while.. I tried building with this patch but I get:

main.c: In function ‘main’:
main.c:1716: warning: implicit declaration of function ‘setlocale’
main.c:1716: error: ‘LC_ALL’ undeclared (first use in this function)
main.c:1716: error: (Each undeclared identifier is reported only once
main.c:1716: error: for each function it appears in.)
make[3]: *** [main.o] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Why are you calling setlocale to LC_ALL? (I don't have much experience with i18n...) in any case even if it is necessary I seem to be missing some header file?

 LC_* defined in locale.h. just include this header. without calling setlocale() i get a strange behavior of translated command-line help. some parts of help text show in russian, other - in english.

Thanks,

Shahar.

On Mon, Feb 23, 2009 at 11:14 PM, Shahar Evron <shahar...@gmail.com> wrote:

Ok, I'll clean it up before committing.

Thanks,

Shahar.

On Mon, Feb 23, 2009 at 11:22 AM, Ananas <anan...@gmail.com> wrote:

i'm sorry, in this patch, in glista.glade two extra lines - signal handlers for key press event. they don't need in this patch, i try to add some key-driven ability and forgot to cleanup snv tree before diff

2009/2/23 Shahar Evron <shahar...@gmail.com>

Thanks Victor - I'll add it to my next commit!

Shahar.

On Fri, Feb 20, 2009 at 5:15 PM, Ananas <anan...@gmail.com> wrote:

patch with some ui and i18n fixes. and updated russian translation

--
wbr,

Victor "Ananas" Ananjevsky

--
wbr,

Victor "Ananas" Ananjevsky

[Shahar Evron]

On Thu, Mar 5, 2009 at 7:43 AM, Ananas <anan...@gmail.com> wrote:

2009/3/3 Shahar Evron <shahar...@gmail.com>

Hi,

Sorry, I was busy for a while.. I tried building with this patch but I get:

main.c: In function ‘main’:
main.c:1716: warning: implicit declaration of function ‘setlocale’
main.c:1716: error: ‘LC_ALL’ undeclared (first use in this function)
main.c:1716: error: (Each undeclared identifier is reported only once
main.c:1716: error: for each function it appears in.)
make[3]: *** [main.o] Error 1
make[2]: *** [all-recursive] Error 1
make[1]: *** [all-recursive] Error 1
make: *** [all] Error 2

Why are you calling setlocale to LC_ALL? (I don't have much experience with i18n...) in any case even if it is necessary I seem to be missing some header file?

 LC_* defined in locale.h. just include this header. without calling setlocale() i get a strange behavior of translated command-line help. some parts of help text show in russian, other - in english.

But is the interface translated?

Also, we can just drop the translation for the command line help in russian if it is not common to translate those messages (I dropped it from the Hebrew translation because it's terrible to have Hebrew in command line, nobody does that) but I know that in some other languages like Spanish or French it is acceptable to translate everything, including command line help and messages.

Shahar.
 

[Ananas]

2009/3/5 Shahar Evron <shahar...@gmail.com>

But is the interface translated?

yes. and i check once more - setlocale() really not need. gtk_init() call gtk_set_locale(), which does the same. a partial translation was because of NULL instead of GETTEXT_PACKAGE in gtk_init_with_args()
 

Also, we can just drop the translation for the command line help in russian if it is not common to translate those messages (I dropped it from the Hebrew translation because it's terrible to have Hebrew in command line, nobody does that) but I know that in some other languages like Spanish or French it is acceptable to translate everything, including command line help and messages.

Shahar.
 

[Shahar Evron]

So I can safely remove this line?

Shahar.

[Ananas]

2009/3/6 Shahar Evron <shahar...@gmail.com>

So I can safely remove this line?

yes
 

[Shahar Evron]

Hi,

I finally committed the patch :)
Thanks!

Shahar.