0.4 coming up soon

[shahar...@gmail.com]

Hi,

I plan to package and release Glista 0.4 within the next 24 - 48
hours.

Highlight features include:
- libunique support (if available) to detect single instance running
- notes support: can now add notes to an item (thanks jcinacio!)

There are also lots of bug fixes and several code organization / build
system improvements.

If there is anything else you want to put into 0.4, please let me know
asap.

Thanks,

Shahar.

[jcinacio]

Just remembered 2 small features (not really important for release):
- a switch to not show the window on first open, useful when running
glista on gnome session login
- a switch to expand all categories on first open (or make it
default?)

[jcinacio]

I had some time this evening to look at it, and got links feature is
fully working including re-parse on text edit/copy/paste, and opening
of the link.

I also tried to make it as clean as possible, which I think turned out
OK.

Please test it, IMHO it's in shape for 0.4 but you should be the one
to decide that.

See attached patch at http://code.google.com/p/glista/issues/detail?id=19


Regards,
Joao Inacio

[jcinacio]

updated regular expression for URL matching (allows www.<domain>, and
includes some special chars)

\b((http[s]?://|www.)[a-zA-Z0-9]+[a-zA-Z0-9$_+-*%~=.,:;/\?@&#()]*)

[jcinacio]

updated regex, I now officially need some sleep (8

\b((http[s]?://[a-zA-Z0-9]+[a-zA-Z0-9.-]*|www[.]+([a-zA-Z0-9-]+[.]+)+
[a-zA-Z]{2,})([/?#]+[^ \t\r\n]*)*)

[shahar]

Hi,

I didn't apply your patch directly, but took your code and implemented
the feature in a separate source file. I think this way it's cleaner,
and will also allow people to easily reuse this feature - perhaps in
the future we can even make a reusable library out of this.

Now people just need to call glista_textview_linkify_init(textview) to
linkify a text view.

I also made some nescesary changes to the build scripts (make sure
regex.h is available, and add an option to --disable-linkify-urls if
people want to).

Please take a look at r89 - it contains the change. If you think it
looks good, we can move on to release.

BTW I added some note to credit you - if you want something else to
show up there (like your name, home page or e-mail address) let me
know.

Regarding the other feature requests (the start-up switches) - please
add them as a feature request in the issue tracker.

Thanks,

Shahar.

[jcinacio]

Looks great, very nice work indeed, however:

- you noticed the issue opening urls without starting 'http[s]://', i
think it's easy enough to check for (and add) that prefix in
glista_open_url (something like g_str_has_prefix(url, 'http'))

- the url regex i added was a bit more complicated to handle strange
urls: try out for example "www.google.com,/?" - if i'm not mistaken,
anything past the tld should only be part of url if preceded by one
of ?,/ or #

- im getting a gtk warning on startup: "(glista:16223): Gtk-WARNING
**: Could not find signal handler 'on_glista_item_list_row_activated'"


Again, great work - it wont be easy to find new stuff to add/fix :)

[shahar]

Hi,

On Nov 8, 2:06 pm, jcinacio <jcina...@gmail.com> wrote:
> Looks great, very nice work indeed, however:
>
> - you noticed the issue opening urls without starting 'http[s]://', i
> think it's easy enough to check for (and add) that prefix in
> glista_open_url (something like g_str_has_prefix(url, 'http'))
>

It can be done - I just didn't have the time to handle that.

> - the url regex i added was a bit more complicated to handle strange
> urls: try out for example "www.google.com,/?" - if i'm not mistaken,
> anything past the tld should only be part of url if preceded by one
> of ?,/ or #

I will try to come up with a good regex. It's not easy though.

>
> - im getting a gtk warning on startup: "(glista:16223): Gtk-WARNING
> **: Could not find signal handler 'on_glista_item_list_row_activated'"
>

This function was renamed, and something in your build continues to
call it. Please do make clean or make distclean and try again.

> Again, great work - it wont be easy to find new stuff to add/fix :)

Thanks :)

Shahar.

[jcinacio]

On Nov 8, 3:24 pm, shahar <shahar.ev...@gmail.com> wrote:
>
> > - the url regex i added was a bit more complicated to handle strange
> > urls: try out for example "www.google.com,/?" - if i'm not mistaken,
> > anything past the tld should only be part of url if preceded by one
> > of ?,/ or #
>
> I will try to come up with a good regex. It's not easy though.
>

Yeah, complicated regular expressions are a real pain... either way
it's not a big issue, as in 99% of the cases the link should "just
work"

>
> > - im getting a gtk warning on startup: "(glista:16223): Gtk-WARNING
> > **: Could not find signal handler 'on_glista_item_list_row_activated'"
>
> This function was renamed, and something in your build continues to
> call it. Please do make clean or make distclean and try again.
>

Thanks, I was actually running it without install and it was picking
up the (older) installed .ui file

[jcinacio]

On Nov 8, 3:24 pm, shahar <shahar.ev...@gmail.com> wrote:

> Hi,
>
> On Nov 8, 2:06 pm, jcinacio <jcina...@gmail.com> wrote:
>
> > - the url regex i added was a bit more complicated to handle strange
> > urls: try out for example "www.google.com,/?" - if i'm not mistaken,
> > anything past the tld should only be part of url if preceded by one
> > of ?,/ or #
>
> I will try to come up with a good regex. It's not easy though.
>

By the way, I noticed you used the one in my patch, and I had
submitted an updated version that handles this issue - see post
http://groups.google.com/group/glista-dev/msg/0202639e433fcd7d?hl=en )

And sorry for the multiple submissions yesterday, it was a very long
day :)

[shahar]

Both issues are now fixed. I will continue playing with finding a
better URL regex - but as you said this one works 99% of the time so
it's good for now. An RFC-compliant regex would be pretty
unreadable :)

If you have some last minute issues, feel free to raise them - I will
probably be packaging 0.4 later today.

Shahar.