Discussion

[Federico Don]

Hi all,

I need the opinion of the group, you must implement code reviews with gerrit in gitorious? is this really necessary?

I hope your opinion!

Regards,

[Ken Dreyer]

On Fri, Jul 27, 2012 at 2:50 PM, Federico Don <federic...@gmail.com> wrote:
> I need the opinion of the group, you must implement code reviews with gerrit
> in gitorious? is this really necessary?
>
> I hope your opinion!

My preference would be to simply use merge requests for this purpose
because it is simpler. Gitorious' merge requests are very similar to
Gerrit. At that point it's simply a matter of policy.

As an example, Puppet Labs uses this process for doing code reviews at
GitHub. From Puppet's CONTRIBUTING.md:

> If you have commit access to the repository

> Even if you have commit access to the repository, you'll still need to
> go through the process above, and have someone else review and merge
> in your changes. The rule is that all changes must be reviewed by a
> developer on the project (that didn't write the code) to ensure that
> all changes go through a code review process.

> Having someone other than the author of the topic branch recorded as
> performing the merge is the record that they performed the code
> review.


Specific advantages to Gitorious's merge requests over Gerrit:
1. The workflow is already built into a single application.
2. Gitorious does not require you to configure a special commit hook,
and Gerrit does.
3. You can put multiple commits into a Gitorious merge request, but
Gerrit reviews are on a commit-by-commit basis.

- Ken