Newlines in Commit Messages

0 views
Skip to first unread message

Matt Todd

unread,
Mar 9, 2008, 3:15:28 AM3/9/08
to GitNub
I use them.

/sadface

Any plans on not changing them to spaces? It'd be fine to make the
first line big and just show the rest smallish.

Matt Todd

Justin Palmer

unread,
Mar 9, 2008, 3:33:00 PM3/9/08
to git...@googlegroups.com
I can't leave them in the source list (sidebar), it will break the application.  I can, however, leave them in the main view.  Which I think is still the case, right?  

Josh Knowles

unread,
Mar 9, 2008, 3:54:55 PM3/9/08
to git...@googlegroups.com
On 3/9/08, Justin Palmer <encyt...@gmail.com> wrote:
> I can't leave them in the source list (sidebar), it will break the
> application. I can, however, leave them in the main view. Which I think is
> still the case, right?

What if instead of turning them into spaces you just grabbed the first
line for the sidebar, then displayed the full message for the main
view. Common practice on lots of apps is to have the first line be a
short description, followed by a blank line, followed by a more
detailed list.

--
Josh Knowles
phone: 509-979-1593
email: joshk...@gmail.com
web: http://joshknowles.com

Justin Palmer

unread,
Mar 9, 2008, 3:58:36 PM3/9/08
to git...@googlegroups.com
That sounds like a good solution, Josh.  Can someone confirm that newlines are still working in the primary view?

Dustin

unread,
Mar 12, 2008, 9:57:54 PM3/12/08
to GitNub

I just submitted a change to my branch to deal with this (and *then*
found the forum).

http://github.com/dustin/gitnub/tree

I think <pre> might be a better approach, but it gets ugly rather
fast. Something like this, but with a fixed-width font would be
ideal, I think.

On Mar 9, 12:54 pm, "Josh Knowles" <joshknow...@gmail.com> wrote:
> On 3/9/08, Justin Palmer <encyteme...@gmail.com> wrote:
>
> > I can't leave them in the source list (sidebar), it will break the
> > application. I can, however, leave them in the main view. Which I think is
> > still the case, right?
>
> What if instead of turning them into spaces you just grabbed the first
> line for the sidebar, then displayed the full message for the main
> view. Common practice on lots of apps is to have the first line be a
> short description, followed by a blank line, followed by a more
> detailed list.
>
> --
> Josh Knowles
> phone: 509-979-1593
> email: joshknow...@gmail.com
> web: http://joshknowles.com
Reply all
Reply to author
Forward
0 new messages