Re: Added support for workitems

11 views
Skip to first unread message

Nodir Turakulov

unread,
Feb 24, 2012, 2:04:54 PM2/24/12
to git...@googlegroups.com
On Fri, Feb 24, 2012 at 6:43 AM, Bruno Berisso <goja...@gmail.com> wrote:
>
> I test 'git tf wi' today and it works fine. Perhaps the feedback of
> the command are a little poor, I was thinking something like:
>
> $git tf wi 1234
> Commit 5307bcb assosiated with workitem 1234

If it says nothing then everything is OK. "git notes add" works the same:
$ git notes add -m "my note"
$
No output here.

To see the workitems associated with the HEAD commit, just run `git tf wi`

> But this are details.
>
> Other more important detail. For some reason I don't have permissions
> over the workitem I choos to test so the checkin command return an
> exit status != 0 but the files were checked in. This produce a
> rollback for a commit that was successful.

tf is especially bad at exit codes. There is exit code "1" that means
"something went wrong", but does not specify what exactly:
http://blogs.msdn.com/b/richardb/archive/2007/09/25/tf-checkin-exit-codes.aspx

Okay, I'll allow it to exit with code 1 as long as there is a
"Changeset #\d+" string.

Next time, please provide the output. It must contain the exit code.

> Anyhow, the wi command work as expected and I'm really happy to have a
> complete tfs solution with git :)

Great!

-Nodir

P.S. I wish GitHub Flavored Markdown worked here...

Nodir Turakulov

unread,
Feb 25, 2012, 5:23:25 AM2/25/12
to git...@googlegroups.com
On Sat, Feb 25, 2012 at 12:04 AM, Nodir Turakulov <tura...@gmail.com> wrote:
> On Fri, Feb 24, 2012 at 6:43 AM, Bruno Berisso <goja...@gmail.com> wrote:
>> Other more important detail. For some reason I don't have permissions
>> over the workitem I choos to test so the checkin command return an
>> exit status != 0 but the files were checked in. This produce a
>> rollback for a commit that was successful.
>
> tf is especially bad at exit codes. There is exit code "1" that means
> "something went wrong", but does not specify what exactly:
> http://blogs.msdn.com/b/richardb/archive/2007/09/25/tf-checkin-exit-codes.aspx
>
> Okay, I'll allow it to exit with code 1 as long as there is a
> "Changeset #\d+" string.

I made it (94c93a0ea8b526bf7b8c027c0612b892d3c7c551)

-Nodir

P.S. Do you receive my messages? Just to make sure that mailing list works.

Reply all
Reply to author
Forward
0 new messages