Building the installer on Windows - git-add.exe does not exist?

[Tao Klerks]

Hi,

After building a custom version of git, I'm having a hard time understanding how to make it the "active" version of git in my windows machine/environment.

I assumed that the only "right" way is to build an installer, and run the installer...

However, when I try to build the installer ("sdk build installer", or " ./installer/release.sh 2.33-test", same outcome either way), I get the following error:
---

From https://github.com/git-for-windows/build-extra

 * branch            HEAD       -> FETCH_HEAD

Already up to date.

Generating release notes to be included in the installer ...

markdown is /usr/bin/markdown

Generating file list to be included in the installer ...

Launching Inno Setup compiler ...

Error on line 1202 in C:\git-sdk-64\usr\src\build-extra\installer\file-list.iss: Source file "C:\git-sdk-64\mingw64\libexec\git-core\git-add.exe" does not exist.

Compile aborted.

Could not make installer

---

Looking in "file-list.iss", I see that the file was indeed generated right before this error was returned - but I don't understand what's building that list, nor why it has an entry for a file that wasn't created by the git "make install" or "sdk build git"... 

Am I missing a step somewhere?

Thanks,

Tao

[Matthew Gaetano]

Anyone have any insight? At time of writing, version v2.36.1.windows.1, I can only generate an installer after SDK installation before attempting to build. Building does not seem to generate all the files necessary for the installer.

[Johannes Schindelin]

Hi Matthew,

On Tue, 7 Jun 2022, Matthew Gaetano wrote:

> Anyone have any insight? At time of writing, version v2.36.1.windows.1, I
> can only generate an installer after SDK installation before attempting to
> build. Building does not seem to generate all the files necessary for the
> installer.

This is tracked in https://github.com/git-for-windows/git/issues/3888, and
yes, it is a bug ;-)

Let's continue the discussion over there.

Thanks,
Johannes

> --
> You received this message because you are subscribed to the Google Groups "git-for-windows" group.
> To unsubscribe from this group and stop receiving emails from it, send an email to git-for-windo...@googlegroups.com.
> To view this discussion on the web visit https://groups.google.com/d/msgid/git-for-windows/acbc9256-e110-48aa-93a0-4a88ce8a139fn%40googlegroups.com.
>