libcurl-4.dll issues with 2.14 packages

[Vladimir Vukicevic]

I'm running into an issue with the 2.14 msys2 packages from https://bintray.com/git-for-windows/pacman/mingw-w64-x86_64-git -- all of the 2.14 releases have an import of "curl_global_sslset" from libcurl-4.dll; 2.13 and earlier do not.  No libcurl-4.dll that I can find exports that symbol; e.g. the latest mingw64/mingw-w64-x86_64-curl 7.55.1-2.  Even the curl from straight from the repo at https://dl.bintray.com/git-for-windows/pacman/x86_64/ is missing this symbol.

Is this just a missing export definition in libcurl?  This makes the 2.14 packages unable to do anything that links with libcurl, such as use http/https remotes.

    - Vlad

[Johannes Schindelin]

Hi Vlad,

On Tue, 5 Sep 2017, Vladimir Vukicevic wrote:

> I'm running into an issue with the 2.14 msys2 packages from
> https://bintray.com/git-for-windows/pacman/mingw-w64-x86_64-git -- all of
> the 2.14 releases have an import of "curl_global_sslset" from
> libcurl-4.dll; 2.13 and earlier do not. No libcurl-4.dll that I can find
> exports that symbol; e.g. the latest mingw64/mingw-w64-x86_64-curl
> 7.55.1-2. Even the curl from straight from the repo at
> https://dl.bintray.com/git-for-windows/pacman/x86_64/ is missing this
> symbol.

Git for Windows' variant of libcurl-4.dll defines that symbol as of
version 7.55.0.

MSYS2's mingw-w64-curl packages do not have that symbol.

Maybe you got confused because `nm.exe` does not report that symbol when
looking at /mingw64/bin/libcurl-4.dll? It does not report any curl symbol.
Only when you look at /mingw64/lib/libcurl.dll.a.

> Is this just a missing export definition in libcurl? This makes the
> 2.14 packages unable to do anything that links with libcurl, such as use
> http/https remotes.

Maybe you have a stale /mingw64/libexec/git-core/libcurl-4.dll in your
installation. Otherwise it should work. It does here.

Ciao,
Johannes

[Vladimir Vukicevic]

On Wed, Sep 6, 2017 at 9:17 AM Johannes Schindelin <Johannes....@gmx.de> wrote:

Hi Vlad,

Thanks for the quick reply, Johannes!

 

On Tue, 5 Sep 2017, Vladimir Vukicevic wrote:

> I'm running into an issue with the 2.14 msys2 packages from
> https://bintray.com/git-for-windows/pacman/mingw-w64-x86_64-git -- all of
> the 2.14 releases have an import of "curl_global_sslset" from
> libcurl-4.dll; 2.13 and earlier do not.  No libcurl-4.dll that I can find
> exports that symbol; e.g. the latest mingw64/mingw-w64-x86_64-curl
> 7.55.1-2.  Even the curl from straight from the repo at
> https://dl.bintray.com/git-for-windows/pacman/x86_64/ is missing this
> symbol.

Git for Windows' variant of libcurl-4.dll defines that symbol as of
version 7.55.0.

Ah, ok, this is the problem -- I had the wrong package from the git-for-windows repo.  https://dl.bintray.com/git-for-windows/pacman/x86_64/mingw-w64-x86_64-curl-7.55.1-1-any.pkg.tar.xz indeed exports the symbol.  However, msys2 is already shipping an identically-named package, but with version 7.55.1-2: mingw-w64-x86_64-curl-7.55.1-2 so any system-wide upgrades will override the git-for-windows one.  It's unfortunate that this is not the same package -- is upstream msys2 unwilling to build with the required curl options/patch?  At least some indication that the git-for-windows package is different than the msys one would be useful.

   - Vlad

[Johannes Schindelin]

Hi Vlad,

On Wed, 6 Sep 2017, Vladimir Vukicevic wrote:

> On Wed, Sep 6, 2017 at 9:17 AM Johannes Schindelin <
> Johannes....@gmx.de> wrote:
>
> > On Tue, 5 Sep 2017, Vladimir Vukicevic wrote:
> >
> > > I'm running into an issue with the 2.14 msys2 packages from
> > > https://bintray.com/git-for-windows/pacman/mingw-w64-x86_64-git --
> > > all of the 2.14 releases have an import of "curl_global_sslset" from
> > > libcurl-4.dll; 2.13 and earlier do not. No libcurl-4.dll that I can
> > > find exports that symbol; e.g. the latest
> > > mingw64/mingw-w64-x86_64-curl 7.55.1-2. Even the curl from straight
> > > from the repo at
> > > https://dl.bintray.com/git-for-windows/pacman/x86_64/ is missing
> > > this symbol.
> >
> > Git for Windows' variant of libcurl-4.dll defines that symbol as of
> > version 7.55.0.
>
> Ah, ok, this is the problem -- I had the wrong package from the
> git-for-windows repo.
> https://dl.bintray.com/git-for-windows/pacman/x86_64/mingw-w64-x86_64-curl-7.55.1-1-any.pkg.tar.xz
> indeed exports the symbol.

Good.

> However, msys2 is already shipping an identically-named package, but
> with version 7.55.1-2: mingw-w64-x86_64-curl-7.55.1-2 so any system-wide
> upgrades will override the git-for-windows one. It's unfortunate that
> this is not the same package -- is upstream msys2 unwilling to build
> with the required curl options/patch? At least some indication that the
> git-for-windows package is different than the msys one would be useful.

With cURL, Git for Windows required more frequent, and more immediate
updates than MSYS2 can be reasonably asked to provide. So yes, Git for
Windows' SDK and MSYS2 diverge there.

I had missed the release of 7.55.1-2 by MSYS2, will have to release
another version in Git for Windows' Pacman repository to fix that.

Ciao,
Johannes

[Johannes Schindelin]

Hi Vlad,

On Thu, 7 Sep 2017, Johannes Schindelin wrote:

> On Wed, 6 Sep 2017, Vladimir Vukicevic wrote:
>
> > However, msys2 is already shipping an identically-named package, but
> > with version 7.55.1-2: mingw-w64-x86_64-curl-7.55.1-2 so any
> > system-wide upgrades will override the git-for-windows one. It's
> > unfortunate that this is not the same package -- is upstream msys2
> > unwilling to build with the required curl options/patch? At least
> > some indication that the git-for-windows package is different than the
> > msys one would be useful.

Actually, I fail to have MSYS2 shadow Git for Windows'
mingw-w64-x86_64-curl version. Are you another user trying to install Git
for Windows' mingw-w64-git package into a plain MSYS2 environment?

I ask because I actually have already quite enough on my plate trying to
support Git for Windows' users and developers using Git for Windows' SDK
to contribute.

Ciao,
Johannes

[Vladimir Vukicevic]

(Sorry, just remembered I hadn't replied to this!)

On Thu, Sep 7, 2017 at 8:46 AM Johannes Schindelin <Johannes....@gmx.de> wrote:

> On Wed, 6 Sep 2017, Vladimir Vukicevic wrote:
> > However, msys2 is already shipping an identically-named package, but
> > with version 7.55.1-2: mingw-w64-x86_64-curl-7.55.1-2 so any
> > system-wide upgrades will override the git-for-windows one.  It's
> > unfortunate that this is not the same package -- is upstream msys2
> > unwilling to build with the required curl options/patch?  At least
> > some indication that the git-for-windows package is different than the
> > msys one would be useful.

Actually, I fail to have MSYS2 shadow Git for Windows'
mingw-w64-x86_64-curl version. Are you another user trying to install Git
for Windows' mingw-w64-git package into a plain MSYS2 environment?

I am indeed.  I know there are underlying (still-unresolved) runtime issues, but I've been doing it for over a year now with no problems.

 

I ask because I actually have already quite enough on my plate trying to
support Git for Windows' users and developers using Git for Windows' SDK
to contribute.

Definitely understandable.  It's just unfortunate that in this situation it's a weird non-obvious failure with no indication that a package was changed either :)  But it seems like it's a known problem and not much can be done easily; hopefully if the runtime changes ever make it in to msys2 this will all become simpler.  Or we'll all switch to WSL anyway :)

    - Vlad