unattended install problem, puts icons in c:\windows\system32\config\systemprofile\appdata\roaming

311 views
Skip to first unread message

Paul McGrath

unread,
Dec 3, 2015, 10:13:22 AM12/3/15
to git-for-windows
Hi,
  I use WPKG to silently deploy hundreds of apps to my departmental computers.
The Git for Windows installer is innosetup and the silent switches are /VERYSILENT

WPKG installs as 'localsystem' in the background so is putting the start menu icons in
c:\windows\system32\config\systemprofile\appdata\roaming\microsoft\windows\start menu\programs\git

instead of
c:\programdata\microsoft\windows\start menu\programs\git

Having compiled some Innosetup packages myself it is because the icons are not being put in {commonprograms} but some other location.  Also the outputdir value is OutputDir={#GetEnv('USERPROFILE')}

There is also an issue with the install values as it is not showing up in control panel programs

It all works fine as a test if I run as a local user in silent mode.  This problem just exists run as localsystem.

Surely this happens too with SCCM?

I am using the latest 2.6.3 installer.

Looking at the install.iss file referenced here


This is the icon section

[Icons]
Name: {group}\Git GUI; Filename: {app}\bin\wish.exe; Parameters: """{app}\libexec\git-core\git-gui"""; WorkingDir: %HOMEDRIVE%%HOMEPATH%; IconFilename: {app}\etc\git.ico
Name: {group}\Git Bash; Filename: {syswow64}\cmd.exe; Parameters: "/c """"{app}\bin\sh.exe"" --login -i"""; WorkingDir: %HOMEDRIVE%%HOMEPATH%; IconFilename: {app}\etc\git.ico; OnlyBelowVersion: 6.0
Name: {group}\Git Bash; Filename: {app}\bin\sh.exe; Parameters: "--login -i"; WorkingDir: %HOMEDRIVE%%HOMEPATH%; IconFilename: {app}\etc\git.ico; MinVersion: 6.0

I don't mean to disrespect your work but it seems to focus on local users only.

Paul

Chris D'Hondt

unread,
Dec 4, 2015, 8:28:13 AM12/4/15
to git-for-windows
I'm also trying to install Git remotely and it seems like the installers are only built with local user installs in mind.

1) PrivilegesRequired=lowest is set in install.iss, which forces the uninstall information get put in HKEY_CURRENT_USER and common shell folders to map to the local user equivalent.
2) Trying to push the install to a remote system with nobody logged on results in a error saying it couldn't find localappdata and the installer hangs (see issue 1).

Are there any plans to make installers that are more deployment friendly?

Chris

Johannes Schindelin

unread,
Dec 4, 2015, 8:47:31 AM12/4/15
to Chris D'Hondt, git-for-windows
Hi Chris,

On Thu, 3 Dec 2015, Chris D'Hondt wrote:

> Are there any plans to make installers that are more deployment friendly?

Anything you can do in terms of Pull Requests will be very welcome.

Ciao,
Johannes

Johannes Schindelin

unread,
Dec 4, 2015, 8:49:05 AM12/4/15
to Paul McGrath, git-for-windows
Hi Paul,

On Thu, 3 Dec 2015, Paul McGrath wrote:

> Also the outputdir value is OutputDir={#GetEnv('USERPROFILE')}

That specifies where InnoSetup will store the file when I generate it. So
this setting is correct.

As pointed out by Chris in his reply, the issue you see is due to
PrivilegesRequired=lowest, which I had fixed in the meantime already.

Ciao,
Johannes
Reply all
Reply to author
Forward
0 new messages