Code review notes

19 views
Skip to first unread message

Jeff Lindsay

unread,
May 6, 2012, 4:13:26 AM5/6/12
to ginkg...@googlegroups.com
We did a code review and discussion of master here at Twilio as of Thursday. Here are some takeaway items I'll be making issues for:

* Remove module main section of config.py. Use it in tests
* Update examples to latest API. Remove bad examples
* Add module level docstrings
* Don't hardcode pid/log files into /tmp
* Only make a pidfile when daemonizing
* Sanity check configuration when reloading
* Add pre-wrapped gevent servers in async.gevent module
* Add configuration context manager (similar to Process)
* Include examples on how to test apps in docs

And otherwise I'm still working on docs and tests. 

--
Jeff Lindsay
http://progrium.com
Reply all
Reply to author
Forward
0 new messages