Proposed document for new theming system

38 views
Skip to first unread message

Dennis Murphy

unread,
Sep 12, 2012, 2:01:47 PM9/12/12
to ggplot2-dev, Hadley Wickham, Winston Chang
Greetings:

The attachment is a document written in R Markdown pertaining to the new theming system that debuted in version 0.9.2. I would appreciate if you would take the time to read it and to provide some feedback, including how it could be improved. New examples, pointing out omissions or errors, etc. would be welcome. For now I'm just making the HTML file available, but eventually the source will be posted on Github so that others can contribute. Private posts or replies here are both fine.

Have at it and hope you find it useful,
Dennis
theme0.html

Brandon Hurr

unread,
Sep 12, 2012, 4:53:00 PM9/12/12
to Dennis Murphy, ggplot2-dev, Hadley Wickham, Winston Chang
It's really great Dennis. I just used it to solve an issue in the main group even...

Two things: 

1. Sometimes you use other packages. You even mention that you'd need to load grid to use unit, but then don't include require(grid) in your code sample, which then fails. 

This happened to me again when I needed gridExtra later on. 

2. I forgot what 2 is, but it's nice to have more than one thing isn't it? 

Brandon

Dennis Murphy

unread,
Sep 13, 2012, 12:01:10 AM9/13/12
to Brandon Hurr, ggplot2-dev
Hi Brandon:

Thanks. I pre-loaded about a half-dozen packages: devtools, ggplot2, scales, gtable, grid, gridExtra and igraph (for the inheritance graph). Now that 0.9.2 is out, devtools isn't really necessary anymore. I hid that code chunk at the beginning but it's easy to make it visible. 

Dennis

Brandon Hurr

unread,
Sep 20, 2012, 9:12:55 AM9/20/12
to Dennis Murphy, ggplot2-dev
One more comment. This is something I never did when I made the wiki pages. It's great to have the default values... but it'd be nice to know what the acceptable values are, especially for things that are restricted like face, "plain", "bold", "italic"... is there a bold italic too? For something like vjust it would be nice to clarify what good units are (-1:1) or what they are relative to. A guy had something today where the vjust was 4.3 and I couldn't find the label until I adjusted it to 1 and realized that it was plotting it, but way off the plot! 

It's a pretty long document though, so I'm not sure how appropriate this would or wouldn't be. 

Brandon

Brandon Hurr

unread,
Oct 17, 2012, 7:57:23 AM10/17/12
to Dennis Murphy, ggplot2-dev
Other than in this email, is the theme_*() document hosted online somewhere? 

Brandon
Reply all
Reply to author
Forward
0 new messages