Re: [gephi-dev] Catch blank nodes during import?

[Mathieu Bastian]

Hi Dave,

Please go ahead with the pull request. Once we're done, we will run the
script to transfer that to Transifex, where the message will be translated.


On Sat, Jan 19, 2013 at 10:02 AM, Dave Shepard <shepar...@gmail.com>wrote:

> Sorry to bring this again, but I came up with a patch for this error, and
> it involves adding an error message. I added it to the Bundle.properties
> file, but should I worry about getting that translated before I create a
> pull request? Or should I just create a pull request?
>
>
> On Thu, Dec 27, 2012 at 2:57 PM, Dave Shepard <shepar...@gmail.com>wrote:
>
>> Thanks! I've come up with a patch, but I haven't committed it because it
>> involved adding an error message
>> to DataLaboratoryPlugin/src/main/resources/org/gephi/datalab/plugin/manipulators/general/ui/Bundle.properties.
>> What's the procedure for adding translations of that message? I don't think
>> I can do the translation myself, sorry.
>>
>>
>> On Tue, Dec 25, 2012 at 10:52 PM, Mathieu Bastian <
>> mathieu...@gmail.com> wrote:
>>
>>> We don't have plans to fix this in the short term. I'll make sure it's
>>> in the 0.9 roadmap however. Patch greatly appreciated!
>>>
>>> Mathieu
>>>
>>>
>>> On Mon, Dec 17, 2012 at 7:04 PM, Dave Shepard <shepar...@gmail.com>wrote:
>>>
>>>> Hi Mathieu,
>>>>
>>>> You're right--that's how I did it. Is merging the two file importers
>>>> something that is going to be done after 0.8.2? If so, I'll work on a
>>>> patch.
>>>>
>>>> Dave
>>>>
>>>>
>>>> On Mon, Dec 17, 2012 at 2:54 AM, Mathieu Bastian <
>>>> mathieu...@gmail.com> wrote:
>>>>
>>>>> Hi Dave,
>>>>>
>>>>> Yes I agree that should not be allowed. We have a good error system in
>>>>> importers that can create critical errors (as well as warning and info) and
>>>>> refuse to import the file. We add new rules as we discover them. However, I
>>>>> think this system is only for the importers in 'File > Import'. Eduardo can
>>>>> confirm. You probably used the CSV importer from the Data Laboratory. We
>>>>> plan to merge the two different importers at some point. If you have a
>>>>> patch, happy to merge it. Thanks.
>>>>>
>>>>> Mathieu
>>>>>
>>>>> On Sat, Dec 15, 2012 at 1:03 AM, Dave Shepard <shepar...@gmail.com
>>>>> > wrote:
>>>>>
>>>>>> I have a CSV edge list file which looks something like this:
>>>>>>
>>>>>> Source,Target,Weight
>>>>>> node1,node2,1
>>>>>> ,,node3,3
>>>>>> node3,node2,3
>>>>>> ...
>>>>>>
>>>>>> Obviously, there's an error on line 3: two consecutive commas and
>>>>>> only one
>>>>>> node. When I imported the file into Gephi, Gephi created a node with
>>>>>> the id
>>>>>> "" and considered that a valid node. I didn't notice it until I tried
>>>>>> to
>>>>>> export the graph as SVG, which threw a NullPointerException that was
>>>>>> hard
>>>>>> to pin down (I had 11000 nodes). Once I deleted the "" node, I could
>>>>>> export
>>>>>> the file normally.
>>>>>>
>>>>>> Would it make sense for the CSV import to detect invalid edges and
>>>>>> nodes
>>>>>> during CSV import and warn the user about them? I'm happy to
>>>>>> contribute a
>>>>>> patch for this, but I wanted to mention it here first in case there's
>>>>>> a
>>>>>> specific reason for this behavior.
>>>>>>
>>>>>> --
>>>>>> David Shepard
>>>>>> Visiting Assistant Professor, Digital Humanities
>>>>>> UCLA
>>>>>> _______________________________________________
>>>>>> gephi-dev mailing list
>>>>>> geph...@lists.gephi.org
>>>>>> http://gephi.org/mailman/listinfo/gephi-dev
>>>>>>
>>>>>
>>>>>
>>>>
>>>>
>>>> --
>>>> David Shepard
>>>> Visiting Assistant Professor, Digital Humanities
>>>> UCLA
>>>>
>>>
>>>
>>
>>
>> --
>> David Shepard
>> Visiting Assistant Professor, Digital Humanities
>> UCLA
>>
>
>
>
> --
> David Shepard
> Visiting Assistant Professor, Digital Humanities
> UCLA
>

[Mathieu Bastian]

[Mathieu Bastian]

We don't have plans to fix this in the short term. I'll make sure it's in
the 0.9 roadmap however. Patch greatly appreciated!

Mathieu

On Mon, Dec 17, 2012 at 7:04 PM, Dave Shepard <shepar...@gmail.com>wrote:

> Hi Mathieu,
>
> You're right--that's how I did it. Is merging the two file importers
> something that is going to be done after 0.8.2? If so, I'll work on a
> patch.
>
> Dave
>
>
> On Mon, Dec 17, 2012 at 2:54 AM, Mathieu Bastian <
> mathieu...@gmail.com> wrote:
>