branch spatialite_views

18 views
Skip to first unread message

Mark Johnson

unread,
Apr 17, 2014, 5:14:58 AM4/17/14
to geopapara...@googlegroups.com
I have worked through this code and commit the changes made up to now.

I will try to merge this with the master and start the testing.

No doubt there will be fine tuning to do, but maybe a 'pull request' can be made next week.

A description of
- the sql used
- the process of who does what while reading
- the test databases I intend to use to test
-- and the problems that the  code should resolve

can be found here:

https://github.com/mj10777/Spatialite-Tasks-with-Sql-Scripts/wiki#geopaparazzi-specific

This is the repository mentioned here:

https://groups.google.com/forum/#!topic/geopaparazzi-devel/i4G3RgX5mnA

I still thing that it would be a good idea to incorporate (i.e. move it) into the geopaparazzi.eu repository.

Mark Johnson

andrea antonello

unread,
Apr 19, 2014, 3:24:59 AM4/19/14
to geopapara...@googlegroups.com
Hi Mark,

> I have worked through this code and commit the changes made up to now.
>
> I will try to merge this with the master and start the testing.

could you try to merge it with the nf_gps_service branch instead. It
will get merged into master as soon as testing passes in order to get
a new release out, which is really urgent.

> No doubt there will be fine tuning to do, but maybe a 'pull request' can be
> made next week.
>
> A description of
> - the sql used
> - the process of who does what while reading
> - the test databases I intend to use to test
> -- and the problems that the code should resolve
>
> can be found here:
>
> https://github.com/mj10777/Spatialite-Tasks-with-Sql-Scripts/wiki#geopaparazzi-specific
>
> This is the repository mentioned here:
>
> https://groups.google.com/forum/#!topic/geopaparazzi-devel/i4G3RgX5mnA
>
> I still thing that it would be a good idea to incorporate (i.e. move it)
> into the geopaparazzi.eu repository.

I completely agree on that. That documentation will be really good to
have and extend with time.

Thanks,
Andrea




>
> Mark Johnson
>
> --
> You received this message because you are subscribed to the Google Groups
> "geopaparazzi-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to geopaparazzi-de...@googlegroups.com.
> For more options, visit https://groups.google.com/d/optout.

Mark Johnson

unread,
Apr 19, 2014, 5:38:46 AM4/19/14
to geopapara...@googlegroups.com


On Saturday, 19 April 2014 09:24:59 UTC+2, andrea antonello wrote:
Hi Mark,

> I have worked through this code and commit the changes made up to now.
>
> I will try to merge this with the master and start the testing.

could you try to merge it with the nf_gps_service branch instead. It
will get merged into master as soon as testing passes in order to get
a new release out, which is really urgent.
To late for that, did it yesterday and had conficts

> No doubt there will be fine tuning to do, but maybe a 'pull request' can be
> made next week.
I have just committed that does all the desired tasks, including
- creating a SpatialIndex for geometries without on
--- which the 2.4 versions mostly do not have - since SpatialIndex was introduced in 3.0

All of the known errors are being resolved
- which means that a missing 'UpdateLayerStatistics' or a needed 'RecoverSpatialIndex'
- is done ONCE, after which the database can be considered repaired

There is only now 'collectVectorTables' in SpatialiteDatabaseHandler
- the pre-Spatialite4 has been removed

I adapted
- createDefaultPropertiesForTable and getStyle4Table
- to set the default Label to the first TEXT field, which is known to SpatialVectorTable at that point

Also checkAndUpdatePropertiesUniqueNames() runs AFTER DaoSpatialite.checkDatabaseTypeAndValidity
- after the validity check (are there any geometries at all that are valid)

In the next day I will test this further and complete the documentation
- with pictures of the 2.4 Databases include the SpatialView

Mark

>
> A description of
> - the sql used
> - the process of who does what while reading
> - the test databases I intend to use to test
> -- and the problems that the  code should resolve
>
> can be found here:
>
> https://github.com/mj10777/Spatialite-Tasks-with-Sql-Scripts/wiki#geopaparazzi-specific
>
> This is the repository mentioned here:
>
> https://groups.google.com/forum/#!topic/geopaparazzi-devel/i4G3RgX5mnA
>
> I still thing that it would be a good idea to incorporate (i.e. move it)
> into the geopaparazzi.eu repository.

I completely agree on that. That documentation will be really good to
have and extend with time.
I do that tomorrow

Thanks,
Andrea




>
> Mark Johnson
>
> --
> You received this message because you are subscribed to the Google Groups
> "geopaparazzi-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an

Mark Johnson

unread,
Apr 20, 2014, 5:48:35 AM4/20/14
to geopapara...@googlegroups.com


On Saturday, 19 April 2014 09:24:59 UTC+2, andrea antonello wrote:
Hi Mark,

> I have worked through this code and commit the changes made up to now.
>
> I will try to merge this with the master and start the testing.

could you try to merge it with the nf_gps_service branch instead. It
will get merged into master as soon as testing passes in order to get
a new release out, which is really urgent.
spatial_view is now based on nf_gps_service
- there were no conflicts while merging

This must be tested, so I would get this into the next version.
The repository has been moved, but I need writing permission to upload.
- edit of pages work (Test db page has been updated with the results, but the images must be uploaded)

Mark

> No doubt there will be fine tuning to do, but maybe a 'pull request' can be
> made next week.
>
> A description of
> - the sql used
> - the process of who does what while reading
> - the test databases I intend to use to test
> -- and the problems that the  code should resolve
>
> can be found here:
>
> https://github.com/mj10777/Spatialite-Tasks-with-Sql-Scripts/wiki#geopaparazzi-specific
>
> This is the repository mentioned here:
>
> https://groups.google.com/forum/#!topic/geopaparazzi-devel/i4G3RgX5mnA
>
> I still thing that it would be a good idea to incorporate (i.e. move it)
> into the geopaparazzi.eu repository.

I completely agree on that. That documentation will be really good to
have and extend with time.

Thanks,
Andrea




>
> Mark Johnson
>
> --
> You received this message because you are subscribed to the Google Groups
> "geopaparazzi-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an

andrea antonello

unread,
Apr 23, 2014, 3:52:33 AM4/23/14
to geopapara...@googlegroups.com
>> could you try to merge it with the nf_gps_service branch instead. It
>> will get merged into master as soon as testing passes in order to get
>> a new release out, which is really urgent.
>
> spatial_view is now based on nf_gps_service
> - there were no conflicts while merging

Great, thanks.

> This must be tested, so I would get this into the next version.

Ok, good so. I found a small bug in loading *.map files and their tree
view. I still have to check it out and would like to add more debug
messages in case of errors.
Then it will be a good moment to add the view part.

> The repository has been moved, but I need writing permission to upload.
> - edit of pages work (Test db page has been updated with the results, but
> the images must be uploaded)

Done right now. Let me know if there are problems.

Andrea
>> > email to geopaparazzi-de...@googlegroups.com.
>> > For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups
> "geopaparazzi-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an
> email to geopaparazzi-de...@googlegroups.com.

Mark Johnson

unread,
Apr 23, 2014, 8:20:53 AM4/23/14
to geopapara...@googlegroups.com


On Wednesday, 23 April 2014 09:52:33 UTC+2, andrea antonello wrote:
>> could you try to merge it with the nf_gps_service branch instead. It
>> will get merged into master as soon as testing passes in order to get
>> a new release out, which is really urgent.
>
> spatial_view is now based on nf_gps_service
> - there were no conflicts while merging

Great, thanks.

> This must be tested, so I would get this into the next version.

Ok, good so. I found a small bug in loading *.map files and their tree
view. I still have to check it out and would like to add more debug
messages in case of errors.
Then it will be a good moment to add the view part.
This should be test on other machines

> The repository has been moved, but I need writing permission to upload.
> - edit of pages work (Test db page has been updated with the results, but
> the images must be uploaded)

Done right now. Let me know if there are problems.
yes, it works now

Do pages like this make sense in explaining the
- how, why and for what porpoise  these commands are used for?

https://github.com/geopaparazzi/Spatialite-Tasks-with-Sql-Scripts/wiki/ST_SplitLeft--Right

Mark

 
>> > For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups
> "geopaparazzi-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an

Mark Johnson

unread,
Apr 23, 2014, 8:30:31 AM4/23/14
to geopapara...@googlegroups.com


On Wednesday, 23 April 2014 09:52:33 UTC+2, andrea antonello wrote:
>> could you try to merge it with the nf_gps_service branch instead. It
>> will get merged into master as soon as testing passes in order to get
>> a new release out, which is really urgent.
>
> spatial_view is now based on nf_gps_service
> - there were no conflicts while merging

Great, thanks.

> This must be tested, so I would get this into the next version.

Ok, good so. I found a small bug in loading *.map files and their tree
view. I still have to check it out and would like to add more debug
messages in case of errors.
Then it will be a good moment to add the view part.

I just remember, I had reset this parameter to 0

    // Mode Types: 0=strict ; 1=tolerant ; 2=corrective ; 3=corrective with CreateSpatialIndex
    public static int VECTOR_LAYERS_QUERY_MODE=0;

set it to 3 for it to make correction.

We should consider a application parameter for this
- once the corrections are made it can be reset to 0.
-- there are some conditions, like empty fields, which can be checked beforehand if really needed
--- so even if it fails, with 3 it will attempt to correct it
--- with a lot of test database that i have, this can be time consuming
with 0 it would skip all the checking


 
>> > For more options, visit https://groups.google.com/d/optout.
>
> --
> You received this message because you are subscribed to the Google Groups
> "geopaparazzi-devel" group.
> To unsubscribe from this group and stop receiving emails from it, send an

Mark Johnson

unread,
Apr 25, 2014, 10:54:27 AM4/25/14
to geopapara...@googlegroups.com
Reply all
Reply to author
Forward
0 new messages