Tweaks and enhancements (2nd try)

[Ville]

Hi again.
It's been a while... Anyway, last summer I made some changes (quite a
few actually) which never made it to the repository then. So I still
have them laying around and was thinking about committing them. They
didn't make many conflicts with recent changes. So here's the change
notes from earlier post as a reminder:

- Some ui-preferences (Settings in the settings-menu, defaults are
as
they function now.)
- Disable opening of Radar on click to compass (Since I don't
really
use Radar, it's been pain in the arse when it opens by accident when
touching the screen to keep the screen alive. I'm also planning to add
a
Show radar menuitem so you can access Radar without enabling the tap-
open.)
- Wakelock for Compass (Related to the rant above. While I'm using
the compass, I generally want it to stay awake.)
- Hide icon labels from tabs (They're good for beginners but kinda
useless once you know the tabs)

- I Played a round with RelativeLayouts. I watched some google
android
debugging tools video some time ago and they went on about how it
would
be better to have one RelativeLayout than many nested LinearLayouts.
Apparently they're supposed to render faster or something.
So I refactored the list-item view-element to a single RelativeLayout
loosing a couple of LinearLayouts.

These are not very well tested, but I haven't run into any problems
with them. Would ppl be willing to test these out, if I commit them
and if Anders makes a test build?

Ville

[Anders Petersson]

Hi Ville and welcome back :)

Your changes seem alright with me. I prefer if you feel reasonably confident the changes work before you commit them. You can use them on your own phone, right?

One more thing, if you can divide the changes into a few independent commits instead of a single, disparate one it's a good thing. If that's a lot of work, it's alright anyway.

/Anders

PS

Maybe it's possible to detect automatically if the radar app is installed? Then we wouldn't need another settings item for it.

[Ville]

Hi. Thanks =)

I'll see if I can split the commit somehow reasonably. It was kinda dum to make so many changes in the first place but that was then.

Yes, I've tested them little in my phone and in fact found a bug in the search... for some reason it works fine when I test it home but when I'm on the field it highlights wrong caches. I think it has something to do with how the cache list is reordered when the distances change. I'll have to try and sort it out. It's kinda hard to debug tho since I haven't been able to recreate it home, but we'll see.

About the radar... I do have it installed, I just don't like to use it with GeoHunter... I rather use the MapView for the same purpose. But it's little pain in the ass when I accidentally touch the compass and it goes to the radar. Takes time to get back and it goes to list view etc... So I'd rather have that option ;) Of course if nobody else uses it, I may include it in my special build and leave it out from the commit.

Ville

[Theodore K. Milbaugh]

If you accidentally hit the screen in compass view and get to Radar,
all you have to do is hit your phone's "back" button once and you are
back on the compass screen. It works that way for me on Motorola
Droid.

[Ville]

I have an age old G1 and it takes ages to get back from radar, and when
it does, it's in the list view. But it might be just personal penalty...
Should get me a new phone anyway ;)

Ville

[Anders Petersson]

To debug the list selection issue, you can simulate being at different places and being in motion by editing 
org.geohunter.GeoFixProviderDI to enable a GeoFixProviderFake (or make your own). This sends fake location updates to the rest of the app instead of using the GPS.
/Anders

[Ville]

Hmm, in my op, I forgot to mention the search... which is kinda big
part of the comming commit... and where I thought I found the bug.
Anyway I wasn't able to reproduce it. Neither with emulator nor in
device. So I don't really know what was going on. Other than that all
changes seemed to work just fine.

I try and split the changes the best I can and commit tonight.

Ville

[Ville]

Ok, there goes.

Hope I didn't break anything. I divided it to three commits:
layout-optimization, search and preferences. There was some changes to
src/org/geohunter/activity/main/MainActivity.java for both search and
preferences, so if some reverts or like are needed, that needs to be
considered.

Ville