Heron Github - best practice?

[wolfram.winter]

Hi Just,
I've expanded our geoviewer app with the GXP layer toolbar (like the catalognl demo) - therefore I've checked (nearly) all upcoming windows for a correct i18n language display (english / german). Now I've updated two Heron i18n files (en_EN.js, de_DE.js) and three GXP modules (AddLayers.js, en.js, de.js).
Whats the best practice to get it in your nightly build on Github? Can we change the GXP source - the original code isn't changed for years?
Best
Wolfram

[Just van den Broecke]

Hi Wolfram,

The Heron GXP version is synced as a GitHub submodule with
https://github.com/justb4/gxp to be able to extend functionalities to be
donated back in to the GXP master and to be resilient of "big changes"
there. In practice not all Heron's changes (like the Vector Style
Editor) have been merged back for various reasons. And for stability the
GXP master branch has not been merged back.

See also the Readme:
https://github.com/heron-mc/heron-mc/tree/master/heron/ux/gxp

So the best way is to:

- make a clone of justb4/gxp
- add your changes there
- make a PR on justb4/gxp

I will then do the merge. Will this work for you? Thanks!

Best,

Just

> --
> --
> You received this message because you are subscribed to the Google
> Groups "geoext-viewer-devel" group.
> To post to this group, send email to
> geoext-vi...@googlegroups.com
> To unsubscribe from this group, send email to
> geoext-viewer-d...@googlegroups.com
> For more options, visit this group at
> http://groups.google.com/group/geoext-viewer-devel?hl=en
>
> ---
> You received this message because you are subscribed to the Google
> Groups "Heron Mapping Client Development" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to geoext-viewer-d...@googlegroups.com
> <mailto:geoext-viewer-d...@googlegroups.com>.
> For more options, visit https://groups.google.com/d/optout.

[wolfram.winter]

Hi Just,
ok - have done two PR on 'justb4/gxp' and 'heron-mc'.

Best
Wolfram

[Just van den Broecke]

Thanks Wolfram,

The 'heron-mc' PR (i18n additions) is now in "latest" Heron build:
https://lib.heron-mc.org/heron/latest/

ALso the GXP PR is merged. Still need to update the related GH submodule
in Heron repo to the latest commit.

Best,

Just

[wolfram.winter]

Hi Just - THANKS!!

[wolfram.winter]

Still need to update the related GH submodule
in Heron repo to the latest commit.

This would be nice, because I'm using the minified versions from the script folder ....
Best
Wolfram