Issue 16 in geodatastore: Unable to repeadly add Markers. SOLVED

0 views
Skip to first unread message

codesite...@google.com

unread,
Sep 19, 2008, 8:50:43 PM9/19/08
to geodat...@googlegroups.com
Issue 16: Unable to repeadly add Markers. SOLVED
http://code.google.com/p/geodatastore/issues/detail?id=16

New issue report by SamHiatt:
What steps will reproduce the problem?
1. Add a new Marker
2. Fill in form info and click "save"
3. Try adding another Marker

SOLUTION:
Looks like geometry.hasEnded is never set back to True.
Add the following line to the "save_button.onclick" function in admin.js
line 318:
me.selected_geometry_.hasEnded = true;

That'll fix the problem, but the user probably expects the control to
switch back to "view" after clicking "Save". That can easily be
accomplished by triggering the "view" button's 'click' event. I added the
following line to the save_button.onclick function as well:
GEvent.trigger(document.getElementById('view_control'),'click');

but in order for that to work you need to give the button an ID down in the
EditControl.prototype.createButton_ function:
button_img.id = button_opts.name+'_control';

And now it works as expected. :)

Issue attributes:
Status: New
Owner: ----
Labels: Type-Defect Priority-Medium

--
You received this message because you are listed in the owner
or CC fields of this issue, or because you starred this issue.
You may adjust your issue notification preferences at:
http://code.google.com/hosting/settings

codesite...@google.com

unread,
Sep 23, 2008, 5:52:23 AM9/23/08
to geodat...@googlegroups.com
Issue 16: Unable to repeadly add Markers. SOLVED
http://code.google.com/p/geodatastore/issues/detail?id=16

Comment #1 by pamela.fox:
Hey Sam-- Thanks for the fix. Do you want to join the project and commit
that code?
:)

codesite...@google.com

unread,
Sep 26, 2008, 11:27:54 PM9/26/08
to geodat...@googlegroups.com
Issue 16: Unable to repeadly add Markers. SOLVED
http://code.google.com/p/geodatastore/issues/detail?id=16

Comment #2 by pamela.fox:
Tested and uploaded live. Check it out.

And feel free to send more patches. :)


Issue attribute updates:
Status: Fixed

Reply all
Reply to author
Forward
0 new messages