[geocraft] #977: Modspec mapper issue

[geocraft]

#977: Modspec mapper issue
---------------------+------------------------------------------------------
Reporter: duncan | Owner: dan
Type: task | Status: new
Priority: major | Milestone: r4
Component: plugin | Version: 1.0
Keywords: | Estimatedhours: 4
Hours: 0 | Billable: 1
Totalhours: 0 |
---------------------+------------------------------------------------------
If you load the bulk in a non blocking task you have two problems:

* the properties view is not updated
* solution may be to listen for job completed event and fire a new
selection
* not blocking will potentially break the algorithms

--
Ticket URL: <http://wush.net/trac/geocraft/ticket/977>
geocraft <http://wush.net/trac/geocraft/>

[geocraft]

#977: Modspec mapper issue
-------------------------+--------------------------------------------------
Reporter: duncan | Owner: duncan

Type: task | Status: new
Priority: major | Milestone: r4
Component: plugin | Version: 1.0

Resolution: | Keywords:
Estimatedhours: 4 | Hours: 2
Billable: 1 | Totalhours: 0
-------------------------+--------------------------------------------------
Changes (by dan):

* hours: 0 => 2
* owner: dan => duncan
* totalhours: 0.0 => 2.0

Comment:

The first part is fixed. Not sure what we should do for the second one?

--
Ticket URL: <http://wush.net/trac/geocraft/ticket/977#comment:1>
geocraft <http://wush.net/trac/geocraft/>

[geocraft]

#977: Modspec mapper issue
-------------------------+--------------------------------------------------
Reporter: duncan | Owner: duncan

Type: task | Status: new
Priority: major | Milestone: r4
Component: plugin | Version: 1.0

Resolution: | Keywords:
Estimatedhours: 4 | Hours: 0
Billable: 1 | Totalhours: 2.0
-------------------------+--------------------------------------------------
Comment (by dan):

OK, I understand now where the issue related to the algorithms can be.
We have 3 use cases:
* the horizon is loaded before it can be used by the algorithm - we are
fine in this case, all the data is already loaded
* the horizon is loaded when the user selects it into the Horizon combo -
this is where we could see problems.
This happens when the user selects the variable into the Horizon combo
and the propertyChange is triggered, such as some properties of the
horizon are needed: for instance, the propertyChange code in DecimateView
calls inputHorizon.getNumRows(); The correct value is returned here as the
Grid2d is loaded before the Grid2dProperty is loaded by the
ModSpecGridReader task. But, if some algorithm would call
inputProperty.getMaxValue() here, an incorrect value of 0.0 would be
returned here.

* the horizon is loaded when the user hits the Run algorithm button. The
algorithm task happens in a different task than the SWT one, so in this
case the ModSpecGridReader task is ran using the JOIN flag, which makes
the calling thread wait until the reader thread has finished. This is
similar to viewing the horizon in the 3d viewer, so we are fine here too.

So, the only use case where we could have issues is the second one.

--
Ticket URL: <http://wush.net/trac/geocraft/ticket/977#comment:2>
geocraft <http://wush.net/trac/geocraft/>

[geocraft]

#977: Modspec mapper issue
-------------------------+--------------------------------------------------
Reporter: duncan | Owner: duncan

Type: task | Status: new
Priority: major | Milestone: someday
Component: plugin | Version: 1.0
Resolution: | Keywords:
Estimatedhours: 4 | Hours: 0
Billable: 1 | Totalhours: 2.0
-------------------------+--------------------------------------------------
Changes (by duncan):

* milestone: r4 => someday

--
Ticket URL: <http://wush.net/trac/geocraft/ticket/977#comment:3>
geocraft <http://wush.net/trac/geocraft/>

[geocraft]

#977: Modspec mapper issue
---------------------+------------------------------------------------------

Reporter: duncan | Owner: duncan
Type: task | Status: closed
Priority: major | Milestone: someday
Component: plugin | Resolution: fixed

Keywords: | Estimatedhours: 4
Hours: 0 | Billable: 1

Totalhours: 2.0 |
---------------------+------------------------------------------------------
Changes (by bob):

* status: new => closed
* resolution: => fixed

--
Ticket URL: <https://wush.net/trac/geocraft/ticket/977#comment:4>
geocraft <http://wush.net/trac/geocraft/>