Groups
Groups
Sign in
Groups
Groups
Gensim
Conversations
About
Send feedback
Help
logger.warning v/s logger.warn
125 views
Skip to first unread message
Chinmaya Pancholi
unread,
Mar 17, 2017, 7:52:30 AM
3/17/17
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to gensim
Currently, the code uses
logger.warning
as some places and
logger.warn
at other places (e.g. in the file gensim/models/word2vec.py). However, logging.warn has been deprecated since Python 3.3 and it is advisable to use logging.warning (Reference :
http://stackoverflow.com/questions/15539937/whats-the-difference-between-logging-warn-and-logging-warning-in-python-or-are
).
Would it be better if we replace logger.warn by logger.warning?
Lev Konstantinovskiy
unread,
Apr 26, 2017, 9:43:26 PM
4/26/17
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to gensim
Hi Chinmaya,
Yes, it is a good idea.
Chinmaya Pancholi
unread,
Apr 27, 2017, 12:32:51 AM
4/27/17
Reply to author
Sign in to reply to author
Forward
Sign in to forward
Delete
You do not have permission to delete messages in this group
Copy link
Report message
Show original message
Either email addresses are anonymous for this group or you need the view member email addresses permission to view the original message
to gensim
Great! I'll submit a PR for this soon then.
Reply all
Reply to author
Forward
0 new messages