Concurrency TODOs

[Jesse Jones]

This addresses DontUseLockedRegionOutsideMethodRule.

-- Jesse

["Andrés G. Aragoneses"]

wil -> will

The line:

+ /// public void EndEdits ()

Lacks a space.


+ /// // We need a try block in case the assembly is compiled with
+ /// // checked arithmetic. (Of course since this is C# we could use
+ /// // a lock statement instead which would be nicer).

Why not putting another good example with a lock{} ?

Other than that, looks great, thanks!

Andres


Jesse Jones wrote:
> This addresses DontUseLockedRegionOutsideMethodRule.
>
> -- Jesse
> >

[Jesse Jones]

On Aug 20, 2009, at 2:16 PM, Andrés G. Aragoneses wrote:

>
>
> wil -> will
>
> The line:
>
> + /// public void EndEdits ()
>
> Lacks a space.
>
>
> + /// // We need a try block in case the assembly is compiled with
> + /// // checked arithmetic. (Of course since this is C# we could
> use
> + /// // a lock statement instead which would be nicer).
>
> Why not putting another good example with a lock{} ?
>
> Other than that, looks great, thanks!

Thanks. Here is a new patch addressing the above.

-- Jesse

[Sebastien Pouliot]

I like this version but please wait for Andre's feedback before
committing.

Thanks
Sebastien

["Andrés G. Aragoneses"]

Go ahead.

Thanks,

Andrés

--

[Jesse Jones]

r140668

- Jesse