Grandstream key provisioning - show label

[Patrick Schaaf]

Here's a diff for prov/grandstream/settings.php (gs3.0, line numbers
might be off a bit), which provides speed dial keys with labels, in
addition to target numbers - makes for nicer display when using the
keys for dialling.

Please consider this for the normal release, it makes sense
unconditionally, IMO.

best regards
Patrick

--- settings.php~ 2010-10-25 20:23:03.970602004 +0200
+++ settings.php 2010-11-10 15:06:51.880839998 +0100

@@ -1316,17 +1320,17 @@
if ($key_idx < 7) { # gxp2000, gxp2010, gxp2020
psetting('P'.($key_idx +323),
subStr($key_def['function'],1));
//psetting('P'.($key_idx*3+301), '0');
- //psetting('P'.($key_idx*3+302), '');
+ psetting('P'.($key_idx*3+302),
$key_def['label']);
psetting('P'.($key_idx*3+303),
$key_def['data']);
} elseif ( $key_idx >= 7 && $key_idx <= 17 ) { #
gxp2010
psetting('P'.(($key_idx-7)*4+353),
subStr($key_def['function'],1));
//psetting('P'.(($key_idx-7)*4+354), '');
- //psetting('P'.(($key_idx-7)*4+355), '');
+ psetting('P'.(($key_idx-7)*4+355),
$key_def['label']);
psetting('P'.(($key_idx-7)*4+356),
$key_def['data']);
} elseif ($key_idx >= 100) { # extension 1 and 2
psetting('P'.($key_idx-100+6001),
subStr($key_def['function'],1));
//psetting('P'.($key_idx-100+6201), '');
- //psetting('P'.($key_idx-100+6401), '');
+ psetting('P'.($key_idx-100+6401),
$key_def['label']);
psetting('P'.($key_idx-100+6601),
$key_def['data']);
}
}

[Sebastian Ertz]

Hello Patrick,

Am 10.11.2010 15:32, schrieb Patrick Schaaf:
> Here's a diff for prov/grandstream/settings.php (gs3.0, line numbers
> might be off a bit), which provides speed dial keys with labels, in
> addition to target numbers - makes for nicer display when using the
> keys for dialling.
>
> Please consider this for the normal release, it makes sense
> unconditionally, IMO.

I test your changes. If this work, then i push it to github.

Sebastian

> --- settings.php~ 2010-10-25 20:23:03.970602004 +0200
> +++ settings.php 2010-11-10 15:06:51.880839998 +0100
>
> @@ -1316,17 +1320,17 @@
> if ($key_idx< 7) { # gxp2000, gxp2010, gxp2020
> psetting('P'.($key_idx +323),
> subStr($key_def['function'],1));
> //psetting('P'.($key_idx*3+301), '0');
> - //psetting('P'.($key_idx*3+302), '');
> + psetting('P'.($key_idx*3+302),
> $key_def['label']);
> psetting('P'.($key_idx*3+303),
> $key_def['data']);

> } elseif ( $key_idx>= 7&& $key_idx<= 17 ) { #