2.8.0 beta1

[Roccivic]

Are we ready for the beta? Or are we still missing something?

Rouslan

[Tom]

I have been meaning to bring this up but I have been pretty busy over
the last few weeks.

Except for the readme file I guess we are ready.

Does anyone disagree?

[hostellerie.org]

Let's go for a first beta :)

Ben

2011/6/14 Tom <tomh...@gmail.com>:

> --
> You received this message because you are subscribed to the Google Groups "Geeklog Forum" group.
> To post to this group, send email to geeklo...@googlegroups.com.
> To unsubscribe from this group, send email to geeklog-foru...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/geeklog-forum?hl=en.
>
>

[Rouslan Placella]

If no one has any objections I'll update the changelog, create a tarball
and post an articale on geeklog.net later today.

Rouslan

[Yoshinori Tahara]

I made support an upgrade from the last version of the Japanese
edition a short while ago.
I think that there has never been a loose end.
Let's go for a first beta.

dengen

2011/6/14 Rouslan Placella <rou...@placella.com>:

[Tom]

Sounds good.

On Jun 14, 4:35 am, Rouslan Placella <rous...@placella.com> wrote:
> If no one has any objections I'll update the changelog, create a tarball
> and post an articale on geeklog.net later today.
>
> Rouslan
>
>
>
>
>
>
>
> On Tue, 2011-06-14 at 09:07 +0200, hostellerie.org wrote:
> > Let's go for a first beta :)
>
> > Ben
>

> > 2011/6/14 Tom <tomho...@gmail.com>:

[Rouslan Placella]

I did all that. Just waiting now for someone to approve the article on
geeklog.net

Also I emailed Michael (ironmax), because he offered to run the beta of
the forum on demo.geeklog.net. With any luck he's still up for it ;)

Rouslan

[Rouslan Placella]

Just filed the first bug report on our tracker for the BETA1.
It's a showstopper :(

http://code.google.com/p/geeklog/issues/detail?id=28

Rouslan

[hostellerie.org]

I tryed the upgrade from 2.7.4 to 2.8 on a local test site and
everything work fine. I only needed to delete my layout/mytheme/forum
folder.

Ben

2011/6/15 Rouslan Placella <rou...@placella.com>:

[Yoshinori Tahara]

> I only needed to delete my layout/mytheme/forum folder.

The problem is serious.
We must prevent the loss of the compatibility of the template directory.

/pubulic_html/forum/forum == /pubuic_html/layout/theme/forum

dengen

2011/6/15 hostellerie.org <hostell...@gmail.com>:

[Rouslan Placella]

It's not as serious as it sounds, I have a fix for it already and will
check it in later today :)

Rouslan

[Yoshinori Tahara]

Is the directory /pubuic_html/layout/theme/forum valid after the upgrade?
If it is satisfied the problem is resolved.

dengen

2011/6/16 Rouslan Placella <rou...@placella.com>:

[Rouslan Placella]

After my patch the directory 'public_html/layout/theme/forum' will be
ignored, since we store theme data in 'public_html/forum/'.

Rouslan

[Yoshinori Tahara]

It's a pity.
I think that there are users who want to change the layout or style of
the forum to fit the theme.
I do not want to abolish this function.

dengen

2011/6/17 Rouslan Placella <rou...@placella.com>:

[Tom]

Maybe we should work it so backwards compatibility still is there.
(The core plugins should do it this way but they don't)

If the files exists in public_html/forum/ (or maybe a config option)
then they should be used. If not then it will default to public_html/
layout/theme/forum.

Geeklog does support multiple themes for one site so we should support
the ability of different forum theme files for different themes incase
the admin does want different colors, etc...

On a side note I hope to work on this topic feature after my holidays
in July

http://project.geeklog.net/tracking/view.php?id=1155

which also includes the idea of assigning themes to different topics.
If I end up doing this then something like I suggested here for the
forum would have to happen with the core plugins.

On Jun 16, 11:10 am, Rouslan Placella <rous...@placella.com> wrote:
> After my patch the directory 'public_html/layout/theme/forum' will be
> ignored, since we store theme data in 'public_html/forum/'.
>
> Rouslan
>
>
>
>
>
>
>
> On Fri, 2011-06-17 at 00:05 +0900, Yoshinori Tahara wrote:
> > Is the directory /pubuic_html/layout/theme/forum valid after the upgrade?
> > If it is satisfied the problem is resolved.
>
> > dengen
>

> > 2011/6/16 Rouslan Placella <rous...@placella.com>:

> > > It's not as serious as it sounds, I have a fix for it already and will
> > > check it in later today :)
>
> > > Rouslan
>
> > > On Thu, 2011-06-16 at 23:36 +0900, Yoshinori Tahara wrote:
> > >> > I only needed to delete my layout/mytheme/forum folder.
>
> > >> The problem is serious.
> > >> We must prevent the loss of the compatibility of the template directory.
>
> > >> /pubulic_html/forum/forum  ==  /pubuic_html/layout/theme/forum
>
> > >> dengen
>

> > >> 2011/6/15 hostellerie.org <hostellerie....@gmail.com>:

> > >> > I tryed the upgrade from 2.7.4 to 2.8 on a local test site and
> > >> > everything work fine. I only needed to delete my layout/mytheme/forum
> > >> > folder.
>
> > >> > Ben
>

> > >> > 2011/6/15 Rouslan Placella <rous...@placella.com>:

[Rouslan Placella]

But if this "switchable theme folder" feature breaks the upgrade, we
shouldn't use it. There have been many changes in the theme files of
forum and so they are not compatible any more with older versions of the
forum. We will be saving a lot of headache to users that will be
upgrading from older version if we just don't support multiple themes
anymore. I guess we have already discussed this before, but didn't reach
a conclusion [1].

Yoshinori, if someone can come up with a better solution that will work,
great, I'm sure everyone will be very happy with that, but I really
can't think of anything better than ignoring the files from the 'layout'
folder...

Rouslan

[1]:
http://groups.google.com/group/geeklog-forum/browse_thread/thread/6590c40f0c705453

[Joe Mucchiello]

This is not hard to fix, it just takes a little refactoring. Older plugins use
to have a function plugin_getTemplatePath($shortpath). Inside the function you
search through a list of paths trying to find a directory that exists.

So you can search to see if there is a directory called $_CONF['path_theme'] .
'forum/' . $shortpath and if there is you return that string. If not you return
$_CONF['path_html'] . 'forum/' . $shortpath.

Then you go through the forum code and replace new Template(....); with new
Template(FORUM_getTemplatePath(...));

Better still would be a FORUM_newTemplate that was aware of Geeklog 1.8's
COM_newTemplate. But there's no rush on that as I still have a month to go on
finishing the caching template plugin and that month doesn't start until I'm no
longer swamped at work (hopefully in July).

Joe

[hostellerie.org]

I think the forum beta works as dengen want.

But you need to update your layout/theme/forum folder if you upgrade from 2.7.4

As a test you can replace your layout/theme/forum with the
public_html/forum/forum folder and even delete the
public_html/forum/forum folder.

Ben

2011/6/16 Rouslan Placella <rou...@placella.com>:

[hostellerie.org]

To synthetise move public_html/forum/forum to layout/theme/forum
and it works.

Ben

2011/6/16 hostellerie.org <hostell...@gmail.com>:

[Rouslan Placella]

Finding the directory is not the issue, we have that in functions.inc:

---SNIP---
$CONF_FORUM['path_layout'] = $_CONF['path_html'] . 'forum/';
$CONF_FORUM['layout_url'] = $_CONF['site_url'] . '/forum';
if (is_dir($_CONF['path_layout'] . 'forum')) {
$CONF_FORUM['path_layout'] = $_CONF['path_layout'];
$CONF_FORUM['layout_url'] = $_CONF['layout_url'];
}
$CONF_FORUM['css_url'] = $CONF_FORUM['layout_url'] .
'/forum/layout/forum.css';
if (file_exists($_CONF['path_layout'] . 'forum/layout/forum.css')) {
$CONF_FORUM['css_url'] = $_CONF['layout_url'] .
'/forum/layout/forum.css';
}
---SNIP---

The problem is that after the upgrade, the directory exists, but has the
files of the old plugin which are not compatible with 2.8.0 hence the
user gets unexpected behaviour from the forum.

Rouslan

[Rouslan Placella]

Then switch to a different theme and crash...

[Yoshinori Tahara]

The problem is not in the functions.inc.
This code was present in the Japanese version. And there was no problem.
The problem is not so difficult.
Just restore the lost compatibility of directory /public_html/forum/forum.

[Joe Mucchiello]

Theoretically the way to make this future proof is if you make a significant
change to an existing theme file, change the name of the file. This way an older
version of the file can't accidentally be found by the code. The trick is
figuring out when a change is significant of course. :-)

----- Original Message ----
> From: Rouslan Placella <rou...@placella.com>
> To: geeklo...@googlegroups.com
> Sent: Thu, June 16, 2011 11:57:44 AM
> Subject: Re: [geeklog-forum] Re: 2.8.0 beta1
>

[Tom]

I think we should reverse the check. If the layout files are present
in the /public_html/forum/ directory then that is what the plugin
should use. If they are not there then it should check in the current
theme's directory.

This way things will work out of the box right away and not cause
errors especially when someone uploads the plugin and is not manually
moving the files. This is much less confusing to Admins. If the admin
then wants to tailor the forum template files to a particular theme he
can then move the files to the appropriate directory. This way we have
the best of both worlds.

Tom

On Jun 16, 12:28 pm, Yoshinori Tahara <denge...@gmail.com> wrote:
> The problem is not in the functions.inc.
> This code was present in the Japanese version. And there was no problem.
> The problem is not so difficult.
> Just restore the lost compatibility of directory /public_html/forum/forum.
>
> dengen
>

> 2011/6/17 Rouslan Placella <rous...@placella.com>:

> >> > 2011/6/17 Rouslan Placella <rous...@placella.com>:

> >> > > After  my patch the directory 'public_html/layout/theme/forum' will be
> >> > > ignored,  since we store theme data in 'public_html/forum/'.
>
> >> > >  Rouslan
>
> >> > > On Fri, 2011-06-17 at 00:05 +0900, Yoshinori Tahara  wrote:
> >> > >> Is the directory /pubuic_html/layout/theme/forum valid after  the upgrade?
> >> > >> If it is satisfied the problem is  resolved.
>
> >> > >> dengen
>

> >> > >> 2011/6/16  Rouslan Placella <rous...@placella.com>:

> >> > >>  > It's not as serious as it sounds, I have a fix for it already and  will
> >> > >> > check it in later today :)
>
> >> > >>  > Rouslan
>
> >> > >> > On Thu, 2011-06-16 at 23:36  +0900, Yoshinori Tahara wrote:
> >> > >> >> > I only needed to delete  my layout/mytheme/forum folder.
>
> >> > >> >> The  problem is serious.
> >> > >> >> We must prevent the loss of the  compatibility of the template
> >> directory.
>
> >> > >>  >> /pubulic_html/forum/forum  ==   /pubuic_html/layout/theme/forum
>
> >> > >> >>  dengen
>

> >> > >> >> 2011/6/15 hostellerie.org <hostellerie....@gmail.com>:

> >> > >>  >> > I tryed the upgrade from 2.7.4 to 2.8 on a local test site  and
> >> > >> >> > everything work fine. I only needed to delete my  layout/mytheme/forum
> >> > >> >> > folder.
> >> > >> >>  >
> >> > >> >> > Ben
>

> >> > >>  >> > 2011/6/15 Rouslan Placella <rous...@placella.com>:

[Yoshinori Tahara]

I propose that we add a new configuration value.

$CONF_FORUM['enable_themes_template']

Set the default value to false. Then, use as follows.

$CONF_FORUM['path_layout'] = $_CONF['path_html'] . 'forum/';
$CONF_FORUM['layout_url'] = $_CONF['site_url'] . '/forum';

if ($CONF_FORUM['enable_themes_template'] &&

is_dir($_CONF['path_layout'] . 'forum')) {
$CONF_FORUM['path_layout'] = $_CONF['path_layout'];
$CONF_FORUM['layout_url'] = $_CONF['layout_url'];
}
$CONF_FORUM['css_url'] = $CONF_FORUM['layout_url'] . '/forum/layout/forum.css';

if ($CONF_FORUM['enable_themes_template'] &&

file_exists($_CONF['path_layout'] . 'forum/layout/forum.css')) {
$CONF_FORUM['css_url'] = $_CONF['layout_url'] . '/forum/layout/forum.css';
}

The error will not occur after the upgrade.

dengen

2011/6/17 Tom <tomh...@gmail.com>:

[Rouslan Placella]

This sounds good to me, as long as that configuration variable is always
reinitialized to 'false' on every upgrade.

Rouslan

[Tom]

+1

On Jun 16, 1:58 pm, Rouslan Placella <rous...@placella.com> wrote:
> This sounds good to me, as long as that configuration variable is always
> reinitialized to 'false' on every upgrade.
>
> Rouslan
>
>
>
>
>
>
>
> On Fri, 2011-06-17 at 02:41 +0900, Yoshinori Tahara wrote:
> > I propose that we add a new configuration value.
>
> >   $CONF_FORUM['enable_themes_template']
>
> > Set the default value to false. Then, use as follows.
>
> > $CONF_FORUM['path_layout'] = $_CONF['path_html'] . 'forum/';
> > $CONF_FORUM['layout_url']  = $_CONF['site_url'] . '/forum';
> > if ($CONF_FORUM['enable_themes_template'] &&
> > is_dir($_CONF['path_layout'] . 'forum')) {
> >     $CONF_FORUM['path_layout'] = $_CONF['path_layout'];
> >     $CONF_FORUM['layout_url']  = $_CONF['layout_url'];
> > }
> > $CONF_FORUM['css_url'] = $CONF_FORUM['layout_url'] . '/forum/layout/forum.css';
> > if ($CONF_FORUM['enable_themes_template'] &&
> > file_exists($_CONF['path_layout'] . 'forum/layout/forum.css')) {
> >     $CONF_FORUM['css_url'] = $_CONF['layout_url'] . '/forum/layout/forum.css';
> > }
>
> > The error will not occur after the upgrade.
>
> > dengen
>

> > 2011/6/17 Tom <tomho...@gmail.com>:

[Yoshinori Tahara]

I added a new configuration variable 'use_themes_template' in order to
avoid problems after upgrade.
My English is cheap. Please modify or add the message as needed.

dengen

2011/6/17 Tom <tomh...@gmail.com>: