Forum Upgrade Procedure - Testing
1 view
Skip to first unread message
Tom
May 20, 2011, 9:20:31 AM5/20/11
to Geeklog Forum
Okay,
I have started to test the forum upgrade procedure and as reported
before by Rouslan it is broken. I believe this mainly has to do with
the Geeklog configuration.
I am not going to be able to test all of the upgrade paths but I
figured I would start this topic so others can assist and we do not do
duplicate testing.
First things first, we have 2 different plugins we are updating from
which introduces the configuration in different versions. The Japanese
version and the English version.
The English version introduces the configuration to the forum in
2.8.0. but we also have to consider that tabs where not introduced
until Geeklog 1.8.0 so the forum has to be able to deal with the older
Geeklog Configuration (1.6.0 - 1.7.2). We also have to deal with the
fact if they update the forum first which uses the old configuration
and then to Geeklog 1.8.0. If they do this then the tabs for the forum
will not be created. We will have to warn the users about this and
somehow allow the tabs to be inserted at a later date.
For the Japanese Forum, what version was the configuration introduced?
Tom
I have started to test the forum upgrade procedure and as reported
before by Rouslan it is broken. I believe this mainly has to do with
the Geeklog configuration.
I am not going to be able to test all of the upgrade paths but I
figured I would start this topic so others can assist and we do not do
duplicate testing.
First things first, we have 2 different plugins we are updating from
which introduces the configuration in different versions. The Japanese
version and the English version.
The English version introduces the configuration to the forum in
2.8.0. but we also have to consider that tabs where not introduced
until Geeklog 1.8.0 so the forum has to be able to deal with the older
Geeklog Configuration (1.6.0 - 1.7.2). We also have to deal with the
fact if they update the forum first which uses the old configuration
and then to Geeklog 1.8.0. If they do this then the tabs for the forum
will not be created. We will have to warn the users about this and
somehow allow the tabs to be inserted at a later date.
For the Japanese Forum, what version was the configuration introduced?
Tom
Rouslan Placella
May 20, 2011, 9:38:18 AM5/20/11
to geeklo...@googlegroups.com
Can't we just stick in the tabs regardless of the version? What if the
user has Geeklog 1.7.1 and we crete the tabs for the configuration?
From what I can see in the db, the tabs are merely a few extra rows,
so wouldn't these rows just be ignored by Geeklog until core is
updated to 1.8.0? If this is possible it would surely make everyone's
job easier.
user has Geeklog 1.7.1 and we crete the tabs for the configuration?
From what I can see in the db, the tabs are merely a few extra rows,
so wouldn't these rows just be ignored by Geeklog until core is
updated to 1.8.0? If this is possible it would surely make everyone's
job easier.
Rouslan
Quoting Tom <tomh...@gmail.com>:
> --
> You received this message because you are subscribed to the Google
> Groups "Geeklog Forum" group.
> To post to this group, send email to geeklo...@googlegroups.com.
> To unsubscribe from this group, send email to
> geeklog-foru...@googlegroups.com.
> For more options, visit this group at
> http://groups.google.com/group/geeklog-forum?hl=en.
>
>
Tom
May 20, 2011, 11:53:54 AM5/20/11
to Geeklog Forum
Interesting idea but we still would need to update the configuration
records since a tab column gets added to the config table in 1.8.0. I
just realized we wouldn't require the user to update the forum again
if they upgraded Geeklog after the forum. The forum configuration
would still work, it just wouldn't have tabs (since the Geeklog
configuration still supports no tabs for backwards compatibility). In
future upgrades of the forum we would then have to check if Geeklog
ver >=1.8.0 then install tabs.
On May 20, 9:38 am, Rouslan Placella <rous...@placella.com> wrote:
> Can't we just stick in the tabs regardless of the version? What if the
> user has Geeklog 1.7.1 and we crete the tabs for the configuration?
> From what I can see in the db, the tabs are merely a few extra rows,
> so wouldn't these rows just be ignored by Geeklog until core is
> updated to 1.8.0? If this is possible it would surely make everyone's
> job easier.
>
> Rouslan
>
records since a tab column gets added to the config table in 1.8.0. I
just realized we wouldn't require the user to update the forum again
if they upgraded Geeklog after the forum. The forum configuration
would still work, it just wouldn't have tabs (since the Geeklog
configuration still supports no tabs for backwards compatibility). In
future upgrades of the forum we would then have to check if Geeklog
ver >=1.8.0 then install tabs.
On May 20, 9:38 am, Rouslan Placella <rous...@placella.com> wrote:
> Can't we just stick in the tabs regardless of the version? What if the
> user has Geeklog 1.7.1 and we crete the tabs for the configuration?
> From what I can see in the db, the tabs are merely a few extra rows,
> so wouldn't these rows just be ignored by Geeklog until core is
> updated to 1.8.0? If this is possible it would surely make everyone's
> job easier.
>
> Rouslan
>
Tom
May 21, 2011, 10:21:25 AM5/21/11
to Geeklog Forum
Okay I pushed an update for install_defaults.php.
The function forum_update_ConfValues_2_7_4 is a direct copy of the
function plugin_initconfig_forum at the moment. I did it this way
because in future versions of the plugin we will be adding more config
options which will require modifications of plugin_initconfig_forum
but obviously not the upgrade of 2.7.4 which needs to stay the same or
the upgrade path will be broken. I took a quick look at the Japanese
version and it looks like that the configuration was added in 2.8.0
and not earlier like I thought before (can you confirm Dengen).
Anyways the upgrade does check to see if the forum config group gets
added before adding in the configuration values so even if config
values were added in an earlier version we should be safe.
The only thing we now have to consider in future forum upgrades is
checking to see if the tabs have been added or not (at least until the
min required version of Geeklog is 1.8.0 where we can make sure the
tabs are added for good). As I mentioned in a previous post if a user
upgrades the forum first and then Geeklog later the Configuration will
only consist of 1 tab and not 5. The configuration will work fine this
way so I am not going to worry about trying to add more tabs as we can
handle this check when a new version of the forum is released.
If I missed something let me know... :-)
Tom
The function forum_update_ConfValues_2_7_4 is a direct copy of the
function plugin_initconfig_forum at the moment. I did it this way
because in future versions of the plugin we will be adding more config
options which will require modifications of plugin_initconfig_forum
but obviously not the upgrade of 2.7.4 which needs to stay the same or
the upgrade path will be broken. I took a quick look at the Japanese
version and it looks like that the configuration was added in 2.8.0
and not earlier like I thought before (can you confirm Dengen).
Anyways the upgrade does check to see if the forum config group gets
added before adding in the configuration values so even if config
values were added in an earlier version we should be safe.
The only thing we now have to consider in future forum upgrades is
checking to see if the tabs have been added or not (at least until the
min required version of Geeklog is 1.8.0 where we can make sure the
tabs are added for good). As I mentioned in a previous post if a user
upgrades the forum first and then Geeklog later the Configuration will
only consist of 1 tab and not 5. The configuration will work fine this
way so I am not going to worry about trying to add more tabs as we can
handle this check when a new version of the forum is released.
If I missed something let me know... :-)
Tom
Rouslan Placella
May 22, 2011, 1:25:53 PM5/22/11
to geeklo...@googlegroups.com
I just tested the upgrade with the latest Geeklog version 1.8.0hg from
the repo and the configuration is getting created correctly during
upgrade. So it looks like the upgrade bug is in Geeklog, this one in
particular: http://project.geeklog.net/tracking/view.php?id=1345
the repo and the configuration is getting created correctly during
upgrade. So it looks like the upgrade bug is in Geeklog, this one in
particular: http://project.geeklog.net/tracking/view.php?id=1345
I think that this puts us in a difficult situation, since the forum will
work fine for a fresh install with GL 1.6.0+, but for upgrade will only
work for GL 1.8.0+
The only solution that I see for this is to bump up the minimum required
version of GL to 1.8.0. This will also end our issues with tabs and
we'll be able to drop legacy tooltips. But I wonder how well this will
go down with the users...
Any other ideas? Thoughts?
Rouslan
hostellerie.org
May 22, 2011, 1:39:33 PM5/22/11
to geeklo...@googlegroups.com
For me no problem to bump up the forum minimum required version of GL to 1.8.0
Ben
2011/5/22 Rouslan Placella <rou...@placella.com>:
Tom
May 22, 2011, 3:07:14 PM5/22/11
to Geeklog Forum
It's not a problem for me either (since it makes things easier) but it
may be a problem to others. Dirk had originally wanted us to keep the
min version to 1.6.0 for all those users who never updated Geeklog
(usually because of custom code). If we keep the min version at 1.6.0
we can then document how users will have to perform the upgrade to
sidestep the Geeklog bug (though this still requires us to figure out
the tabs issue in future upgrades).
Let's see what Dengen thinks the Japanese community response will be.
We could also post a story on Geeklog.net with a poll embedded so that
the users could help us decide what most need the min version to
be ...
On May 22, 1:39 pm, "hostellerie.org" <hostellerie....@gmail.com>
wrote:
may be a problem to others. Dirk had originally wanted us to keep the
min version to 1.6.0 for all those users who never updated Geeklog
(usually because of custom code). If we keep the min version at 1.6.0
we can then document how users will have to perform the upgrade to
sidestep the Geeklog bug (though this still requires us to figure out
the tabs issue in future upgrades).
Let's see what Dengen thinks the Japanese community response will be.
We could also post a story on Geeklog.net with a poll embedded so that
the users could help us decide what most need the min version to
be ...
On May 22, 1:39 pm, "hostellerie.org" <hostellerie....@gmail.com>
wrote:
> For me no problem to bump up the forum minimum required version of GL to 1.8.0
>
> Ben
>
> 2011/5/22 Rouslan Placella <rous...@placella.com>:
>
> Ben
>
Rouslan Placella
May 23, 2011, 9:27:13 AM5/23/11
to geeklo...@googlegroups.com
I can't get the upgrade to work properly at all on anything older than
1.8.0, if it's actually possible then I'm all up for keeping the version
requirement at 1.6.0 and documenting the upgrade process.
1.8.0, if it's actually possible then I'm all up for keeping the version
requirement at 1.6.0 and documenting the upgrade process.
As for the poll, I'd say it's a waste of time, since IMO there isn't
enough traffic on GL.net lately...
Rouslan
Tom
May 23, 2011, 9:36:58 AM5/23/11
to Geeklog Forum
I will give the forum upgrade a try on Geeklog 1.7.2 tomorrow then.
Tom
Tom
Yoshinori Tahara
May 23, 2011, 9:52:46 AM5/23/11
to geeklo...@googlegroups.com
From the beginning, I was considering flexibility to upgrade.
However, upgrade.inc little mistakes in there.
Update of install_defaults.php was no needed.
It is enough in the smaller fix of upgrade.inc.
Please let me fix it again.
However, upgrade.inc little mistakes in there.
Update of install_defaults.php was no needed.
It is enough in the smaller fix of upgrade.inc.
Please let me fix it again.
I have already started to upgrade testing, too.
Some upgrade patterns was successful.
dengen
2011/5/21 Tom <tomh...@gmail.com>:
Yoshinori Tahara
May 24, 2011, 9:01:34 AM5/24/11
to geeklo...@googlegroups.com
Sorry, Tom.
My previous message was incorrect.
I understood Tom's upgrade for install_defaults.php. It is necessary.
But, did you notice gf_updateSystem function in the file admin/gf_functions.php?
It is the trigger to add configuration tabs at the time when Geeklog
is upgraded to version 1.8.0+.
I'll modify code about upgrade for this function works as intended.
dengen
2011/5/23 Yoshinori Tahara <deng...@gmail.com>:
--
dengen
Tom
May 24, 2011, 11:05:49 AM5/24/11
to Geeklog Forum
No I missed gf_updateSystem in my follow through of the code. Thanks.
Once you update the code I will do some testing. I am not sure if I
will get to it today though as one of my servers power supply went so
I had to spend the last 2 hours exchanging it.
if I do not get to testing today I should tomorrow.
Tom
On May 24, 9:01 am, Yoshinori Tahara <denge...@gmail.com> wrote:
> Sorry, Tom.
>
> My previous message was incorrect.
> I understood Tom's upgrade for install_defaults.php. It is necessary.
> But, did you notice gf_updateSystem function in the file admin/gf_functions.php?
> It is the trigger to add configuration tabs at the time when Geeklog
> is upgraded to version 1.8.0+.
> I'll modify code about upgrade for this function works as intended.
>
> dengen
>
> 2011/5/23 Yoshinori Tahara <denge...@gmail.com>:
Once you update the code I will do some testing. I am not sure if I
will get to it today though as one of my servers power supply went so
I had to spend the last 2 hours exchanging it.
if I do not get to testing today I should tomorrow.
Tom
On May 24, 9:01 am, Yoshinori Tahara <denge...@gmail.com> wrote:
> Sorry, Tom.
>
> My previous message was incorrect.
> I understood Tom's upgrade for install_defaults.php. It is necessary.
> But, did you notice gf_updateSystem function in the file admin/gf_functions.php?
> It is the trigger to add configuration tabs at the time when Geeklog
> is upgraded to version 1.8.0+.
> I'll modify code about upgrade for this function works as intended.
>
> dengen
>
>
>
>
>
>
>
>
>
>
> > From the beginning, I was considering flexibility to upgrade.
> > However, upgrade.inc little mistakes in there.
> > Update of install_defaults.php was no needed.
> > It is enough in the smaller fix of upgrade.inc.
> > Please let me fix it again.
>
> > I have already started to upgrade testing, too.
> > Some upgrade patterns was successful.
>
> > dengen
>
> > 2011/5/21 Tom <tomho...@gmail.com>:
>
>
>
>
>
>
>
>
> > From the beginning, I was considering flexibility to upgrade.
> > However, upgrade.inc little mistakes in there.
> > Update of install_defaults.php was no needed.
> > It is enough in the smaller fix of upgrade.inc.
> > Please let me fix it again.
>
> > I have already started to upgrade testing, too.
> > Some upgrade patterns was successful.
>
> > dengen
>
Tom
May 24, 2011, 11:57:29 AM5/24/11
to Geeklog Forum
I just notice that the forum_settings table is still in the db after
an upgrade. We should remove it if it is not being used.
an upgrade. We should remove it if it is not being used.
Tom
May 28, 2011, 11:50:06 AM5/28/11
to Geeklog Forum
Okay.
I have removed the forum_settings table from the install and it now
gets dropped with an upgrade. I will work on the settings getting
moved from the config file to the Geeklog config on upgrade next
(currently it looks to be just inserting the defaults).
I have tested the following on an a Windows server (using IIS) with
the latest forum 2.8.0 code with success:
Geeklog 1.8.0
- Install 2.8.0
- Upgrade - Forum 2.7.4 - 2.8.0
Geeklog 1.7.1sr1
- Install 2.8.0
- Upgrade - Forum 2.7.4 - 2.8.0
Tom
I have removed the forum_settings table from the install and it now
gets dropped with an upgrade. I will work on the settings getting
moved from the config file to the Geeklog config on upgrade next
(currently it looks to be just inserting the defaults).
I have tested the following on an a Windows server (using IIS) with
the latest forum 2.8.0 code with success:
Geeklog 1.8.0
- Install 2.8.0
- Upgrade - Forum 2.7.4 - 2.8.0
Geeklog 1.7.1sr1
- Install 2.8.0
- Upgrade - Forum 2.7.4 - 2.8.0
Tom
Tom
May 28, 2011, 2:18:49 PM5/28/11
to Geeklog Forum
Okay the forum now uses the values found in the forum_settings table
to populate the Geeklog Configuration. I retested the install and
upgrade procedure on both of my setups and it worked properly.
to populate the Geeklog Configuration. I retested the install and
upgrade procedure on both of my setups and it worked properly.
Rouslan Placella
May 29, 2011, 8:43:22 AM5/29/11
to geeklo...@googlegroups.com
Nice! I'll give it a go whenever I can as well.
Rouslan
Reply all
Reply to author
Forward
0 new messages