Forum template files

[Ben]

I wonder what is the advantage of having the forum template files in
the layout folder?
If none, could we move them in a future release outside the web root
into the plugin folder?

Ben

[Joe Mucchiello]

In ancient times, when Geeklog has more than a handful of themes, the idea was
that the forum theme would vary by theme when users switched themes. Does any
run a GL site with multiple themes allowing users to change the theme any more?
I doubt very many folks do.

I favor moving the folder back under plugin just to simplify the install of the
forum.

In fact, this reminds me. I'd like to do something about lib-portalparts.lib
being in the system directory. But without having control of the other plugins I
doubt much can be done about that.

[Rouslan Placella]

lib-portalparts is gone already from the forum. It was recently pulled
by the Geeklog.jp group ;)

Rouslan

[Yoshinori Tahara]

The Forum template files are located in the /public_html/forum directory now.
Thus, Forum is also available for auto installation feature of Geeklog.
Also, the Forum template files can be placed in the theme directory as ever.
It is also possible to change the layout by the user's convenience.

dengen

2011/5/4 Rouslan Placella <rou...@placella.com>:

> --
> You received this message because you are subscribed to the Google Groups "Geeklog Forum" group.
> To post to this group, send email to geeklo...@googlegroups.com.
> To unsubscribe from this group, send email to geeklog-foru...@googlegroups.com.
> For more options, visit this group at http://groups.google.com/group/geeklog-forum?hl=en.
>
>

[hostellerie.org]

ohoh features are implemented before being requested. Very nice :)

Thanks.

Ben

2011/5/4 Yoshinori Tahara <deng...@gmail.com>:

[Rouslan Placella]

I would suggest getting rid of that 'public_html/forum' folder
altogether. And merging the 'image_set' folder with the 'images' folder
and hooking the smilies into the gf_getImage API call, as well as moving
'javascript' out directly into 'public_html' and also moving the layout
to the web root, like Ben suggests.

I wonder if I should try and have a go at this before Monday...

Thoughts?

Rouslan

[Tom]

Sounds fine by me as long as we still allow the layout forum directory
to still go in the theme directory so if a site does have multiple
themes they can still customize the forum theme to each Geeklog theme.

[Rouslan Placella]

Huh? But I thought that we already don't allow that, since the 'layout'
folder currently installs in 'public_html/forum/forum/'. Or am I missing
something?

Rouslan

[Yoshinori Tahara]

Rouslan's suggestion may be appropriate because it conforms to the
core plugins of Geeklog.
Take note the location of forum.css.

In my personal opinion I don't like moving only the templates
('layout') into the plugin folder.
The templates, css, images, and scripts are related to each other.
It's logical that these items together in one directory.
It's just same style as the theme of Geeklog (like the professional theme).
Another reason is the result of backward compatibility in mind.

dengen

2011/5/6 Rouslan Placella <rou...@placella.com>:

[Tom]

From my understanding (I may be wrong here) users can still put the
forum layout folder into the professional theme folder if they want
(like how it use to work) to allow for multiple themes on a website.
To be honest I do not think this feature of Geeklog is used much
anymore. ie public_html/layout/professional/forum/. Most plugins do
not support this so if we move away from this with the forum that is
fine by me I guess :-)

dengen makes a good point about keeping related files together but I
also do not see the point of having template files accessible on the
public part of the website since visitors will never need to directly
access those files.

I wonder if we should leave this for the moment (or not)? At some
point I will be start working on my topic feature

http://project.geeklog.net/tracking/view.php?id=1155

which also talks about some template changes I would like to implement
(or Joe may) which would allow for the default layouts to stay
unedited and allow users to create a new theme with only the files
that needed updated. The original theme will be the fall back theme
for any missing files from the new theme. I could see something
similar for plugin template files. Of course this is still a while
away and needs much more thought to be put into it.

I guess if someone wants to go ahead with this change then it would be
best to conform with the core plugins...

Tom

[Joe Mucchiello]

> dengen makes a good point about keeping related files together but I

> also do not see the point of having template files accessible on the
> public part of the website since visitors will never need to directly
> access those files.

template files should never be left in the public arena. I've always hated this
about the forum.

> Of course this is still a while
> away and needs much more thought to be put into it.

glFusion has been doing this for 3-4 years now. But it does require some
thought. I think I have a better way to do it now that requires less strange
code in the template library (especially since we now have the COM_newTemplate).
I need to find some time to fool around with this.

[Yoshinori Tahara]

> template files should never be left in the public arena. I've always hated this
> about the forum.

The forum template files are located outside of the
/public_html/layout/theme_name directory now.
So the problems with switching of the theme does not occur.
Why put the forum template files outside of the public area?

dengen

2011/5/7 Joe Mucchiello <jmucc...@yahoo.com>: