forum_userinfo table
1 view
Skip to first unread message
Roccivic
Apr 12, 2011, 5:07:44 PM4/12/11
to Geeklog Forum
While grepping around trying to clean-up the image_set directory I've
stumbled on the following:
1. While using the forum I can't find anywhere to put in IM, ICQ, etc
2. Grepping for "userinfo" shows a few matches, most importantly in
functions.inc in the following functions:
* plugin_profileextrassave_forum
* plugin_profilevariablesedit_forum
* plugin_profilevariablesdisplay_forum
3. Unfortunately the above functions do not seem to used anywhere
So, I'm guessing that this functionality has been partially dropped.
But a some redundant code and graphics were left behind.
I'd say that we should explore this further and potentially finish the
clean-up that someone started earlier...
Thoughts?
Rouslan
stumbled on the following:
1. While using the forum I can't find anywhere to put in IM, ICQ, etc
2. Grepping for "userinfo" shows a few matches, most importantly in
functions.inc in the following functions:
* plugin_profileextrassave_forum
* plugin_profilevariablesedit_forum
* plugin_profilevariablesdisplay_forum
3. Unfortunately the above functions do not seem to used anywhere
So, I'm guessing that this functionality has been partially dropped.
But a some redundant code and graphics were left behind.
I'd say that we should explore this further and potentially finish the
clean-up that someone started earlier...
Thoughts?
Rouslan
Tom
Apr 12, 2011, 8:55:55 PM4/12/11
to Geeklog Forum
I notice that a while ago as well, I am not sure if that was a new
uncompleted feature or as you said one that has only been partially
removed. It seems like something that Geeklog or a user plugin should
take care of anyways.
I would say pull it but we could also contact Blaine the original
author and see what happen here.
Tom
uncompleted feature or as you said one that has only been partially
removed. It seems like something that Geeklog or a user plugin should
take care of anyways.
I would say pull it but we could also contact Blaine the original
author and see what happen here.
Tom
Roccivic
Apr 13, 2011, 5:07:18 PM4/13/11
to Geeklog Forum
Yeah, the user info is definitely core's business, so I'll pull it.
Maybe we should file a feature request for this at geeklog.net
Rouslan
Maybe we should file a feature request for this at geeklog.net
Rouslan
Joe Mucchiello
Apr 13, 2011, 8:16:24 PM4/13/11
to geeklo...@googlegroups.com
Aren't they used by the profile.php to allow plugins to add fields to the user
pages?
pages?
The real problem is the user profile stuff in core is FUBARed. Whenever it was
converted to a tabbed layout, these plugin functions stopped working. Install
something like GL 1.4.1 and add the forum and you'll see those functions adding
fields to the old profile page.
I do think there's a bug report about those functions already in the bug
tracker. But another one can't hurt.
> --
> You received this message because you are subscribed to the Google Groups
>"Geeklog Forum" group.
> To post to this group, send email to geeklo...@googlegroups.com.
> To unsubscribe from this group, send email to
>geeklog-foru...@googlegroups.com.
> For more options, visit this group at
>http://groups.google.com/group/geeklog-forum?hl=en.
>
>
Tom
Apr 14, 2011, 12:27:05 PM4/14/11
to Geeklog Forum
(hitting myself on the head) I forgot about that functionality. I
should have clued in with those function names.
We should leave it in the forum then and get it fixed in core. Did you
want to add a bug report Roccivic?
should have clued in with those function names.
We should leave it in the forum then and get it fixed in core. Did you
want to add a bug report Roccivic?
Rouslan Placella
Apr 14, 2011, 1:24:29 PM4/14/11
to geeklo...@googlegroups.com
Doh, the function names are a dead giveaway, I should have been grepping
in geeklog, not the forum. Anyway, I'm not all that sure about how this
works, so I guess that it would be great if someone else that is more
familiar with this functionality would file the bug report with
geeklog.net
in geeklog, not the forum. Anyway, I'm not all that sure about how this
works, so I guess that it would be great if someone else that is more
familiar with this functionality would file the bug report with
geeklog.net
Rouslan
Tom
Apr 14, 2011, 3:40:18 PM4/14/11
to Geeklog Forum
I thought I had had this discussion before....
http://www.geeklog.net/forum/viewtopic.php?showtopic=87955&mode=&show=5&page=4
I just did a few more tests and it looks like for the most part things
still work as long as the proper template variables are in place. This
is obviously not ideal since for the forum you would have to go ahead
and add in all the forum specfic template variables to profile.html
(the one in the users and preference directory). I think the best plan
would be to have a single common template variable that plugins can
then apply their own templates to for viewing and editing. Each plugin
would get a chance to do this based on the plugin order.
I will add in this feature request.
http://www.geeklog.net/forum/viewtopic.php?showtopic=87955&mode=&show=5&page=4
I just did a few more tests and it looks like for the most part things
still work as long as the proper template variables are in place. This
is obviously not ideal since for the forum you would have to go ahead
and add in all the forum specfic template variables to profile.html
(the one in the users and preference directory). I think the best plan
would be to have a single common template variable that plugins can
then apply their own templates to for viewing and editing. Each plugin
would get a chance to do this based on the plugin order.
I will add in this feature request.
Tom
Apr 14, 2011, 3:40:48 PM4/14/11
to Geeklog Forum
I thought I had had this discussion before....
http://www.geeklog.net/forum/viewtopic.php?showtopic=87955&mode=&show=5&page=4
I just did a few more tests and it looks like for the most part things
still work as long as the proper template variables are in place. This
is obviously not ideal since for the forum you would have to go ahead
and add in all the forum specfic template variables to profile.html
(the one in the users and preference directory). I think the best plan
would be to have a single common template variable that plugins can
then apply their own templates to for viewing and editing. Each plugin
would get a chance to do this based on the plugin order.
I will add in this feature request.
On Apr 14, 1:24 pm, Rouslan Placella <rous...@placella.com> wrote:
http://www.geeklog.net/forum/viewtopic.php?showtopic=87955&mode=&show=5&page=4
I just did a few more tests and it looks like for the most part things
still work as long as the proper template variables are in place. This
is obviously not ideal since for the forum you would have to go ahead
and add in all the forum specfic template variables to profile.html
(the one in the users and preference directory). I think the best plan
would be to have a single common template variable that plugins can
then apply their own templates to for viewing and editing. Each plugin
would get a chance to do this based on the plugin order.
I will add in this feature request.
On Apr 14, 1:24 pm, Rouslan Placella <rous...@placella.com> wrote:
Tom
Apr 20, 2011, 11:45:22 AM4/20/11
to Geeklog Forum
Okay,
I have updated the code a bit to make everything work and have the
sample profile.thtml files for the example.
Do we want to create a separate docs directory off of the root of the
forum to include the examples along with the readme, history files and
any other docs we want to include?
On Apr 14, 3:40 pm, Tom <tomho...@gmail.com> wrote:
> I thought I had had this discussion before....
>
> http://www.geeklog.net/forum/viewtopic.php?showtopic=87955&mode=&show...
I have updated the code a bit to make everything work and have the
sample profile.thtml files for the example.
Do we want to create a separate docs directory off of the root of the
forum to include the examples along with the readme, history files and
any other docs we want to include?
On Apr 14, 3:40 pm, Tom <tomho...@gmail.com> wrote:
> I thought I had had this discussion before....
>
Rouslan Placella
Apr 20, 2011, 3:17:05 PM4/20/11
to geeklo...@googlegroups.com
On Wed, 2011-04-20 at 08:45 -0700, Tom wrote:
> Do we want to create a separate docs directory off of the root of the
> forum to include the examples along with the readme, history files and
> any other docs we want to include?
> Do we want to create a separate docs directory off of the root of the
> forum to include the examples along with the readme, history files and
> any other docs we want to include?
Was think about this myself. Sounds like a good idea.
Rouslan
Roccivic
Apr 23, 2011, 9:24:36 AM4/23/11
to Geeklog Forum
I've had a look at the "examples" and I don't think it's good idea to
add them to the repository.
I think it's best to just get this whole issue fixed in core whenever,
I'm sure that people will survive not having their AIM button in the
profile.
I wonder: if we provide examples and people use them and add the
modifications to Geeklog and then the issue is resolved in core, will
the users have all of those items in their profile twice???
Not sure about this at all...
Rouslan
add them to the repository.
I think it's best to just get this whole issue fixed in core whenever,
I'm sure that people will survive not having their AIM button in the
profile.
I wonder: if we provide examples and people use them and add the
modifications to Geeklog and then the issue is resolved in core, will
the users have all of those items in their profile twice???
Not sure about this at all...
Rouslan
Tom
Apr 23, 2011, 10:27:15 AM4/23/11
to Geeklog Forum
I would rather keep them in the repository or I will loose them :-).
We could decided not to include them in the release though. What I
could see loosing are the user profile variables as they are probably
not that useful to most people. This type of thing should be in a
separate plugin which I was working on at one point. I could finish
converting it if I had some time.
What is useful though is displaying the users forum stats and posts on
their page.
The upgrade to this section in core probably will not take to long if
we just worry about the template variables and displaying the stats
and post information automatically. If we want to start adding tabs,
etc. it will take longer to complete. Either way I will not have the
time for this after 1.8.0 is released as I want to start on my Topic
feature and the redesign first. Maybe after, it would be nice to have
it all cleaned up.
>> profile twice
It shouldn't happen twice unless they edit the templates to include
the new variables.
We could decided not to include them in the release though. What I
could see loosing are the user profile variables as they are probably
not that useful to most people. This type of thing should be in a
separate plugin which I was working on at one point. I could finish
converting it if I had some time.
What is useful though is displaying the users forum stats and posts on
their page.
The upgrade to this section in core probably will not take to long if
we just worry about the template variables and displaying the stats
and post information automatically. If we want to start adding tabs,
etc. it will take longer to complete. Either way I will not have the
time for this after 1.8.0 is released as I want to start on my Topic
feature and the redesign first. Maybe after, it would be nice to have
it all cleaned up.
>> profile twice
It shouldn't happen twice unless they edit the templates to include
the new variables.
Reply all
Reply to author
Forward
0 new messages