Feature freeze and 2.8.0

[Rouslan Placella]

So since we have a feature freeze now, I guess that we should start
tidying up. What I think is missing is finishing up with the
configuration UI. Right now I don't see any code that migrates the
settings from the old table to the new system. Admins shouldn't lose the
settings. Also I think there are other references to the settings table,
like in the SQL file.

Also, in memberlist the pagination seems buggy for large numbers of
users. Click on "Last page" on that page on geeklog.net, and the last
entry will be two pages before the "Last page".

Anything else that needs to be done?

Rouslan

[Tom]

It should definitely migrate over if it doesn't. We should also
probably add the tooltips in as well for the configuration to offer a
bit of help on the more cryptic settings. There are also some config
option in the config file that should really be in the Geeklog
configuration as well.

I had forgotten about that pagination bug with the members list. I had
to add a

Disallow: /forum/memberlist.php

to robots.txt because Google had gone in an infinite loop on me on one
of my sites since the members list currently goes on forever.

The other bug I remember was that for some reason a Private Forum (one
with specific group access) had to be first in the sort order or it
would visible to other users. I will have to check that one out.

We should also probably fix "Issues with Tooltips in the centerblock"
and "Why does the forum have 2 SQL Install Files"

Other than that I guess we should just do some testing and make sure
everything upgrades correctly.

Tom

[Rouslan Placella]

On Tue, 2011-05-10 at 18:38 -0700, Tom wrote:
> It should definitely migrate over if it doesn't.

@Dengen: Since you migrated to the configuration UI, would you be up for
it?

> We should also
> probably add the tooltips in as well for the configuration to offer a
> bit of help on the more cryptic settings.

Did you ever implement that config tooltip API call in Geeklog? If you
did, we could use that (and say sorry to people on versions older than
1.8.0).

> There are also some config
> option in the config file that should really be in the Geeklog
> configuration as well.

We have a strings freeze in effect, right? This should be left for the
2.9 branch.

> I had forgotten about that pagination bug with the members list. I had
> to add a
>
> Disallow: /forum/memberlist.php
>
> to robots.txt because Google had gone in an infinite loop on me on one
> of my sites since the members list currently goes on forever.

I'll file it as a bug, so that we won't forget ;)

> We should also probably fix "Issues with Tooltips in the centerblock"
> and "Why does the forum have 2 SQL Install Files"

I'll take the latter. Any volunteers for the former?

Rouslan

[Tom]

On May 13, 7:41 pm, Rouslan Placella <rous...@placella.com> wrote:
> Did you ever implement that config tooltip API call in Geeklog? If you
> did, we could use that (and say sorry to people on versions older than
> 1.8.0).

Yup it is in there, you can use the old way or the new way with our
new tooltips

> > There are also some config
> > option in the config file that should really be in the Geeklog
> > configuration as well.
>
> We have a strings freeze in effect, right? This should be left for the
> 2.9 branch.

Yup your right

> > I had forgotten about that pagination bug with the members list. I had
> > to add a
>
> > Disallow: /forum/memberlist.php
>
> > to robots.txt because Google had gone in an infinite loop on me on one
> > of my sites since the members list currently goes on forever.

I will take a look at this one in a couple of days.

Tom

[Rouslan Placella]

On Sat, 2011-05-14 at 12:37 -0700, Tom wrote:
> On May 13, 7:41 pm, Rouslan Placella <rous...@placella.com> wrote:
> > Did you ever implement that config tooltip API call in Geeklog? If you
> > did, we could use that (and say sorry to people on versions older than
> > 1.8.0).
>
> Yup it is in there, you can use the old way or the new way with our
> new tooltips

On second thought, this will also break the strings freeze and IMO
should also be left alone;

Rouslan

[Rouslan Placella]

Well, it looks like dengen pushed the old hack for the config tooltips.
But I'm not happy with his changeset. First of all, it duplicated the
readme file that already exists in the docs directory. Second, the
tooltips are empty and aren't actually useful quite yet. Third, the
readme file should not be in a publicly accessible folder. This is a
security risk, as we don't want to advertise to potential attackers
exactly what version of the forum is running on the site, we want them
guessing. And lastly, it's kind of a feature and we have a feature
freeze in effect.

So, unless someone can convince me not to, I think that I will backout
of this changeset later today.

Rouslan

[Yoshinori Tahara]

Ok, Rouslan.

I understood your intent. Let me revert this changeset.
I should not push a halfway result.
Of course, the duplication of readme was temporary.
I considered about the security risk. However, I coordinated with the
place of the docs directory of Geeklog.

As for the new way of config tooltips, I didn't know.
Where should I get information about it?

Does the config tooltips feature add in the next version?

dengen

2011/5/15 Rouslan Placella <rou...@placella.com>:

[Tom]

> First of all, it duplicated the readme file that already exists in the docs directory. Second, the tooltips are empty and aren't actually useful quite yet.

The readme file in docs should just contain the config info like the
core plugins. I can add in the english text if we decide to keep the
changeset

> Third, the readme file should not be in a publicly accessible folder. This is a security risk

We will take out the version information but I believe the file has to
be accessible by the javascript for the config tooltip hack built into
Geeklog to work. This is how the hack works and Geeklog docs have
always been accessible by anyone on the site. I can't say I like it
either but that is the way it is for now (and always has been).

> it's kind of a feature and we have a feature freeze in effect.

It is sort of, but since the new configuration options have been in
their for a while now I see it more as an extension of that.

If are minimum version support was for Geeklog 1.8.0 I would then
rather us use the real tooltips for the configuration. Since the forum
supports Geeklog 1.6.0 the only way to offer these users with links to
the config docs is the way dengen has done it.

When I started this post I first thought we should pull the changeset,
now I am thinking we should leave it since it is the only way for us
to support Geeklog 1.6.0 websites.

I will update the docs file correctly (since English is not Dengen's
first language) sometime next week if we decide to keep the changeset.

Tom

[Tom]

Here Dengen

http://wiki.geeklog.net/index.php/PLG_getplugin_getConfigTooltip

With my last post I missed seeing your post. I still think we should
probably include the config doc as it supports Geeklog 1.6.0.

On May 15, 9:12 am, Yoshinori Tahara <denge...@gmail.com> wrote:
> Ok, Rouslan.
>
> I understood your intent. Let me revert this changeset.
> I should not push a halfway result.
> Of course, the duplication of readme was temporary.
> I considered about the security risk. However, I coordinated with the
> place of the docs directory of Geeklog.
>
> As for the new way of config tooltips, I didn't know.
> Where should I get information about it?
>
> Does the config tooltips feature add in the next version?
>
> dengen
>

> 2011/5/15 Rouslan Placella <rous...@placella.com>:

[Yoshinori Tahara]

Thanks, Tom.

The way of my doing is the way which is the same as the core plugins
of current version and seems to be a right way.

dengen

[Tom]

Yes it is since we are supporting Geeklog 1.6.0. We could do a version
check for 1.8.0 and offer the other tooltips but I do not see the
point until we raise the minimum version since it means we would have
duplicate text in the doc file and the language files.

So Rouslan, what's your thoughts on this? Should Dengen go ahead and
finish his changeset?

[Rouslan Placella]

Well, first of all, I'd like to say that I did not mean any disrespect
towards Yoshinori and I realise that I might have come across rude
earlier and I'm sorry about that. And yes, the way that that changeset
was written is consistent with how the configuration tooltips are
implemented in core and core plugins. However I think that it can be
done better.

Off the top of my head, I think that it should be done as follows:

* Place the config tooltip strings in the language files
* Change the extension of the docs/forum.html file to .php
* Then place these lines of code at the top of the page:

--- SNIP ---
require_once '../lib-common.php';
if (! SEC_hasRights('forum.admin')) {
die("Access denied");
}
--- SNIP ---

* And then, since we are in PHP mode in this file now, we could merely
"echo" the strings from the language files as necessary inside a loop
that generates the required tables.

I think that the main advantages would be:
* This file will not be accessible to anyone other that a forum admin
* Forward integration of the new config tooltips will be easier, since
we will already have all the strings in the language files (which is
where they belong) and dropping support for the old config tooltips will
be as easy as removing one file and removing a function from another
file.

Also if the above goes ahead, it would make sense to move all the files
from the old 'docs' folder to the new one that would be located in
'public_html/docs' and use the same method for kicking out unauthorised
users.

I wonder if this is an over-the-top request....

Overall, after reading this conversation I have to agree that we should
break our feature freeze and introduce these tooltips (especially since
we didn't announce the freeze anywhere other than this list). That said,
I was hoping for a beta1 tomorrow, but we might want to hold that off
until next week while this issue settles down.

Please let me know what you think about this.

Rouslan

[Rouslan Placella]

On Tue, 2011-05-10 at 18:38 -0700, Tom wrote:

> We should also probably fix "Issues with Tooltips in the centerblock"
> and "Why does the forum have 2 SQL Install Files"

I just pushed a changeset that fixes the outstanding issue from "Why
does the forum have 2 SQL Install Files" (bug #19). I used 'grep' for
the search and replace functionality and I think that it all worked out
pretty well. I did basic testing and all functionality looks good. Just
thought I'd give everyone a heads-up ;)

Rouslan

[Yoshinori Tahara]

Your consideration of the security risk is laudable.
But there are some concerns.

First, you proposed /docs/forum.php is no longer readme.html.
The readme.html is necessary to refer to offline.
It means duplicate the readme file.

Second, this is equivalent to improving the config tooltips feature.
At first, it should be employed by the core and the core plugins.

dengen

2011/5/16 Rouslan Placella <rou...@placella.com>:

[Rouslan Placella]

Look, I'm not going to insist on this. The config tooltips are a feature
that, as Tom pointed out, is necessary for admins. So we should include
it. So, Yoshinori, will you finish your patch and then push it into
trunk again, please? Maybe we can discuss a different solution for the
next release, but this will have to do for now.

Rouslan

[Tom]

>>Maybe we can discuss a different solution for the next release, but this will have to do for now.

Sounds like a plan. Let's keep it the same.

I plan on finishing up the regular readme install file on the install
instructions tomorrow along with the members list page bug.

Once everyone has finished their items, should we release a beta?

Also, once Geeklog 1.8.0 is released I have a few sites to upgrade.
Once I have finished that I plan on testing the forum on a live site
and make sure everything upgrades fine.

On May 16, 9:58 am, Rouslan Placella <rous...@placella.com> wrote:
> Look, I'm not going to insist on this. The config tooltips are a feature
> that, as Tom pointed out, is necessary for admins. So we should include
> it. So, Yoshinori, will you finish your patch and then push it into
> trunk again, please? Maybe we can discuss a different solution for the
> next release, but this will have to do for now.
>
> Rouslan
>
>
>
>
>
>
>
> On Mon, 2011-05-16 at 22:26 +0900, Yoshinori Tahara wrote:
> > Your consideration of the security risk is laudable.
> > But there are some concerns.
>
> > First, you proposed /docs/forum.php is no longer readme.html.
> > The readme.html is necessary to refer to offline.
> > It means duplicate the readme file.
>
> > Second, this is equivalent to improving the config tooltips feature.
> > At first, it should be employed by the core and the core plugins.
>
> > dengen
>

> > 2011/5/16 Rouslan Placella <rous...@placella.com>:

[Rouslan Placella]

On Mon, 2011-05-16 at 07:57 -0700, Tom wrote:
> Once everyone has finished their items, should we release a beta?

The upgrade is broken at the moment for the configuration UI. I've been
digging into it yesterday, but haven't tracked down the issue.

I tried with the following combinations:
GL 1.6.1sr1 + Forum 2.7.2
GL 1.7.2 + Forum 2.7.2
GL 1.8.0 + Forum 2.7.4

The upgrade process creates 4 empty fieldsets (or was it tabs?), which
are not even visible in the UI, but can be seen in the db.

Again, not sure what the problem is, but this is pretty major and IMO
should be fixed before any release.

Rouslan

[Yoshinori Tahara]

All right.　But the descriptions of the config tooltips are still incomplete.
If possible, let me push in this state.
And since my English skill is poor, please input the text of
descriptions in English on my behalf.

[Tom]

Do what you can with the config docs and I will review it and make any
changes if needed.

On May 16, 12:42 pm, Yoshinori Tahara <denge...@gmail.com> wrote:
> All right.　But the descriptions of the config tooltips are still incomplete.
> If possible, let me push in this state.
> And since my English skill is poor, please input the text of
> descriptions in English on my behalf.
>
> dengen
>

> 2011/5/16 Rouslan Placella <rous...@placella.com>:

>
>
>
>
>
>
>
> > Look, I'm not going to insist on this. The config tooltips are a feature
> > that, as Tom pointed out, is necessary for admins. So we should include
> > it. So, Yoshinori, will you finish your patch and then push it into
> > trunk again, please? Maybe we can discuss a different solution for the
> > next release, but this will have to do for now.
>
> > Rouslan
>
> > On Mon, 2011-05-16 at 22:26 +0900, Yoshinori Tahara wrote:
> >> Your consideration of the security risk is laudable.
> >> But there are some concerns.
>
> >> First, you proposed /docs/forum.php is no longer readme.html.
> >> The readme.html is necessary to refer to offline.
> >> It means duplicate the readme file.
>
> >> Second, this is equivalent to improving the config tooltips feature.
> >> At first, it should be employed by the core and the core plugins.
>
> >> dengen
>

> >> 2011/5/16 Rouslan Placella <rous...@placella.com>:

[Tom]

Of course. If any new bugs are discovered, they should be fixed
before the beta. If the upgrade is still broken tomorrow I will take a
look at it as well. :-)

Tom

[Yoshinori Tahara]

Thanks, Tom.

dengen

2011/5/17 Tom <tomh...@gmail.com>:

[Rouslan Placella]

I've actually just just pushed a change that filled in the gaps, most
required descriptions were available in 2.7.4 anyway. So we could
consider this as closed for now.

Rouslan

[Tom]

Okay so I have worked a bit on the readme and forum documents. Did I
mention I hate writing these things :-)

Anyways, The forum document (the one used by the tooltips) will look
similar to the core plugins documents. It will list the configuration
options in the Geeklog Configuration and any other config options plus
some template and autotag information.

The readme file will contain the install/upgrade instructions along
with the summary, author, version info, etc. I will be removing the
config and template info from this file and putting it in the forum
document.

I would also like to just include one upgrade section. The section
could include notes about specific version of the forum plugin if
needed. There are a few reasons for this. First most of the upgrade
sections are very similar. Second I do not have time to test upgrading
from each specific version and the changes required between each. Plus
the upgrade was written with Geeklog 1.4.1 in mind not Geeklog 1.6
plus. Does this sound okay? If someone is having problems (I am not
sure why) we could always recommend them reading the readme file from
2.7.4

Tom

On May 16, 6:36 pm, Yoshinori Tahara <denge...@gmail.com> wrote:
> Thanks, Tom.
>
> dengen
>

> 2011/5/17 Tom <tomho...@gmail.com>:

[Tom]

I just missed your post when I wrote mine Rouslan. Should we just
leave things alone now after your push and then deal with rearranging
the documents in the next version?

[Rouslan Placella]

On Tue, 2011-05-17 at 11:20 -0700, Tom wrote:
> Okay so I have worked a bit on the readme and forum documents. Did I
> mention I hate writing these things :-)

LOL, me too.

> Anyways, The forum document (the one used by the tooltips) will look
> similar to the core plugins documents. It will list the configuration
> options in the Geeklog Configuration and any other config options plus
> some template and autotag information.

Ooops, sorry for making you merge with the changes to the config tooltip
file that I pushed a few minutes ago. My bad (should have known better,
and will for next time).

> I would also like to just include one upgrade section. The section
> could include notes about specific version of the forum plugin if
> needed. There are a few reasons for this. First most of the upgrade
> sections are very similar. Second I do not have time to test upgrading
> from each specific version and the changes required between each. Plus
> the upgrade was written with Geeklog 1.4.1 in mind not Geeklog 1.6
> plus. Does this sound okay? If someone is having problems (I am not
> sure why) we could always recommend them reading the readme file from
> 2.7.4

Yeah that sounds good.

Rouslan

[Rouslan Placella]

On Tue, 2011-05-17 at 11:31 -0700, Tom wrote:
> I just missed your post when I wrote mine Rouslan. Should we just
> leave things alone now after your push and then deal with rearranging
> the documents in the next version?

Yeah, and I missed yours. My emails seem to be pretty slow today...
Anyway, if you can be bothered to merge, then I'd say do it. Your
document will probably be far better than what I pushed. If it's too
much work to merge and you don't want to, you could send me a patch from
your tree (or a tarball of your repo) and I'll merge it in for you
(since this is my fault anyway).

Rouslan