Will gecko-mediaplayer/mplayerplug-in support xulrunner 1.9?
Cesare Tirabassi
I have been working lately in trying to port both mplayerplug-in and
gecko-mediaplayer to xulrunner 1.9 (see
https://wiki.ubuntu.com/XulrunnerGecko).
I can patch both to use the right glue and compile but the code itself would
need to be patched to be compatible with 1.9 (for instance see GRE and frozen
linking in above link).
Before touching the code myself, I though I'd ask you if you were planning to
do anything of the sort in the near future?
Cesare
Kevin DeKorte
Hash: SHA1
Cesare,
If your .pc files are correct you should not have to change anything.
This code is already found in gecko-mediaplayer in the configure.in file
(there was an errant mozilla-plugin check in there, which I just removed)
if test "$GECKO_CFLAGS" = ""; then
PKG_CHECK_MODULES(GECKO, [libxul],[
~ GECKO_HOME=`$PKG_CONFIG --variable=libdir libxul`
~ GECKO_IDLDIR=`$PKG_CONFIG --variable=idldir libxul`
~ ],[AC_MSG_WARN([libxul not found, trying another])])
fi
And it should find things correctly.
The code works fine on fedora 9 and it is already using xulrunner 1.9.
So there should be not other needed changes.
Kevin
- --
Get my public GnuPG key from
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x7D0BD5D1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFIchGy6w2kMH0L1dERAksLAJ44LwohTl2bGoNanF3ZLODgs+1UlwCfelR8
dJqsGbTalaUthd+z+ibQehs=
=pq+/
-----END PGP SIGNATURE-----
Cesare Tirabassi
>
> If your .pc files are correct you should not have to change anything.
>
> This code is already found in gecko-mediaplayer in the configure.in file
> (there was an errant mozilla-plugin check in there, which I just removed)
>
> if test "$GECKO_CFLAGS" = ""; then
> PKG_CHECK_MODULES(GECKO, [libxul],[
> ~ GECKO_HOME=`$PKG_CONFIG --variable=libdir libxul`
> ~ GECKO_IDLDIR=`$PKG_CONFIG --variable=idldir libxul`
> ~ ],[AC_MSG_WARN([libxul not found, trying another])])
> fi
>
> And it should find things correctly.
>
> The code works fine on fedora 9 and it is already using xulrunner 1.9.
> So there should be not other needed changes.
Thanks for your speedy feedback Kevin,
we do have some difference unfortunately, so I had to take them into account.
In our case libxul-dev is for xulrunner 1.8 and xulrunner-1.9-dev is for
xulrunner 1.9; I just fiddled with configure and patched it as attached. Its
ugly but it works, or at least, it works for firefox 3.0 while it doesn't for
all 1.8 based browsers (I checked with firefox 2 and seamonkey).
In these browsers all I get is a blank screen.
Kevin DeKorte
Hash: SHA1
Cesare,
You really should never edit the configure file directly. You need to
edit the configure.in file and then run autoconf to generate the
configure script.
So I added another check in for libxul-unstable into the svn code. So if
you have a pkg-config that responds to libxul it will be used prior to a
pkg-config that responds to libxul-unstable
Kevin
- --
Get my public GnuPG key from
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x7D0BD5D1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFIchkc6w2kMH0L1dERAtpqAJ43ccj2uAaQ7YdRIG0WuPUQQuWSVACfUfFe
3oOyuyAa6CClHiolhyfxLJg=
=MGVQ
-----END PGP SIGNATURE-----
Cesare Tirabassi
> You really should never edit the configure file directly. You need to
> edit the configure.in file and then run autoconf to generate the
> configure script.
Kevin,
doing the autoconf dance during our buildd builds is almost always never worth
the troubles it will cause. That configure change is the result of me
patching configure.in, running autoconf and feeding the result back via a
configure patch (manually tweaked).
> So I added another check in for libxul-unstable into the svn code. So if
> you have a pkg-config that responds to libxul it will be used prior to a
> pkg-config that responds to libxul-unstable
Well, that wouldn't work because libxul.pc is equivalent to libxul-stable.pc,
so your check will fail (it expects to find 1.8 and finds 1.9).
You would have to do the check for libxul-unstable before doing that for
libxul, or, in alternative, check the version field.
My real problem right now is not the compilation, It does that pretty happily
and works fine for 1.9, its just the fact that that same code will not work
on 1.8 based browsers.
Cesare
Kevin DeKorte
Hash: SHA1
Cesare Tirabassi wrote:
| My real problem right now is not the compilation, It does that pretty
happily
| and works fine for 1.9, its just the fact that that same code will not
work
| on 1.8 based browsers.
|
| Cesare
Casare... yes that is correct... code compiled against 1.9 will not work
with code expecting 1.8. This is normal and limitation of the mozilla
stack. However, I believe that code compiled on 1.8 will work with the
1.9 applications.
So you need to make sure that when you compile gecko-mediaplayer you
compile it against 1.8 which should be libxul.
If you are installing multiple versions of firefox on the same machine
and compile against the most current you should expect to have problems.
Kevin
- --
Get my public GnuPG key from
http://pgp.mit.edu:11371/pks/lookup?op=get&search=0x7D0BD5D1
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.7 (GNU/Linux)
Comment: Using GnuPG with Fedora - http://enigmail.mozdev.org
iD8DBQFIciBk6w2kMH0L1dERAv+SAJ9I816IlSZF+EXJXT/cgQPRbqqlRwCeOofs
1sgyBmTGwZv8NqAwqB/1neY=
=jIc8
-----END PGP SIGNATURE-----