Index: gears/tools/config.mk
===================================================================
--- gears/tools/config.mk (revision 142)
+++ gears/tools/config.mk (working copy)
@@ -40,11 +40,13 @@
# OSX builds will override this.
# Other platforms just need a value defined.
ARCH = i386
+ARCH = x86_64
# Set default build mode
# dbg = debug build
# opt = release build
MODE = dbg
+MODE = opt
# $(shell ...) statements need to be different on Win32 (%% vs %).
@@ -95,6 +97,7 @@
COMPILE_FLAGS_dbg = -g -O0
COMPILE_FLAGS_opt = -O2
COMPILE_FLAGS = -c -o $@ -fPIC -Wall -Werror $(COMPILE_FLAGS_$(MODE))
+COMPILE_FLAGS = -c -o $@ -fPIC -Wall $(COMPILE_FLAGS_$(MODE))
# NS_LITERAL_STRING does not work properly without this compiler option
COMPILE_FLAGS += -fshort-wchar
Index: gears/localserver/firefox/async_task_ff.cc
===================================================================
--- gears/localserver/firefox/async_task_ff.cc (revision 142)
+++ gears/localserver/firefox/async_task_ff.cc (working copy)
@@ -441,7 +441,8 @@
Abort();
break;
default:
- OnListenerEvent(msg_code, reinterpret_cast<int>(msg_param));
+// OnListenerEvent(msg_code, reinterpret_cast<int>(msg_param));
+ OnListenerEvent(msg_code, reinterpret_cast<long>(msg_param));
break;
}
}
Index: gears/third_party/gecko_sdk/1.8/linux/lib/libxpcomglue_s.a
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: gears/third_party/gecko_sdk/1.8/linux/lib/libnspr4.so
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: gears/third_party/gecko_sdk/1.8/linux/lib/libxpcom.so
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: gears/third_party/gecko_sdk/1.8/linux/bin/xpidl
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: gears/third_party/gecko_sdk/1.8/linux/bin/xpt_dump
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: gears/third_party/gecko_sdk/1.8/linux/bin/regxpcom
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Index: gears/third_party/gecko_sdk/1.8/linux/bin/xpt_link
===================================================================
Cannot display: file marked as a binary type.
svn:mime-type = application/octet-stream
Did the binaries also change, or just a flag on the binaries? I can't
tell from the diff.
I needed to copy the 64bit binaries from a manual firefox build to
replace the 32bit ones in CVS.
So far it's working fine with Google Reader.
On Jul 16, 7:25 pm, "Chris Prince" <cpri...@google.com> wrote:
> Very cool, John. So if I'm reading this right, "x86_64" was the key
> change to the source code? The other changes seem to be related to
> typecast warnings -- is that right?
>
> Did the binaries also change, or just a flag on the binaries? I can't
> tell from the diff.
>
<snip>
You must replace the below files with 64bit versions. You can
probably find them in /usr/lib/...
or in the 64 bit gecko sdk.
We are really excited to have a clean patch that enables 64-bit
support. Right now the eng team is pushing to stabilize the code and
push a new release, but I hope we can take another look at the patch
after that.
Thanks, Scott!
--Chris
- a
It strikes me that this gains a dependency on the boost library just
to compile 1 typedef and 1 assert. Is this preferable to just using a
#define or two?
John.
Updated patch has been posted at
http://code.google.com/p/gears/issues/detail?id=335
. Binary is at http://www-personal.umich.edu/~swolchok/gears/gears-linux-opt-0.3.25.0.xpi
. It passes the unit tests, but other than that I haven't done any
testing.
First of all, we don't hate 64-bit users. Really, we don't!! In a
perfect world, we would officially support 64-bit Linux, and every
other platform as well.
The problem is simply one of resources. For the officially supported
platforms, we do a *lot* of testing before every release. As users
ourselves, we hate poorly tested software.
So adding 64-bit Linux isn't simply a matter of submitting the patch
(which is something we *will* do). For official support, we would
need to add 64-bit Linux to our test matrix. And that would be a
non-trivial amount of work.
But all is not lost. :) This is one of the great things about
open-source projects. Anybody in the community can build and host
64-bit Linux builds of Gears. Scott has done this for 0.3.25.0, and
hopefully he or somebody else will do so for future builds of Gears on
64-bit Linux. I think this is a great way to get 64-bit Linux support
in the short term.
I hope that gives a little more insight into the 64-bit Linux situation.
--Chris