[PATH] Fix assertions with RP355

[Torsten Stremlau]

When using my RP355 V1.4 I got some assertions when using certain distortions and delays, because of missing entries in modifiers[]. The following patch fixed this.

P.S.: I already posted a patch to this list a few hours ago, but it didn't seem to work. If it did work, please ignore the other post, as I didn't fix all the problems in the last patch :)

diff -r d7c391da07eb effects.c
--- a/effects.c    Sa Jan 19 22:07:01 2013 +0100
+++ b/effects.c    So Jan 20 00:49:04 2013 +0100
@@ -3344,8 +3344,16 @@
     {"Dist Level", DIST_808_LVL, DIST_POSITION, &values_0_to_99},
     {"Dist Drive", DIST_GUYOD_DRIVE, DIST_POSITION, &values_0_to_99},
     {"Dist Level", DIST_GUYOD_LVL, DIST_POSITION, &values_0_to_99},
+    {"Dist Gain", DIST_SPARKDRIVE_GAIN, DIST_POSITION, &values_0_to_99},
+    {"Dist Tone", DIST_SPARKDRIVE_TONE, DIST_POSITION, &values_0_to_99},
+    {"Dist Clean", DIST_SPARKDRIVE_CLEAN, DIST_POSITION, &values_0_to_99},
+    {"Volume", DIST_SPARKDRIVE_VOLUME, DIST_POSITION, &values_0_to_99},
     {"Dist Gain", DIST_DOD250_GAIN, DIST_POSITION, &values_0_to_99},
     {"Dist Level", DIST_DOD250_LVL, DIST_POSITION, &values_0_to_99},
+    {"Dist Gain", DIST_REDLINE_GAIN, DIST_POSITION, &values_0_to_99},
+    {"Dist Low", DIST_REDLINE_LOW, DIST_POSITION, &values_0_to_99},
+    {"Dist High", DIST_REDLINE_HIGH, DIST_POSITION, &values_0_to_99},
+    {"Dist Level", DIST_REDLINE_LEVEL, DIST_POSITION, &values_0_to_99},
     {"Dist Distortion", DIST_RODENT_DIST, DIST_POSITION, &values_0_to_99},
     {"Dist Filter", DIST_RODENT_FILTER, DIST_POSITION, &values_0_to_99},
     {"Dist Volume", DIST_RODENT_LVL, DIST_POSITION, &values_0_to_99},
@@ -3372,6 +3380,15 @@
     {"Dist Smear", DIST_GONK_SMEAR, DIST_POSITION, &values_0_to_99},
     {"Dist Suck", DIST_GONK_SUCK, DIST_POSITION, &values_0_to_99},
     {"Dist Heave", DIST_GONK_HEAVE, DIST_POSITION, &values_0_to_99},
+    {"Dist Drive", DIST_8TAVIA_DRIVE, DIST_POSITION, &values_0_to_99},
+    {"Dist Volume", DIST_8TAVIA_VOLUME, DIST_POSITION, &values_0_to_99},
+    {"Dist Fuzz", DIST_FUZZLATOR_FUZZ, DIST_POSITION, &values_0_to_99},
+    {"Dist Tone", DIST_FUZZLATOR_TONE, DIST_POSITION, &values_0_to_99},
+    {"Dist LooseTight", DIST_FUZZLATOR_LOOSETIGHT, DIST_POSITION, &values_loose_tight},
+    {"Dist Volume", DIST_FUZZLATOR_VOLUME, DIST_POSITION, &values_0_to_99},
+    {"Dist Fuzz", DIST_CLASSIC_FUZZ_FUZZ, DIST_POSITION, &values_0_to_99},
+    {"Dist Tone", DIST_CLASSIC_FUZZ_TONE, DIST_POSITION, &values_0_to_99},
+    {"Dist Volume", DIST_CLASSIC_FUZZ_VOLUME, DIST_POSITION, &values_0_to_99},
     {"Dist Fuzz", DIST_FUZZY_FUZZ, DIST_POSITION, &values_0_to_99},
     {"Dist Volume", DIST_FUZZY_VOLUME, DIST_POSITION, &values_0_to_99},
     {"Dist Sustain", DIST_MP_SUSTAIN, DIST_POSITION, &values_0_to_99},
@@ -3492,6 +3509,13 @@
     {"Delay Mod Depth", DELAY_DEPTH, DELAY_POSITION, &values_0_to_99},
     {"Delay Tape Wow", DELAY_TAPE_WOW, DELAY_POSITION, &values_0_to_99},
     {"Delay Tape Flut", DELAY_TAPE_FLUTTER, DELAY_POSITION, &values_0_to_99},
+    {"Delay Echoplex Time", DELAY_ECHOPLEX_TIME, DELAY_POSITION, &values_0_to_99},
+    {"Delay Repeats 0 99", DELAY_REPEATS_0_99, DELAY_POSITION, &values_0_to_99},
+    {"Delay Volume", DELAY_VOLUME, DELAY_POSITION, &values_0_to_99},
+    {"Delay Repeat Rate", DELAY_REPEAT_RATE_DM, DELAY_POSITION, &values_0_to_99},
+    {"Delay Echo", DELAY_ECHO, DELAY_POSITION, &values_0_to_99},
+    {"Delay Intensity", DELAY_INTENSITY, DELAY_POSITION, &values_0_to_99},
+
     {"Reverb Enable", REVERB_ON_OFF, REVERB_POSITION, &values_on_off},
     {"Reverb Decay", REVERB_DECAY, REVERB_POSITION, &values_0_to_99},
     {"Reverb Liveliness", REVERB_LIVELINESS, REVERB_POSITION, &values_0_to_99},
@@ -3982,8 +4006,15 @@
     {DIST_808_LVL, DIST_POSITION, "Dist Level", &values_0_to_99,},
     {DIST_GUYOD_DRIVE, DIST_POSITION, "Dist Drive", &values_0_to_99,},
     {DIST_GUYOD_LVL, DIST_POSITION, "Dist Level", &values_0_to_99,},
+    {DIST_SPARKDRIVE_GAIN, DIST_POSITION, "Dist Gain", &values_0_to_99},
+    {DIST_SPARKDRIVE_TONE, DIST_POSITION, "Dist Tone", &values_0_to_99},
+    {DIST_SPARKDRIVE_CLEAN, DIST_POSITION, "Dist Clean", &values_0_to_99},
     {DIST_DOD250_GAIN, DIST_POSITION, "Dist Gain", &values_0_to_99,},
     {DIST_DOD250_LVL, DIST_POSITION, "Dist Level", &values_0_to_99,},
+    {DIST_REDLINE_GAIN, DIST_POSITION, "Dist Gain", &values_0_to_99},
+    {DIST_REDLINE_LOW, DIST_POSITION, "Dist Low", &values_0_to_99},
+    {DIST_REDLINE_HIGH, DIST_POSITION, "Dist High", &values_0_to_99},
+    {DIST_REDLINE_LEVEL, DIST_POSITION, "Dist Level", &values_0_to_99},
     {DIST_RODENT_DIST, DIST_POSITION, "Dist Distortion", &values_0_to_99,},
     {DIST_RODENT_FILTER, DIST_POSITION, "Dist Filter", &values_0_to_99,},
     {DIST_RODENT_LVL, DIST_POSITION, "Dist Volume", &values_0_to_99,},
@@ -4010,6 +4041,15 @@
     {DIST_GONK_SMEAR, DIST_POSITION, "Dist Smear", &values_0_to_99,},
     {DIST_GONK_SUCK, DIST_POSITION, "Dist Suck", &values_0_to_99,},
     {DIST_GONK_HEAVE, DIST_POSITION, "Dist Heave", &values_0_to_99,},
+    {DIST_8TAVIA_DRIVE, DIST_POSITION, "Dist Drive", &values_0_to_99},
+    {DIST_8TAVIA_VOLUME, DIST_POSITION, "Dist Volume", &values_0_to_99},
+    {DIST_FUZZLATOR_FUZZ, DIST_POSITION, "Dist Fuzz", &values_0_to_99},
+    {DIST_FUZZLATOR_TONE, DIST_POSITION, "Dist Tone", &values_0_to_99},
+    {DIST_FUZZLATOR_LOOSETIGHT, DIST_POSITION, "Dist LooseTight", &values_loose_tight},
+    {DIST_FUZZLATOR_VOLUME, DIST_POSITION, "Dist Volume", &values_0_to_99},
+    {DIST_CLASSIC_FUZZ_FUZZ, DIST_POSITION, "Dist Fuzz", &values_0_to_99},
+    {DIST_CLASSIC_FUZZ_TONE, DIST_POSITION, "Dist Tone", &values_0_to_99},
+    {DIST_CLASSIC_FUZZ_VOLUME, DIST_POSITION, "Dist Volume", &values_0_to_99},
     {DIST_FUZZY_FUZZ, DIST_POSITION, "Dist Fuzz", &values_0_to_99,},
     {DIST_FUZZY_VOLUME, DIST_POSITION, "Dist Volume", &values_0_to_99,},
     {DIST_MP_SUSTAIN, DIST_POSITION, "Dist Sustain", &values_0_to_99,},
@@ -4165,6 +4205,12 @@
     {DELAY_DEPTH, DELAY_POSITION, "Delay Mod Depth", &values_0_to_99,},
     {DELAY_TAPE_WOW, DELAY_POSITION, "Delay Tape Wow", &values_0_to_99,},
     {DELAY_TAPE_FLUTTER, DELAY_POSITION, "Delay Tape Flut", &values_0_to_99,},
+    {DELAY_ECHOPLEX_TIME, DELAY_POSITION, "Delay Echoplex Time", &values_0_to_99},
+    {DELAY_REPEATS_0_99, DELAY_POSITION, "Delay Repeats 0 99", &values_0_to_99},
+    {DELAY_VOLUME, DELAY_POSITION, "Delay Volume", &values_0_to_99},
+    {DELAY_REPEAT_RATE_DM, DELAY_POSITION, "Delay Repeat Rate", &values_0_to_99},
+    {DELAY_ECHO, DELAY_POSITION, "Delay Echo", &values_0_to_99},
+    {DELAY_INTENSITY, DELAY_POSITION, "Delay Intensity", &values_0_to_99},
 
     {REVERB_TYPE, REVERB_POSITION, "Reverb Type", &values_reverb_type, xml_reverb_labels, G_N_ELEMENTS(xml_reverb_labels)},
     {REVERB_ON_OFF, REVERB_POSITION, "Reverb Enable", &values_on_off, xml_on_off_labels, G_N_ELEMENTS(xml_on_off_labels)},

[Tomasz Moń]

On Sun, Jan 20, 2013 at 12:56 AM, Torsten Stremlau
<torsten....@gmail.com> wrote:
> P.S.: I already posted a patch to this list a few hours ago, but it didn't
> seem to work. If it did work, please ignore the other post, as I didn't fix
> all the problems in the last patch :)

This list is moderated for new members due to spam issues.

Your email client garbled the patch. Moreover, it seems to be based on
non-public changeset.
Please rebase this patch against current repository [1] and resend it.

To properly send a patch can use git-send-email or check out the Linux
documentation for tips about how to configure your email client [2].

[1] git://github.com/desowin/gdigi.git
[2] http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/email-clients.txt;hb=HEAD

[Torsten Stremlau]

Ok, here is the patch again.
I based the patch on the latest git revision now. I also attached the
patch to prevent it getting garbled... I hope that is ok.