comonalities between gnx3k and gnx4

[Jaco Kroon]

Would you prefer I rename variables that turns out to be common between
gnx3k and gnx4 to gnx or just reference the gnx3k variables as is?

Jaco

[S C Rigler]

We could just rename them to "GNX_WHATEVER". Any suggestions on when we
should do that?

--
S C Rigler <rigl...@gmail.com>

[Jaco Kroon]

S C Rigler wrote:
> On Tue, 2009-05-12 at 23:25 +0200, Jaco Kroon wrote:
>> Would you prefer I rename variables that turns out to be common between
>> gnx3k and gnx4 to gnx or just reference the gnx3k variables as is?
>>
>> Jaco
>
> We could just rename them to "GNX_WHATEVER". Any suggestions on when we
> should do that?
>

I can rename the rest as I port for the gnx4, and then put in a last
patch to rename the rest?

Jaco

[Tomasz Moń]

2009/5/13 Jaco Kroon <ja...@kroon.co.za>:

> I can rename the rest as I port for the gnx4, and then put in a last
> patch to rename the rest?

First add all effects for GNX4, then we'll handle renames.
I don't want to commit garbage patches.
With IDs you can actually make 100% sure if it's correct before
sending patch (just check if device doesn't respond with NACK - it'd
be displayed on console).