[GrandComicsDatabase/gcd-django] Add a filter to sequences to filter on universe (PR #690)
Adam Knights
Tested with all sequence views, some examples:
Character sequences unfiltered
image.png (view on web)
with filter:
image.png (view on web)
Feature:
image.png (view on web)
Creator:
image.png (view on web)
Universe correctly pops it:
image.png (view on web)
For anything not involved in Marvel/DC, universes filter doesnt appear whenno sequences have a universe in data to filter:
image.png (view on web)
And then finally, the addition of story type filter I noticed meant we started to overhang on mobile, this would have made it worse, so added a wrap, example on mobile size:
image.png (view on web)
You can view, comment on, or merge this pull request online at:
https://github.com/GrandComicsDatabase/gcd-django/pull/690
Commit Summary
- 801ec4c Add a filter to sequences to filter on universe
File Changes
(3 files)
- M apps/gcd/views/details.py (1)
- M apps/select/views.py (20)
- M templates/gcd/search/tw_list_sortable.html (2)
Patch Links:
- https://github.com/GrandComicsDatabase/gcd-django/pull/690.patch
- https://github.com/GrandComicsDatabase/gcd-django/pull/690.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
JochenGCD
@jochengcd commented on this pull request.
This is filtering on the story universe, not the character universe ? To clarify, we maybe should label this with 'Story Universe' and not 'Universe' ?
Another thing, in difference to the other filters, here 'None' is a valid selection, i.e. filter for those stories without a universe set. Can we look into adding that ? Not sure if feasible, but the question will come from users.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
JochenGCD
jochengcd left a comment (GrandComicsDatabase/gcd-django#690)https://django-filter.readthedocs.io/en/latest/guide/tips.html
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.