[GrandComicsDatabase/gcd-django] Include variants info on the API (Issue #673)
David Figueroa
dmfigueroa created an issue (GrandComicsDatabase/gcd-django#673)I see the website includes the reprints information and links like https://www.comics.org/issue/16556/ but the story_set array on https://www.comics.org/api/issue/16556/?format=json doesn't include that information
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
JochenGCD
jochengcd left a comment (GrandComicsDatabase/gcd-django#673)Generally, it is not intended that the API exposes all the data. For that the db dump is available.
On variants, the variant relation is present on the variants, pointing to the base. With that, and the list of issues of a series, the variant links can be recovered.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
David Figueroa
dmfigueroa left a comment (GrandComicsDatabase/gcd-django#673)Sorry for the variants thing in the title, that wasn't intended.
It makes sense to not expose everything on the API. I'm working on a tracking app and the reprints data would be useful for a feature that I am planning on building. I don't think the db dump would be useful for this as I would need to do it daily or weekly manually.
I understand if this is not something you'd want to build but GCD is the database I've found with most reprints info with a public API
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
JochenGCD
jochengcd left a comment (GrandComicsDatabase/gcd-django#673)I see.
Somewhat problematic is the end of a reprint link. Mostly it is the story, and I don't see that people would otherwise want to have an API end point for stories. We could of course give pointers to issues, but that would limiting the data provided ?
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
David Figueroa
dmfigueroa left a comment (GrandComicsDatabase/gcd-django#673)I was looking at the data dump and I see that the gcd_reprint table has both the story id as origin_id and the target_id and the origin_issue_id and target_issue_id. WIth this in mind do you think adding something like the following code could be added to the story data on the issue endpoint?
"reprints": [
{
"story_id": 1231241,
"story_link": "https",
"issue_id": 123231,
"issue_link": "https://"
}
]
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
JochenGCD
jochengcd left a comment (GrandComicsDatabase/gcd-django#673)we could add issue id and API-link, but for stories we have no API endpoint and don't intend to add one.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.