[GrandComicsDatabase/gcd-django] fix(gcd): use editing credit type in advanced story search (PR #727)
Josef Andersson
The story_editing branch looks up its credit type with CREDIT_TYPES[field], but
field was left over from the loop above so always 'letters' there. So a search
for stories someone edited returns the ones they lettered. issue_editing already
uses CREDIT_TYPES['editing'] — this matches it.
Tested with one creator credited as editor on one story and letterer on another:
before the change the search returns the lettered story, after it the edited one.
Test covers all six credit fields.
Screenshots are from seeded local data.
You can view, comment on, or merge this pull request online at:
https://github.com/GrandComicsDatabase/gcd-django/pull/727
Commit Summary
- 2256fa1 fix(gcd): use editing credit type in advanced story search
File Changes
(2 files)
- A apps/gcd/tests/test_search.py (83)
- M apps/gcd/views/search.py (2)
Patch Links:
- https://github.com/GrandComicsDatabase/gcd-django/pull/727.patch
- https://github.com/GrandComicsDatabase/gcd-django/pull/727.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
gemini-code-assist[bot]
@gemini-code-assist[bot] commented on this pull request.
Code Review
This pull request fixes a bug in the advanced search functionality within apps/gcd/views/search.py by ensuring that the story filter correctly queries for the 'editing' credit type instead of using the generic 'field' variable. It also introduces a comprehensive test suite in apps/gcd/tests/test_search.py to verify that searches for various credit types (such as script, pencils, inks, colors, letters, and editing) correctly match only their respective credit types. No review comments were provided, so there is no additional feedback.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Josef Andersson
janderssonse left a comment (GrandComicsDatabase/gcd-django#727)—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
JochenGCD
jochengcd left a comment (GrandComicsDatabase/gcd-django#727)Thanks. I think we should integrate the story_editing into the above loop,
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
JochenGCD
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.