[GrandComicsDatabase/gcd-django] Provide search links for text credits, text features and text characters (Issue #542)

1 view
Skip to first unread message

Richard Thomson

unread,
Sep 24, 2022, 9:57:38 PMSep 24
to GrandComicsDatabase/gcd-django, Subscribed

If a credit is linked, it takes you to the creators page where you can search for issues via the linked credits or via the text field.

Being able to navigate through features, characters and creators through the links is incredibly handy.

When those items exist only as a text field on a story, you can still do the search but you must manually copy/paste the field value into the advanced search form in order to find the necessary related items.

It would be more convenient if we could render the text fields as canned links to the advanced search functionality that would perform this search without having to copy/paste the data into the right place on the search form.

I'm not sure if this would generate additional server search load, however.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/542@github.com>

Richard Thomson

unread,
Sep 24, 2022, 9:59:19 PMSep 24
to GrandComicsDatabase/gcd-django, Subscribed

If such links are provided, it would probably be best to render them distinct from existing linked creators/features/characters in order to make it easy at a glance to tell indexers which stories still need migrating.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/542/1257099606@github.com>

JochenGCD

unread,
Sep 29, 2022, 10:46:45 PMSep 29
to GrandComicsDatabase/gcd-django, Subscribed

Text based searches are error prone and expensive. We only want to easily support the db queries and not deprecated functionality.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/542/1263039964@github.com>

JochenGCD

unread,
Sep 29, 2022, 10:46:45 PMSep 29
to GrandComicsDatabase/gcd-django, Subscribed

Closed #542 as completed.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issue/542/issue_event/7491670529@github.com>

Richard Thomson

unread,
Oct 5, 2022, 4:42:39 PMOct 5
to GrandComicsDatabase/gcd-django, Subscribed

I see. I've been mostly migrating credits (which furthers the goal you've stated) and had approvers say "migrating credits isn't that important", so maybe this goal needs to be popularized more :)


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/542/1268952403@github.com>

Richard Thomson

unread,
Oct 5, 2022, 5:54:26 PMOct 5
to GrandComicsDatabase/gcd-django, gcd-github, Comment

In all fairness to the approver, it was only once and it wasn't like my change was rejected, it was just mentioned off-hand in a conversation.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you commented.Message ID: <GrandComicsDatabase/gcd-django/issues/542/1269021219@github.com>

Richard Thomson

unread,
Oct 5, 2022, 5:55:43 PMOct 5
to GrandComicsDatabase/gcd-django, gcd-github, Comment

At any rate, feel free to close this issue as "will not implement" for the reasons stated, with which I'm fine :).


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you commented.Message ID: <GrandComicsDatabase/gcd-django/issues/542/1269022184@github.com>

Reply all
Reply to author
Forward
0 new messages