[GrandComicsDatabase/gcd-django] Features with disambiguation text in [] don't get automatically migrated (Issue #560)

0 views
Skip to first unread message

Richard Thomson

unread,
Oct 14, 2022, 1:45:39 AM10/14/22
to GrandComicsDatabase/gcd-django, Subscribed

An unfortunate side-effect of commit 7e32ad6 is the it unconditionally strips off any [bracketed] text from the feature before it does the search. Some features, such as Daredevil [Marvel] have disambiguating text in the name and will no longer be automatically migrated. They will, however, be found by autocomplete.

So, to fix this regression, we should first search for the full feature name and if that comes back empty, we should do another search with the bracketed text removed. This should work in both the case where the disambiguating text is needed to select the right feature and the case where the bracketed text represents the English version of the translated foreign language feature.


Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/560@github.com>

JochenGCD

unread,
Oct 21, 2022, 5:24:54 PM10/21/22
to GrandComicsDatabase/gcd-django, Subscribed

Closed #560 as completed via #561.


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issue/560/issue_event/7643779909@github.com>

Richard Thomson

unread,
Oct 23, 2022, 2:02:05 PM10/23/22
to GrandComicsDatabase/gcd-django, Subscribed

Works great now, thanks!


Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/issues/560/1288165652@github.com>

Reply all
Reply to author
Forward
0 new messages