[GrandComicsDatabase/gcd-django] Fix user fixtures issue with new Django version not working with sha1 by default (PR #686)

[Adam Knights]

I was following the Docker setup and it worked well up until the point of trying to login, at which point i got username/password does not match.

Django 5.x completely removed support for SHA1 password hashing unless you explicitly add it back to the settings, so this or a similar fix is needed.

---

You can view, comment on, or merge this pull request online at:

  https://github.com/GrandComicsDatabase/gcd-django/pull/686

Commit Summary

• 1cd948e Fix user fixtures issue with new Django version not working with sha1 by default

File Changes

(1 file)

• M apps/indexer/fixtures/users.yaml (6)

Patch Links:

• https://github.com/GrandComicsDatabase/gcd-django/pull/686.patch
• https://github.com/GrandComicsDatabase/gcd-django/pull/686.diff

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: <GrandComicsDatabase/gcd-django/pull/686@github.com>

[Adam Knights]

For anyone running this already, these commands helped me mid-flight to fix the passwords:

docker compose run web python gcd-django/manage.py shell -c "from django.contrib.auth.models import User; u = User.objects.get(username='editor'); u.set_password('editme'); u.save(); print('Editor password updated')"

docker compose run web python gcd-django/manage.py shell -c "from django.contrib.auth.models import User; u = User.objects.get(username='dexter_1234'); u.set_password('test'); u.save(); print('Dexter_1234 password updated')"

Cheers

Adam

[Adam Knights]

I then hit a different issue, this time with an error loading any series page:

'NoneType' object has no attribute 'id' Error during template rendering
In template /code/gcd-django/templates/mycomics/bits/tw_series_control.html, error at line 32

To fix it I had to add some default collections to the fixture. I'm not sure if we would want the fix i've done or something different - this is a separate commit with what I did: https://github.com/adam-knights/gcd-django/commit/d1d055f2df337c7276195f1e2e19241ff45dfa45 

If we want that let me know and I can either add it to the above PR or raise a new one :)

Cheers

Adam