[GrandComicsDatabase/gcd-django] Fix user fixtures issue with new Django version not working with sha1 by default (PR #686)

Adam Knights

unread,

Dec 29, 2025, 6:57:59 PM12/29/25

to GrandComicsDatabase/gcd-django, Subscribed

I was following the Docker setup and it worked well up until the point of trying to login, at which point i got username/password does not match.

Django 5.x completely removed support for SHA1 password hashing unless you explicitly add it back to the settings, so this or a similar fix is needed.

You can view, comment on, or merge this pull request online at:

https://github.com/GrandComicsDatabase/gcd-django/pull/686

Commit Summary

1cd948e Fix user fixtures issue with new Django version not working with sha1 by default

File Changes

(1 file)

M apps/indexer/fixtures/users.yaml (6)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Adam Knights

unread,

Dec 29, 2025, 7:02:35 PM12/29/25

to gcd-tech

For anyone running this already, these commands helped me mid-flight to fix the passwords:

docker compose run web python gcd-django/manage.py shell -c "from django.contrib.auth.models import User; u = User.objects.get(username='editor'); u.set_password('editme'); u.save(); print('Editor password updated')"

docker compose run web python gcd-django/manage.py shell -c "from django.contrib.auth.models import User; u = User.objects.get(username='dexter_1234'); u.set_password('test'); u.save(); print('Dexter_1234 password updated')"

Cheers

Adam

Adam Knights

unread,

Dec 29, 2025, 7:36:04 PM12/29/25

to gcd-tech

I then hit a different issue, this time with an error loading any series page:

'NoneType' object has no attribute 'id' Error during template rendering
In template /code/gcd-django/templates/mycomics/bits/tw_series_control.html, error at line 32

To fix it I had to add some default collections to the fixture. I'm not sure if we would want the fix i've done or something different - this is a separate commit with what I did: https://github.com/adam-knights/gcd-django/commit/d1d055f2df337c7276195f1e2e19241ff45dfa45

If we want that let me know and I can either add it to the above PR or raise a new one :)

Cheers

Adam

JochenGCD

unread,

Dec 30, 2025, 5:38:36 AM12/30/25

to GrandComicsDatabase/gcd-django, Subscribed

@jochengcd approved this pull request.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

JochenGCD

unread,

Dec 30, 2025, 5:38:44 AM12/30/25

to GrandComicsDatabase/gcd-django, Subscribed

Merged #686 into beta.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Jochen G.

unread,

Dec 30, 2025, 5:45:17 AM12/30/25

to gcd-...@googlegroups.com

Please make it separate. beta-users has these added, since we use it all
the time on beta...

thanks

Am 30.12.25 um 01:36 schrieb Adam Knights:

> ------------------------------------------------------------------------

>
>
> You can view, comment on, or merge this pull request
> online at:
>
> https://github.com/GrandComicsDatabase/gcd-django/pull/686

> <https://github.com/GrandComicsDatabase/gcd-django/pull/686>
>
>
> Commit Summary
>
> * 1cd948e <https://github.com/GrandComicsDatabase/gcd-django/
> pull/686/commits/1cd948e4f81447da08be2f9a4bb30014f46c784f>

> Fix user fixtures issue with new Django version not working
> with sha1 by default
>
>
> File Changes
>

> (1 file <https://github.com/GrandComicsDatabase/gcd-django/
> pull/686/files>)
>
> * *M* apps/indexer/fixtures/users.yaml <https://github.com/
> GrandComicsDatabase/gcd-django/pull/686/
> files#diff-92c4cc8dc31dcbe904d30fdf566dba594b1d26f06d21e049b2317b1cdab996a0> (6)
>
>
> Patch Links:
>
> * https://github.com/GrandComicsDatabase/gcd-django/
> pull/686.patch <https://github.com/GrandComicsDatabase/gcd-
> django/pull/686.patch>
> * https://github.com/GrandComicsDatabase/gcd-django/
> pull/686.diff <https://github.com/GrandComicsDatabase/gcd-
> django/pull/686.diff>
>
> —
> Reply to this email directly, view it on GitHub <https://
> github.com/GrandComicsDatabase/gcd-django/pull/686>, or
> unsubscribe <https://github.com/notifications/unsubscribe-auth/
> ADREI2BBGXPF52EA4P7EWSD4EG5YHAVCNFSM6AAAAACQIYEFJOVHI2DSMVQWIX3LMV43ASLTON2WKOZTG43DQNJXG43TCOI>.

> You are receiving this because you are subscribed to this

> thread.Message ID: <GrandComicsDatabase/gcd-django/
> pull/6...@github.com>
>
> --
> You received this message because you are subscribed to the Google
> Groups "gcd-tech" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to gcd-tech+u...@googlegroups.com <mailto:gcd-
> tech+uns...@googlegroups.com>.
> To view this discussion visit https://groups.google.com/d/msgid/gcd-
> tech/0d910834-79e9-48d2-9b7d-b31a27868d8en%40googlegroups.com <https://
> groups.google.com/d/msgid/gcd-tech/0d910834-79e9-48d2-9b7d-
> b31a27868d8en%40googlegroups.com?utm_medium=email&utm_source=footer>.

Adam Knights

unread,

Dec 30, 2025, 9:03:51 AM12/30/25

to gcd-tech

Will raise that now - on a separate note, now that I have it working I'm keen to do some more... I have one more small thing I'll see if I can add but then I guess two questions:

1) anything you would prefer i did differently in dev approach, or PRs fine for now?

2) in order to choose some things to do, what might work best?

Cheers

Adam

Jochen G.

unread,

Dec 31, 2025, 7:00:51 AM12/31/25

to gcd-...@googlegroups.com

PRs for obvious fixes are perfectly fine.

Additional functionality should be discussed beforehand. There might be
reasons why it is not there already, or we can discuss a bit on the how.
etc.

To choose things to do, you can have a look at the issue tracker for
ideas. Although not all are current or should be done.

Jochen

Am 30.12.25 um 15:03 schrieb Adam Knights:

> --
> You received this message because you are subscribed to the Google
> Groups "gcd-tech" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to gcd-tech+u...@googlegroups.com <mailto:gcd-
> tech+uns...@googlegroups.com>.
> To view this discussion visit https://groups.google.com/d/msgid/gcd-

> tech/b54b3865-43c9-4768-94b2-788c7e76877fn%40googlegroups.com <https://
> groups.google.com/d/msgid/gcd-tech/
> b54b3865-43c9-4768-94b2-788c7e76877fn%40googlegroups.com?
> utm_medium=email&utm_source=footer>.

Reply all

Reply to author

Forward