[GrandComicsDatabase/gcd-django] API: Can't use series titles with "/" in them: returns 404 (Issue #671)
Lofter1
Lofter1 created an issue (GrandComicsDatabase/gcd-django#671)When using the API, trying to look up a series like "DC / Marvel: All Access" will result in a 404.
Request URL:
https://www.comics.org/api/series/name/DC%20%2F%20Marvel%3A%20All%20Access/year/1996/
As you can see the "/" in the name was properly encoded and therefor this should not be treated like https://www.comics.org/api/series/name/DC%20/%20Marvel%3A%20All%20Access/year/1996/
This Django ticket might give some useful insights on what might go wrong and possible fixes/workarounds.
https://code.djangoproject.com/ticket/15718
Another workaround could be to match "DC Marvel: All Access" from the URL to "DC / Marvel: All Access" in the DB so that the consumer of the API can just remove "/" from the name and still get proper results. The current workaround would be to remove everything up to the "/" in the name to get valid results.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
JochenGCD
Closed #671 as completed.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
JochenGCD
jochengcd left a comment (GrandComicsDatabase/gcd-django#671)https://www.comics.org/api/series/name/DC%20/%20Marvel:%20All%20Access/year/1996/
now works, which it didn't do before
https://beta.comics.org/api/series/name/DC%20/%20Marvel:%20All%20Access/year/1996/
/ should not be encoded
we are now using path instead of str
https://docs.djangoproject.com/en/5.2/topics/http/urls/
path - Matches any non-empty string, including the path separator, '/'. This allows you to match against a complete URL path rather than a segment of a URL path as with str.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Lofter1
Lofter1 left a comment (GrandComicsDatabase/gcd-django#671)Awesome, thanks for the quick fix!
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.