Next Steps for APIv2

[Adam Hernandez]

Jochen,

Whats the next steps for getting the APIv2 promoted to production. You previously said there were some changes that we need to account for. Have those made it to beta or production? I want to be able to get APIv2 up and running before the end of the year if possible. 

Thanks, 

Adam

[Jochen G.]

The changes for feature names were deployed on the weekend.

Jochen

Am 16.08.26 um 04:04 schrieb Adam Hernandez:

> --
> You received this message because you are subscribed to the Google
> Groups "gcd-tech" group.
> To unsubscribe from this group and stop receiving emails from it, send
> an email to gcd-tech+u...@googlegroups.com <mailto:gcd-
> tech+uns...@googlegroups.com>.
> To view this discussion visit https://groups.google.com/d/msgid/gcd-
> tech/eeb6aaf5-1514-4d93-88cc-9308fdfac80en%40googlegroups.com <https://
> groups.google.com/d/msgid/gcd-tech/
> eeb6aaf5-1514-4d93-88cc-9308fdfac80en%40googlegroups.com?
> utm_medium=email&utm_source=footer>.

[Jochen G.]

I changed the dump script, the new tables should now all be available in it.

This affects features, their access as objects and their connection to
sequences, where these now point to feature names instead of feature
objects, same as for creator names or character names.

Jochen

Am 16.08.26 um 23:35 schrieb 'Jochen G.' via gcd-tech:

[Adam Hernandez]

Thanks, Jochen. I pulled the current beta branch into api-v2 and updated API v2 for the new feature-name tables and relationships. Stories now follow the feature_name links, while the API keeps the existing feature_object response key for compatibility and returns the selected feature name with the parent Feature ID and type. Feature detail now includes active name_details, feature-logo lookups go through feature names, and the affected filters use the new relationships. I also added the migration needed to reconcile the beta and API v2 migration histories.

I opened PR #744 with the changes: https://github.com/GrandComicsDatabase/gcd-django/pull/744

The API v2 test suite and CI checks are green, the review-bot comments have been addressed, and the PR is mergeable without conflicts. When you get a chance, could you take a look? If this looks right, I think the next step is merging it into api-v2, followed by merging api-v2 back into beta for final release testing. Does that match what you had in mind?

[Jochen G.]

Am 23.08.26 um 05:17 schrieb Adam Hernandez:

> The API v2 test suite and CI checks are green, the review-bot comments
> have been addressed, and the PR is mergeable without conflicts. When you
> get a chance, could you take a look? If this looks right, I think the
> next step is merging it into api-v2, followed by merging api-v2 back
> into beta for final release testing. Does that match what you had in mind?

If from your side the api-v2 is fine for testing, I would deploy the
branch on beta.comics.org for some live testing (without merging it into
beta at that time).

Jochen

[Adam Hernandez]

I believe that everything for the APIv2 is ready for testing. Once you deploy to beta.comics.org. I'll start doing some manual testing and stress testing. Just let me know when it's deployed. 

Adam

--
You received this message because you are subscribed to the Google Groups "gcd-tech" group.

To unsubscribe from this group and stop receiving emails from it, send an email to gcd-tech+u...@googlegroups.com.
To view this discussion visit https://groups.google.com/d/msgid/gcd-tech/20564f6d-f1d7-4520-a730-5d9474142268%40garcke.de.