[GrandComicsDatabase/gcd-django] Date range searches use an open interval (Issue #564)

Richard Thomson

unread,

Oct 19, 2022, 11:45:36 AM10/19/22

to GrandComicsDatabase/gcd-django, Subscribed

Consider this search that looks for the feature "Horsepower" from Dark Horse comics:

Note that the start date is 1999-01-01 and it picks up stories from January, 2000.

Now change the start date to 2000-01-01 and you would expect the January, 2000 stories to still be picked up, but now they are omitted.

It appears that the search is using an "open interval" on the date and not a closed interval that includes the start date?

—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.

Richard Thomson

unread,

Oct 19, 2022, 5:55:41 PM10/19/22

to GrandComicsDatabase/gcd-django, Subscribed

I guess this is sort-of explained in the description for date searching at the bottom of the page, but an inclusive interval makes more sense to most people, e.g. searching for dates starting at 1999-12-31 to begin the search at 2000-01-01 seems weird.

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

JochenGCD

unread,

Oct 21, 2022, 5:21:51 PM10/21/22

to GrandComicsDatabase/gcd-django, Subscribed

using 2000-01-01 picks up January 2000 dates ?

https://www.comics.org/search/advanced/process/?target=sequence&method=icontains&logic=False&keywords=&title=&feature=Horsepower&job_number=&pages=&pages_uncertain=&script=&pencils=&inks=&colors=&letters=&story_editing=&first_line=&characters=&synopsis=&reprint_notes=&story_reprinted=&notes=&issues=&volume=&issue_title=&variant_name=&is_variant=&issue_date=&indicia_frequency=&price=&issue_pages=&issue_pages_uncertain=&issue_editing=&isbn=&barcode=&rating=&issue_notes=&issue_reprinted=&is_indexed=&in_selected_collection=on&order1=date&order2=series&order3=&start_date=1999-01-01&end_date=2000-01-01&updated_since=&pub_name=Dark+Horse&pub_notes=&brand_group=&brand_emblem=&brand_notes=&indicia_publisher=&is_surrogate=&ind_pub_notes=&series=&series_year_began=&series_notes=&tracking_notes=&issue_count=&is_comics=&color=&dimensions=&paper_stock=&binding=&publishing_format=

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Richard Thomson

unread,

Oct 22, 2022, 4:21:50 PM10/22/22

to GrandComicsDatabase/gcd-django, Subscribed

I've since migrated the issues from January 2000 so they're not showing up in the search anymore.... Let me create another example

—
Reply to this email directly, view it on GitHub, or unsubscribe.

You are receiving this because you are subscribed to this thread.

Richard Thomson

unread,

Oct 22, 2022, 4:26:38 PM10/22/22

to GrandComicsDatabase/gcd-django, Subscribed

OK, I found another January in the search results, this time for 2005. I'll stop migrating these so the search results remain stable :). I added screen shots of what I see in the results for these two searches.

Dark Horse text/promo Horsepower - Dec 31 2004