[GrandComicsDatabase/gcd-django] Avoid duplicate active-name query in creator name handling (Issue #732)
Adam Hernandez
DeusExTaco created an issue (GrandComicsDatabase/gcd-django#732)Problem
Current beta evaluates as_name.creator.active_names().filter(name=self.name) once for existence and again to retrieve the first match. The lookup can be evaluated once with .first() and reused.
This minor optimization was surfaced by the automated review of synchronization PR #729 and was not introduced by that PR.
Review context:
Suggested acceptance criteria
- Evaluate the matching active-name query once.
- Preserve the existing fallback behavior when no matching name exists.
- Keep or add focused coverage for the matching-name branch.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
JochenGCD
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.