[GrandComicsDatabase/gcd-django] Keep API v1 hyperlinks on v1 routes (PR #762)

Adam Hernandez

unread,

Sep 20, 2026, 3:54:42 PM (10 days ago) Sep 20

to GrandComicsDatabase/gcd-django, Subscribed

Summary

I gave every API v2 router a unique api-v2-prefixed internal basename. This removes the Django URL-name collision that caused API v1 serializers to emit v2 links while leaving all public API v2 paths unchanged.

I also updated the v2 route reversals throughout the test suite and added regression coverage for both the URL resolver and the actual v1 series response.

Verification

Ruff check and format checks pass
All 317 API v2 tests pass
Against the full local production dump, /api/series/10814/ returns a v1 api_url and v1 active_issues links
/api/v2/series/10814/ still returns successfully and resolves through the new v2-specific route name

You can view, comment on, or merge this pull request online at:

https://github.com/GrandComicsDatabase/gcd-django/pull/762

Commit Summary

75f5b98 Isolate API v2 router names

File Changes

(36 files)

Patch Links:

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.

gemini-code-assist[bot]

unread,

Sep 20, 2026, 3:56:14 PM (10 days ago) Sep 20

to GrandComicsDatabase/gcd-django, Subscribed

@gemini-code-assist[bot] commented on this pull request.

Code Review

This pull request isolates the API v2 router names from API v1 by prefixing all v2 router basenames with 'api-v2-' in 'apps/api_v2/urls_www.py'. This change prevents namespace collisions and ensures that each API version correctly reverses its own router names and paths. Correspondingly, all view and performance tests have been updated to use the new prefixed route names. Additionally, new tests have been added to verify that the v1 and v2 router names are isolated and that mounting v2 does not alter hyperlinks emitted by the v1 API. There are no review comments, and I have no feedback to provide.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

JochenGCD

unread,

Sep 21, 2026, 5:05:27 PM (9 days ago) Sep 21

to GrandComicsDatabase/gcd-django, Subscribed

Merged #762 into api-v2.

—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!

You are receiving this because you are subscribed to this thread.

Reply all

Reply to author

Forward