[GrandComicsDatabase/gcd-django] emoji not supported (Issue #629)
JochenGCD
In particular in comments people are using emojis, these are currently not supported due the database character set we are using. Either change the character set on the backend, or catch this error.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
JochenGCD
it likely is enough, if we change it for the comments text field
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.
Adam Hernandez
DeusExTaco left a comment (GrandComicsDatabase/gcd-django#629)I think we can handle this issue with a focused change to the change-history comments rather than trying to catch and reject emojis in the form. The underlying issue is that the existing comments column uses MySQL’s older three-byte UTF-8 encoding, while emojis and some other Unicode characters require utf8mb4. Since we can target MySQL 8.0 or newer, we should update the comments field and its database migration to use utf8mb4, add a regression test that saves and retrieves four-byte Unicode, and remove the current warning that emojis aren’t supported.
For now, I’d keep this issue limited to comments, which should make it a relatively small and low-risk change. We should open a separate issue for converting the rest of the database from the deprecated three-byte encoding to utf8mb4, since that will require a broader review of existing columns, indexes, legacy SQL, and deployment requirements.
One remaining question: is production using MySQL replication, and approximately how large is the oi_changeset_comment table? That will help us determine whether the migration can run normally or should be scheduled during a quieter maintenance window.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
JochenGCD
jochengcd left a comment (GrandComicsDatabase/gcd-django#629)Currently we don't use replication. About 25,000,000 comments, most are empty.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.
Adam Hernandez
DeusExTaco left a comment (GrandComicsDatabase/gcd-django#629)Currently we don't use replication. About 25,000,000 comments, most are empty.
Ok that makes this easier. I'll put together a tightly focused PR to resolve this one. Please assign it to me as well.
—
Reply to this email directly, view it on GitHub, or unsubscribe.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS and Android. Download it today!
You are receiving this because you are subscribed to this thread.